Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YAML] Allow contains/exclude constraints to be used for bitmaps #20359

Merged
merged 3 commits into from
Jul 8, 2022
Merged

[YAML] Allow contains/exclude constraints to be used for bitmaps #20359

merged 3 commits into from
Jul 8, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

Instead of checking an exact value for a bitmap attribute or the FeatureMap attribute, one may want to check for the presence of a given flag.

Change overview

  • Add yaml tests support for it

@vivien-apple vivien-apple self-assigned this Jul 6, 2022
@restyled-io restyled-io bot mentioned this pull request Jul 6, 2022
Closed
@vivien-apple vivien-apple force-pushed the YAML_AllowContainsExcludesForBitmaps branch from 51c608d to c583861 Compare July 6, 2022 15:37
@vivien-apple vivien-apple force-pushed the YAML_AllowContainsExcludesForBitmaps branch from c583861 to 1158db7 Compare July 6, 2022 15:40
@github-actions
Copy link

github-actions bot commented Jul 6, 2022 •
edited
Loading

PR #20359: Size comparison from 126f6b2 to 1158db7

Increases (4 builds for cc13x2_26x2, efr32, linux, telink)
platform target config section 126f6b2 1158db7 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 164512 164520 8 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1127272 1127288 16 0.0
.text 981004 981020 16 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9939972 9943396 3424 0.0
.rodata 473508 474020 512 0.1
.text 7926164 7929076 2912 0.0
telink lighting-app tlsr9518adk80d text 581454 581456 2 0.0
Decreases (2 builds for cc13x2_26x2, telink)
platform target config section 126f6b2 1158db7 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 677703 677695 -8 -0.0
.text 588788 588780 -8 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 796636 796628 -8 -0.0
text 565130 565128 -2 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 126f6b2 1158db7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665443 665443 0 0.0
(read/write) 185780 185780 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577060 577060 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631443 631443 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 553812 553812 0 0.0
lock-ftd LP_CC2652R7 (read only) 668343 668343 0 0.0
(read/write) 173024 173024 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 591656 591656 0 0.0
lock-mtd LP_CC2652R7 (read only) 617759 617759 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541184 541184 0 0.0
pump-app LP_CC2652R7 (read only) 677703 677695 -8 -0.0
(read/write) 164512 164520 8 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 588788 588780 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 663527 663527 0 0.0
(read/write) 178808 178808 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 578752 578752 0 0.0
shell LP_CC2652R7 (read only) 657942 657942 0 0.0
(read/write) 188784 188784 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572780 572780 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579134 579134 0 0.0
.app_xip_area 457904 457904 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 584862 584862 0 0.0
.app_xip_area 458896 458896 0 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582206 582206 0 0.0
.app_xip_area 461824 461824 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080652 1080652 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945588 945588 0 0.0
BRD4161A+rpc (read only) 983040 983040 0 0.0
(read/write) 151948 151948 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983032 983032 0 0.0
BRD4161A+rs911x (read/write) 946756 946756 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803920 803920 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127272 1127288 16 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 981004 981020 16 0.0
window-app BRD4161A (read/write) 1074436 1074436 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937868 937868 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019368 1019368 0 0.0
(read/write) 1485050 1485050 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214936 214936 0 0.0
.flash.text 1019368 1019368 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073243 1073243 0 0.0
(read/write) 487136 487136 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245396 245396 0 0.0
.flash.text 1067859 1067859 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658192 658192 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 580884 0 0.0
lock k32w061+release (read/write) 684788 684788 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607004 607004 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9939972 9943396 3424 0.0
(read/write) 675889 675889 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614864 614864 0 0.0
.dynamic 528 528 0 0.0
.got 13448 13448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473508 474020 512 0.1
.text 7926164 7929076 2912 0.0
thermostat-no-ble arm64 (read only) 2592644 2592644 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187520 2187520 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447400 2447400 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410044 1410044 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173807 1173807 0 0.0
bss 142900 142900 0 0.0
rodata 141376 141376 0 0.0
text 810640 810640 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154691 0 0.0
bss 142136 142136 0 0.0
rodata 133308 133308 0 0.0
text 800360 800360 0 0.0
p6 all-clusters-app default (read/write) 2563088 2563088 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521352 1521352 0 0.0
all-clusters-minimal-app default (read/write) 2508952 2508952 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467216 1467216 0 0.0
light-app default (read/write) 2439240 2439240 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397504 1397504 0 0.0
lock-app default (read/write) 2465672 2465672 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423936 1423936 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796636 796628 -8 -0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565130 565128 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 816464 816464 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581454 581456 2 0.0

@woody-apple woody-apple force-pushed the YAML_AllowContainsExcludesForBitmaps branch from 1158db7 to 343216e Compare July 6, 2022 23:12
@github-actions
Copy link

github-actions bot commented Jul 6, 2022 •
edited
Loading

PR #20359: Size comparison from 9e982ce to 343216e

Increases (4 builds for cc13x2_26x2, esp32, linux)
platform target config section 9e982ce 343216e change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 164512 164520 8 0.0
esp32 all-clusters-app c3devkit (read only) 1019366 1019368 2 0.0
.flash.text 1019366 1019368 2 0.0
linux chip-tool debug (read only) 10231713 10235793 4080 0.0
.rodata 511509 512053 544 0.1
.text 8310836 8314372 3536 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9931684 9935092 3408 0.0
.rodata 473556 474068 512 0.1
.text 7920084 7922980 2896 0.0
Decreases (2 builds for cc13x2_26x2, telink)
platform target config section 9e982ce 343216e change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 677703 677695 -8 -0.0
.text 588788 588780 -8 -0.0
telink lighting-app tlsr9518adk80d text 581456 581454 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9e982ce 343216e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665443 665443 0 0.0
(read/write) 185780 185780 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577060 577060 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631443 631443 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 553812 553812 0 0.0
lock-ftd LP_CC2652R7 (read only) 668343 668343 0 0.0
(read/write) 173024 173024 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 591656 591656 0 0.0
lock-mtd LP_CC2652R7 (read only) 617759 617759 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541184 541184 0 0.0
pump-app LP_CC2652R7 (read only) 677703 677695 -8 -0.0
(read/write) 164512 164520 8 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 588788 588780 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 663527 663527 0 0.0
(read/write) 178808 178808 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 578752 578752 0 0.0
shell LP_CC2652R7 (read only) 657942 657942 0 0.0
(read/write) 188784 188784 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572780 572780 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579134 579134 0 0.0
.app_xip_area 457904 457904 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 584862 584862 0 0.0
.app_xip_area 458896 458896 0 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582206 582206 0 0.0
.app_xip_area 461824 461824 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080652 1080652 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945588 945588 0 0.0
BRD4161A+rpc (read only) 983040 983040 0 0.0
(read/write) 151948 151948 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983032 983032 0 0.0
BRD4161A+rs911x (read/write) 946756 946756 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803920 803920 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127288 1127288 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 981020 981020 0 0.0
window-app BRD4161A (read/write) 1074436 1074436 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937868 937868 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019366 1019368 2 0.0
(read/write) 1485050 1485050 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214936 214936 0 0.0
.flash.text 1019366 1019368 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073243 1073243 0 0.0
(read/write) 487136 487136 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245396 245396 0 0.0
.flash.text 1067859 1067859 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658192 658192 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 580884 0 0.0
lock k32w061+release (read/write) 684788 684788 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607004 607004 0 0.0
linux all-clusters-app debug (read only) 2955793 2955793 0 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263133 263133 0 0.0
.text 2515474 2515474 0 0.0
all-clusters-minimal-app debug (read only) 2809921 2809921 0 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264829 264829 0 0.0
.text 2370082 2370082 0 0.0
bridge-app debug+rpc (read only) 2312761 2312761 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1953074 1953074 0 0.0
chip-tool debug (read only) 10231713 10235793 4080 0.0
(read/write) 612736 612736 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 578368 578368 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 511509 512053 544 0.1
.text 8310836 8314372 3536 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9931684 9935092 3408 0.0
(read/write) 674929 674929 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613912 613912 0 0.0
.dynamic 528 528 0 0.0
.got 13440 13440 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473556 474068 512 0.1
.text 7920084 7922980 2896 0.0
lighting-app debug+rpc (read only) 2548281 2548281 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2164674 2164674 0 0.0
lock-app debug (read only) 2510849 2510849 0 0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228232 228232 0 0.0
.text 2117474 2117474 0 0.0
ota-provider-app debug (read only) 2319585 2319585 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1953394 1953394 0 0.0
ota-requestor-app debug (read only) 2436705 2436705 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207200 207200 0 0.0
.text 2058354 2058354 0 0.0
shell debug (read only) 2546121 2546121 0 0.0
(read/write) 141096 141096 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227250 227250 0 0.0
.text 2161794 2161794 0 0.0
thermostat-no-ble arm64 (read only) 2592644 2592644 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187520 2187520 0 0.0
tv-app debug (read only) 3099713 3099713 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248928 248928 0 0.0
.text 2662882 2662882 0 0.0
tv-casting-app debug (read only) 5562817 5562817 0 0.0
(read/write) 161968 161968 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343209 343209 0 0.0
.text 4941746 4941746 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447400 2447400 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410044 1410044 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173807 1173807 0 0.0
bss 142900 142900 0 0.0
rodata 141376 141376 0 0.0
text 810640 810640 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154691 0 0.0
bss 142136 142136 0 0.0
rodata 133308 133308 0 0.0
text 800360 800360 0 0.0
p6 all-clusters-app default (read/write) 2563088 2563088 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521352 1521352 0 0.0
all-clusters-minimal-app default (read/write) 2508952 2508952 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467216 1467216 0 0.0
light-app default (read/write) 2439240 2439240 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397504 1397504 0 0.0
lock-app default (read/write) 2465672 2465672 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423936 1423936 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796636 796636 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565130 565130 0 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816464 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581456 581454 -2 -0.0

@vivien-apple vivien-apple force-pushed the YAML_AllowContainsExcludesForBitmaps branch from 343216e to 3cbd574 Compare July 8, 2022 08:14
@vivien-apple vivien-apple force-pushed the YAML_AllowContainsExcludesForBitmaps branch from 3cbd574 to 27b63fa Compare July 8, 2022 08:45
@github-actions
Copy link

github-actions bot commented Jul 8, 2022 •
edited
Loading

PR #20359: Size comparison from 996f5f3 to 27b63fa

Increases (4 builds for k32w, linux, telink)
platform target config section 996f5f3 27b63fa change % change
k32w lock k32w061+release (read/write) 684948 684964 16 0.0
.text 607164 607180 16 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9986740 9989956 3216 0.0
.rodata 475828 476340 512 0.1
.text 7952564 7955268 2704 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796628 796636 8 0.0
text 565128 565130 2 0.0
lighting-app tlsr9518adk80d text 581452 581454 2 0.0
Full report (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
platform target config section 996f5f3 27b63fa change % change
cyw30739 light cyw930739m2evb_01 (read/write) 579134 579134 0 0.0
.app_xip_area 457904 457904 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585070 585070 0 0.0
.app_xip_area 459104 459104 0 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582206 582206 0 0.0
.app_xip_area 461824 461824 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 658192 658192 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 580884 0 0.0
lock k32w061+release (read/write) 684948 684964 16 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607164 607180 16 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9986740 9989956 3216 0.0
(read/write) 683569 683569 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 622480 622480 0 0.0
.dynamic 528 528 0 0.0
.got 13512 13512 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 475828 476340 512 0.1
.text 7952564 7955268 2704 0.0
thermostat-no-ble arm64 (read only) 2592644 2592644 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187520 2187520 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447488 2447488 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410132 1410132 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174495 1174495 0 0.0
bss 142900 142900 0 0.0
rodata 141776 141776 0 0.0
text 810916 810916 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154691 0 0.0
bss 142136 142136 0 0.0
rodata 133308 133308 0 0.0
text 800360 800360 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796628 796636 8 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565128 565130 2 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816464 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581452 581454 2 0.0

@vivien-apple vivien-apple force-pushed the YAML_AllowContainsExcludesForBitmaps branch from 27b63fa to 01e6556 Compare July 8, 2022 09:13
@github-actions
Copy link

github-actions bot commented Jul 8, 2022 •
edited
Loading

PR #20359: Size comparison from 996f5f3 to 01e6556

Increases (5 builds for esp32, k32w, linux, telink)
platform target config section 996f5f3 01e6556 change % change
esp32 all-clusters-app c3devkit (read only) 1019472 1019474 2 0.0
.flash.text 1019472 1019474 2 0.0
k32w lock k32w061+release (read/write) 684948 684964 16 0.0
.text 607164 607180 16 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9986740 9989956 3216 0.0
.rodata 475828 476340 512 0.1
.text 7952564 7955268 2704 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796628 796636 8 0.0
text 565128 565130 2 0.0
lighting-app tlsr9518adk80d text 581452 581454 2 0.0
Decreases (1 build for nrfconnect)
platform target config section 996f5f3 01e6556 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174495 1174479 -16 -0.0
text 810916 810912 -4 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 996f5f3 01e6556 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665651 665651 0 0.0
(read/write) 185572 185572 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577268 577268 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631443 631443 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 553812 553812 0 0.0
lock-ftd LP_CC2652R7 (read only) 668551 668551 0 0.0
(read/write) 172816 172816 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 591864 591864 0 0.0
lock-mtd LP_CC2652R7 (read only) 617959 617959 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541384 541384 0 0.0
pump-app LP_CC2652R7 (read only) 677703 677703 0 0.0
(read/write) 164512 164512 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 588788 588788 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663527 663527 0 0.0
(read/write) 178808 178808 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 578752 578752 0 0.0
shell LP_CC2652R7 (read only) 658150 658150 0 0.0
(read/write) 188576 188576 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572988 572988 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579134 579134 0 0.0
.app_xip_area 457904 457904 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585070 585070 0 0.0
.app_xip_area 459104 459104 0 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582206 582206 0 0.0
.app_xip_area 461824 461824 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080652 1080652 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945588 945588 0 0.0
BRD4161A+rpc (read only) 983040 983040 0 0.0
(read/write) 151948 151948 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983032 983032 0 0.0
BRD4161A+rs911x (read/write) 946756 946756 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803920 803920 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127960 1127960 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 981692 981692 0 0.0
window-app BRD4161A (read/write) 1074436 1074436 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937868 937868 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019472 1019474 2 0.0
(read/write) 1485458 1485458 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215344 215344 0 0.0
.flash.text 1019472 1019474 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073383 1073383 0 0.0
(read/write) 487536 487536 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245796 245796 0 0.0
.flash.text 1067999 1067999 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658192 658192 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 580884 0 0.0
lock k32w061+release (read/write) 684948 684964 16 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607164 607180 16 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9986740 9989956 3216 0.0
(read/write) 683569 683569 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 622480 622480 0 0.0
.dynamic 528 528 0 0.0
.got 13512 13512 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 475828 476340 512 0.1
.text 7952564 7955268 2704 0.0
thermostat-no-ble arm64 (read only) 2592644 2592644 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187520 2187520 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447488 2447488 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410132 1410132 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174495 1174479 -16 -0.0
bss 142900 142900 0 0.0
rodata 141776 141776 0 0.0
text 810916 810912 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154691 0 0.0
bss 142136 142136 0 0.0
rodata 133308 133308 0 0.0
text 800360 800360 0 0.0
p6 all-clusters-app default (read/write) 2563896 2563896 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1522160 1522160 0 0.0
all-clusters-minimal-app default (read/write) 2508952 2508952 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467216 1467216 0 0.0
light-app default (read/write) 2439240 2439240 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397504 1397504 0 0.0
lock-app default (read/write) 2466496 2466496 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1424760 1424760 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796628 796636 8 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565128 565130 2 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816464 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581452 581454 2 0.0

@vivien-apple vivien-apple merged commit 8ebd7f0 into project-chip:master Jul 8, 2022
github-actions bot pushed a commit that referenced this pull request Jul 8, 2022
@vivien-apple @web-flow
[YAML] Allow contains/exclude constraints to be used for bitmaps (#20359
260ed7c 
)
woody-apple added a commit that referenced this pull request Jul 8, 2022
@woody-apple @vivien-apple
[YAML] Allow contains/exclude constraints to be used for bitmaps (#20359
7ff29f5 
) (#20483)

Co-authored-by: Vivien Nicolas <[email protected]>
@jmeg-sfy jmeg-sfy linked an issue Sep 5, 2022 that may be closed by this pull request
[TC-WNCV-xx] YAML Update tests case to use hasMaskSet hasMaskClear to check bitmaps #14491
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
app darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TC-WNCV-xx] YAML Update tests case to use hasMaskSet hasMaskClear to check bitmaps
3 participants
@vivien-apple @tcarmelveilleux @Damian-Nordic