Descope less relevant unit tests from unified build variants #20950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq and
Byungjoo-Lee
pullapprove
bot
requested review from
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
saurabhst
pullapprove
bot
requested review from
xylophone21,
yufengwangca and
yunhanw-google
mspang
commented
Jul 19, 2022
cecille
reviewed
Jul 19, 2022
mspang
force-pushed
the
for-chip/speed-up-unified
branch
from
cb6a676 to
5c20d4b
Compare
|
PR #20950: Size comparison from 4cdecc9 to 5c20d4b Increases (1 build for cc13x2_26x2)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 19, 2022
mspang
force-pushed
the
for-chip/speed-up-unified
branch
from
5c20d4b to
1a6210e
Compare
|
PR #20950: Size comparison from e4cc869 to 1a6210e Increases (4 builds for bl602, esp32, nrfconnect, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jul 20, 2022
mspang
force-pushed
the
for-chip/speed-up-unified
branch
from
1a6210e to
cd57892
Compare
|
PR #20950: Size comparison from 4a56906 to cd57892 Increases (3 builds for esp32, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
mspang
force-pushed
the
for-chip/speed-up-unified
branch
from
cd57892 to
b4543de
Compare
|
PR #20950: Size comparison from 1d88b32 to b4543de Increases (3 builds for bl602, cc13x2_26x2, telink)
Decreases (2 builds for cyw30739, nrfconnect)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Switch to more targeted testing of just crypto oriented tests for the MbedTLS build and just tests that need the fake platform for the fake platform build. This reduces the blowup in execution time from running the cartesian product of builds x tests and saves about 30% of default work done by gn_build.sh.
mspang
force-pushed
the
for-chip/speed-up-unified
branch
from
b4543de to
3a31950
Compare
|
PR #20950: Size comparison from 14c3b57 to 3a31950 Increases (4 builds for esp32, nrfconnect, telink)
Decreases (2 builds for bl602, cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
Switch to more targeted testing of just crypto oriented tests for the MbedTLS build and just tests that need the fake platform for the fake platform build. This reduces the blowup in execution time from running the cartesian product of builds x tests and saves about 30% of default work done by gn_build.sh.
woody-apple
pushed a commit
that referenced
this pull request
Jul 27, 2022
Switch to more targeted testing of just crypto oriented tests for the MbedTLS build and just tests that need the fake platform for the fake platform build. This reduces the blowup in execution time from running the cartesian product of builds x tests and saves about 30% of default work done by gn_build.sh.
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…-chip#20950) Switch to more targeted testing of just crypto oriented tests for the MbedTLS build and just tests that need the fake platform for the fake platform build. This reduces the blowup in execution time from running the cartesian product of builds x tests and saves about 30% of default work done by gn_build.sh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
gn_build.shruns all tests with MbedTLS + OpenSSL. We've recently addedBoringSSL and doing a full test run across all crypto backends will be costlier
than justified by the coverage increase.
The ultimate goal is to run the CryptoPAL test with BoringSSL from
gn_build.sh.Change overview
Switch to more targeted testing of just crypto oriented tests for the
MbedTLS build and just tests that need the fake platform for the fake
platform build.
This reduces the blowup in execution time from running the cartesian
product of configs x tests and saves about 30% of default work done by
gn_build.sh.
Testing
gn_build.sh