-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused "InsufficientPrivilege" NOCResponse status #21072
Merged
andy31415
merged 7 commits into
project-chip:master
from
tcarmelveilleux:remove-insufficient-privilege
Jul 22, 2022
Merged
Remove unused "InsufficientPrivilege" NOCResponse status #21072
andy31415
merged 7 commits into
project-chip:master
from
tcarmelveilleux:remove-insufficient-privilege
Jul 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
July 21, 2022 19:41
pullapprove
bot
requested review from
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
July 21, 2022 19:41
PR #21072: Size comparison from 1d88b32 to 4ee294b Increases (6 builds for cc13x2_26x2)
Decreases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 21, 2022
PR #21072: Size comparison from c3e71f2 to 01bc04d Increases (6 builds for cc13x2_26x2)
Decreases (42 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Full report (42 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jul 22, 2022
PR #21072: Size comparison from c3e71f2 to 2e59d86 Increases (36 builds for cc13x2_26x2, cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
Decreases (16 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, telink)
Full report (42 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
* Remove InsufficientPrivilege no longer used * ZAP regen * Zap regen * Regen zap * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
woody-apple
added a commit
that referenced
this pull request
Jul 25, 2022
…1124) * Remove InsufficientPrivilege no longer used * ZAP regen * Zap regen * Regen zap * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> Co-authored-by: Restyled.io <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…p#21072) * Remove InsufficientPrivilege no longer used * ZAP regen * Zap regen * Regen zap * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #20849 we fixed IM handling of fabric-scoped commands over PASE.
Even though it's not longer used, there are bits of InsufficientPrivilege NOCResponse
status left.
Fixes #20811
Change overview
This PR removes unused InsufficientPrivilege NOCResponse
Testing