-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix status of fabric-scoped commands running in PASE #20849
Merged
tcarmelveilleux
merged 8 commits into
project-chip:master
from
tcarmelveilleux:fix-fabric-scoped-20811
Jul 18, 2022
Merged
Fix status of fabric-scoped commands running in PASE #20849
tcarmelveilleux
merged 8 commits into
project-chip:master
from
tcarmelveilleux:fix-fabric-scoped-20811
Jul 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13 and
harimau-qirex
July 18, 2022 03:22
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
July 18, 2022 03:22
PR #20849: Size comparison from aa9457e to 4bcd805 Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 18, 2022
PR #20849: Size comparison from e4cfa0a to 0624e10 Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #20849: Size comparison from e4cfa0a to 64f4dfe Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bluebin14
approved these changes
Jul 18, 2022
andy31415
reviewed
Jul 18, 2022
andy31415
approved these changes
Jul 18, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 18, 2022
* Fix status on fabric-scoped commnads in PASE * Add cirque test * Fixed typo * Revert file committed by mistake * Fix CI * Apply review comments from @bzbarsky-apple
woody-apple
added a commit
that referenced
this pull request
Jul 18, 2022
* Fix status on fabric-scoped commnads in PASE * Add cirque test * Fixed typo * Revert file committed by mistake * Fix CI * Apply review comments from @bzbarsky-apple Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
with an UNSUPPORTED_ACCESS. Instead, they went by but the command
handler saw invalid fabric index.
UNSUPPORTED_ACCESS when executed over PASE before AddNOC causes
a fabric association.
Issue #20811
Change overview
cluster-objects-src.zapt. Real code-gen will be done
as a follow-up when ZAP has support in XML and helpers
for fabric-scoped command labeling
as expected.
cannot easily be unit-tested without a lot of work, due
to requiring a PASE session, but a good integration test is
possible.
broken.
Testing