-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QPG] Update flow for Server init in example apps #20733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
July 14, 2022 14:14
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
July 14, 2022 14:14
PR #20733: Size comparison from 4bb1abd to 77d33c2 Increases (1 build for esp32)
Decreases (3 builds for bl602, telink)
Full report (38 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Fast tracking platform changes. |
woody-apple
approved these changes
Jul 16, 2022
…rmEvents * Only open commissioning window when no fabric exists (lighting-app)
tima-q
force-pushed
the
qpg/update_apps_init
branch
from
July 19, 2022 08:53
77d33c2
to
308e7a5
Compare
PR #20733: Size comparison from ea78432 to 308e7a5 Increases (2 builds for esp32, nrfconnect)
Decreases (4 builds for bl602, cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Jul 20, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
…rmEvents (#20733) * Only open commissioning window when no fabric exists (lighting-app)
woody-apple
added a commit
that referenced
this pull request
Jul 27, 2022
…rmEvents (#20733) (#21098) * Only open commissioning window when no fabric exists (lighting-app) Co-authored-by: Timothy Maes <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…rmEvents (project-chip#20733) * Only open commissioning window when no fabric exists (lighting-app)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
RejoinExistingMulticastGroups()
, called from the Thread manager's_OnPlatformEvent()
handling (CHIP task) as it could be called before the server intialized the Fabric list.Change overview
RejoinExistingMulticastGroups()
is actually functional.Testing
** Possibility for crash before the fix
** After fix, no crash seen - init flow runs from same task context (checked with debugger/logging)