Merge pull request #49 from project-chip/master

update master

.clang-tidy

@@ -1,4 +1,37 @@
 ---
-Checks: '-*,bugprone-use-after-move'
+Checks: >
+  readability-else-after-return,
+  modernize-use-nullptr,
+  bugprone-*,
+  -bugprone-not-null-terminated-result,
+  -bugprone-unused-return-value,
+  -bugprone-branch-clone,
+  -bugprone-easily-swappable-parameters,
+  -bugprone-reserved-identifier,
+  -bugprone-macro-parentheses,
+  -bugprone-forward-declaration-namespace,
+  -bugprone-forwarding-reference-overload,
+  -bugprone-undelegated-constructor,
+  -bugprone-implicit-widening-of-multiplication-result,
+  -bugprone-narrowing-conversions,
+  -bugprone-misplaced-widening-cast,
+  -bugprone-suspicious-include,
+  -bugprone-signed-char-misuse,
+  -bugprone-copy-constructor-init,
+  -clang-analyzer-core.CallAndMessage,
+  -clang-analyzer-core.NullDereference,
+  -clang-analyzer-optin.cplusplus.UninitializedObject,
+  -clang-analyzer-optin.performance,
+  -clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker,
+  -clang-analyzer-deadcode.DeadStores,
+  -clang-analyzer-cplusplus.Move,
+  -clang-analyzer-optin.cplusplus.VirtualCall,
+  -clang-analyzer-security.insecureAPI.strcpy,
+  -clang-analyzer-nullability.NullablePassedToNonnull,
+  -clang-analyzer-optin.performance.Padding,
+  -clang-analyzer-security.insecureAPI.rand,
+  -clang-analyzer-core.NonNullParamChecker,
+  -clang-analyzer-unix.Malloc,
+  -clang-diagnostic-implicit-int-conversion
 WarningsAsErrors: '*'
-HeaderFilterRegex: ''
+HeaderFilterRegex: '(src|examples|zzz_generated|credentials).*(?<!third_party.*repo)'

.devcontainer/Dockerfile

@@ -35,7 +35,8 @@ RUN apt-get -fy install git vim emacs sudo \
     wget curl telnet \
     docker.io \
     iputils-ping net-tools \
-    libncurses5
+    libncurses5 \
+    libpython2.7
 
 RUN groupadd -g $USER_GID $USERNAME
 RUN useradd -s /bin/bash -u $USER_UID -g $USER_GID -G docker -m $USERNAME
@@ -72,3 +73,16 @@ RUN chown -R $USERNAME:$USERNAME /opt/ameba/ambd_sdk_with_chip_non_NDA/
 
 # NXP uses a patch_sdk script to change SDK files
 RUN chown -R $USERNAME:$USERNAME /opt/sdk/sdks/
+
+RUN chown -R $USERNAME:$USERNAME /opt/fsl-imx-xwayland/5.15-kirkstone/
+
+# Add access to openocd for VSCode debugging
+RUN chown -R $USERNAME:$USERNAME /opt/openocd
+
+# Fix Tizen SDK paths for new user
+RUN sed -i '/^TIZEN_SDK_DATA_PATH/d' $TIZEN_SDK_ROOT/sdk.info \
+    && echo TIZEN_SDK_DATA_PATH=/home/$USERNAME/tizen-sdk-data >> $TIZEN_SDK_ROOT/sdk.info \
+    && ln -sf /home/$USERNAME/.tizen-cli-config $TIZEN_SDK_ROOT/tools/.tizen-cli-config \
+    && : # last line
+
+ENV TIZEN_ROOTFS /tizen_rootfs

.devcontainer/devcontainer.json

@@ -17,28 +17,30 @@
     "build": {
         "dockerfile": "Dockerfile",
         "args": {
-            "BUILD_VERSION": "0.5.48"
+            "BUILD_VERSION": "0.5.84"
         }
     },
     "remoteUser": "vscode",
     // Add the IDs of extensions you want installed when the container is created in the array below.
     "extensions": [
-        "ms-azuretools.vscode-docker",
-        "xaver.clang-format",
-        "github.vscode-pull-request-github",
-        "maelvalais.autoconf",
-        "yzhang.markdown-all-in-one",
-        "eamodio.gitlens",
-        "yuichinukiyama.vscode-preview-server",
         "aaron-bond.better-comments",
-        "foxundermoon.shell-format",
+        "augustocdias.tasks-shell-input",
+        "christian-kohler.path-intellisense",
+        "eamodio.gitlens",
         "editorconfig.editorconfig",
         "esbenp.prettier-vscode",
-        "redhat.vscode-yaml",
-        "christian-kohler.path-intellisense",
+        "foxundermoon.shell-format",
+        "github.vscode-pull-request-github",
         "knisterpeter.vscode-github",
+        "maelvalais.autoconf",
+        "marus25.cortex-debug",
+        "ms-azuretools.vscode-docker",
+        "msedge-dev.gnls",
         "npclaudiu.vscode-gn",
-        "marus25.cortex-debug"
+        "redhat.vscode-yaml",
+        "xaver.clang-format",
+        "yuichinukiyama.vscode-preview-server",
+        "yzhang.markdown-all-in-one"
     ],
     // Use 'settings' to set *default* container specific settings.json values on container create.
     // You can edit these settings after create using File > Preferences > Settings > Remote.

.flake8

@@ -0,0 +1,2 @@
+[flake8]
+max-line-length = 132

.gitattributes

@@ -3,7 +3,7 @@
 # Same for files in zap-generated folders
 **/zap-generated/** linguist-generated
 # And some specific generated files
-src/controller/python/chip/clusters/CHIPClusters.cpp linguist-generated
 src/controller/python/chip/clusters/CHIPClusters.py linguist-generated
 src/controller/python/chip/clusters/Objects.py linguist-generated
-src/darwin/Framework/CHIPTests/CHIPClustersTests.m linguist-generated
+# Let bat file use CRLF linebreak
+**/*.bat eol=crlf