Adds bugfix for lwip multicast group commands #20136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
kghost
andy31415
reviewed
Jul 6, 2022
rosahay-silabs
force-pushed
the
bugfix/lwip-group-multicast
branch
from
46b26a4 to
17fba74
Compare
|
PR #20136: Size comparison from 2377087 to 17fba74 Increases (12 builds for cc13x2_26x2, esp32, p6)
Decreases (6 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
rosahay-silabs
force-pushed
the
bugfix/lwip-group-multicast
branch
from
17fba74 to
087af03
Compare
|
PR #20136: Size comparison from acbe9cd to 087af03 Increases (9 builds for cc13x2_26x2, efr32, esp32, p6)
Decreases (1 build for telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
Jul 7, 2022
andy31415
approved these changes
Jul 7, 2022
andy31415
dismissed
bzbarsky-apple’s stale review
Obsolete - fix path was updated to fix the all-interface multicast joining
jmartinez-silabs
approved these changes
Jul 7, 2022
|
@andy31415 |
Updated code to be consistent. Ended up to making a hybrid of the two that is hopefully readable (after slack discussion with @rosahay-silabs ) |
|
PR #20136: Size comparison from b14e1f5 to 997d148 Increases (11 builds for cc13x2_26x2, cyw30739, efr32, esp32, p6, telink)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
* Adds fix for IPV6 multicast * Revert LwIP options * Adds fix for warning on ESP32 toolchain * Adds changes to incorporate InterfaceId:Null() for LWIP * Add IPv4 support for non-interface join/leave group * Fix some typos - compile tested with esp32 * Reformat code for readability and consistency Co-authored-by: Andrei Litvin <[email protected]>
woody-apple
added a commit
that referenced
this pull request
Jul 8, 2022
* Adds fix for IPV6 multicast * Revert LwIP options * Adds fix for warning on ESP32 toolchain * Adds changes to incorporate InterfaceId:Null() for LWIP * Add IPv4 support for non-interface join/leave group * Fix some typos - compile tested with esp32 * Reformat code for readability and consistency Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Rohan Sahay <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
netifbeing returned as null fromGetNetIfByInterface()which callsnetif_get_by_index()with index value0. The function returnsNULLif index0is passed as a reference to find thenetiffrom the list of netifs maintained by LwIP.Fixes #20286
Change overview
Adds fix for group commands based on UDP multicast.
Testing
No new unit test cases added, since this is part of TC-SC-5.1 and TC-SC-5.2.
Platforms tested:
RPI4 (chip-tool) + EFR32 + (rs9116/wf200)
Depends upon #20123
Reopening on #20133