-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32]Feature wifinetworkdiagnostics implmentation for RS9116 #20123
Merged
bzbarsky-apple
merged 5 commits into
project-chip:master
from
rosahay-silabs:feature/wifinetworkdiagnostics_impl
Jul 1, 2022
Merged
[EFR32]Feature wifinetworkdiagnostics implmentation for RS9116 #20123
bzbarsky-apple
merged 5 commits into
project-chip:master
from
rosahay-silabs:feature/wifinetworkdiagnostics_impl
Jul 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248 and
isiu-apple
June 29, 2022 19:05
pullapprove
bot
requested review from
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
June 29, 2022 19:05
This depends upon #20106 |
PR #20123: Size comparison from f03b9ae to 5e22119 Increases above 0.2%:
Increases (7 builds for cc13x2_26x2, cyw30739, efr32, esp32, nrfconnect)
Decreases (3 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #20123: Size comparison from f03b9ae to d416925 Increases above 0.2%:
Increases (6 builds for cc13x2_26x2, cyw30739, efr32, telink)
Decreases (4 builds for cc13x2_26x2, esp32, nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
rcasallas-silabs
approved these changes
Jun 30, 2022
mrjerryjohns
approved these changes
Jun 30, 2022
bzbarsky-apple
requested changes
Jun 30, 2022
chirag-silabs
force-pushed
the
feature/wifinetworkdiagnostics_impl
branch
from
June 30, 2022 22:49
d416925
to
9e881a6
Compare
PR #20123: Size comparison from 1f20e2b to 9e881a6 Full report (4 builds for cyw30739, mbed)
|
bzbarsky-apple
approved these changes
Jun 30, 2022
PR #20123: Size comparison from 1f20e2b to 9e4389f Increases (4 builds for cc13x2_26x2, efr32, telink)
Decreases (5 builds for cc13x2_26x2, cyw30739, k32w, nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #20123: Size comparison from a295bec to c40001c Increases (5 builds for cc13x2_26x2, efr32, telink)
Decreases (3 builds for cc13x2_26x2, nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing implementation for wifinetworkdiagnostics cluster for RS9116
Change overview
Added implementation for wifinetworkdiagnostics for EFR32+RS9116 combo
Testing
Tested using EFR32+RS9116.
TC-DGWIFI-2.1 tested