-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32] Added functionality for scan-network, network interfaces and increased the heap size for multiadmin #20106
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
rosahay-silabs:bugfix/wifi-fixes
Jun 30, 2022
Merged
[EFR32] Added functionality for scan-network, network interfaces and increased the heap size for multiadmin #20106
bzbarsky-apple
merged 3 commits into
project-chip:master
from
rosahay-silabs:bugfix/wifi-fixes
Jun 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov and
LuDuda
June 29, 2022 09:18
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
June 29, 2022 09:18
PR #20106: Size comparison from 81c7f2a to bd58fe3 Increases above 0.2%:
Increases (2 builds for efr32)
Decreases (4 builds for esp32, nrfconnect, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #20106: Size comparison from 81c7f2a to d62afef Increases above 0.2%:
Increases (4 builds for efr32, esp32, linux)
Decreases (3 builds for linux, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
mrjerryjohns
approved these changes
Jun 29, 2022
rcasallas-silabs
approved these changes
Jun 30, 2022
bzbarsky-apple
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
scan-network implementation used the wrong api to scan the nearby networks.
added implementation to show network interfaces for wifi devices(RS9116 and WF200)
increased the heap size for multiadmin for wifi
Change overview
Added bgscan api since scan was not working after connecting to an AP
Network-interfaces used to return null when ran with wifi devices and implementation for that
Increased the heap-size which was leading for heap overflow when connecting multiple devices
Testing
Tested on EFR32+RS9116 and EFR32+WF200