-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[K32W0] Update VS Docker image to accomodate SDK 2.6.6 #21063
Conversation
PR #21063: Size comparison from 5665d38 to ae6bca3 Increases (2 builds for esp32, k32w)
Decreases (3 builds for bl602, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
@@ -75,7 +75,7 @@ ENV IDF_PATH=/opt/espressif/esp-idf/ | |||
ENV IDF_TOOLS_PATH=/opt/espressif/tools | |||
ENV IMX_SDK_ROOT=/opt/fsl-imx-xwayland/5.10-hardknott/ | |||
ENV NRF5_TOOLS_ROOT=/opt/NordicSemiconductor/nRF5_tools | |||
ENV NXP_K32W061_SDK_ROOT=/opt/sdk/sdks | |||
ENV NXP_K32W0_SDK_ROOT=/opt/sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image 87 also failed for me with:
...
Step 31/60 : COPY --from=ameba /opt/ameba /opt/ameba
---> 82bb8c2f47ef
Step 32/60 : COPY --from=k32w /opt/sdk/sdks /opt/sdk/sdks
COPY failed: stat opt/sdk/sdks: file does not exist
I think we need to adjust more things here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 44 seems like it also needs adjusting.
Also /opt/sdk seems very generic ... 'sdk of what'? Why is this not /opt/kw32_sdk or something similar?
ae6bca3
to
21e71a7
Compare
Signed-off-by: Doru Gucea <[email protected]>
21e71a7
to
b47cd13
Compare
PR #21063: Size comparison from c3e71f2 to b47cd13 Increases (5 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (42 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
Managed to get another dockerfile conflict. Created #21112 which is the same as this but with fixed version (since I cannot submit on NXPmicro branch). |
Closing in favor of #21112 since that one is more likely to become mergeable faster. They are the same. |
Pull request was closed
* Update K32W in vscode image to matck K32W dockerfile * Update path to be k32w_named. This matches #21063
* Update K32W in vscode image to matck K32W dockerfile * Update path to be k32w_named. This matches #21063
* Update K32W in vscode image to matck K32W dockerfile * Update path to be k32w_named. This matches #21063 Co-authored-by: Andrei Litvin <[email protected]>
) * Update K32W in vscode image to matck K32W dockerfile * Update path to be k32w_named. This matches project-chip#21063
Update VS Docker image to accomodate SDK 2.6.6