-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update K32W in vscode image to matck K32W dockerfile #21114
Merged
woody-apple
merged 2 commits into
sve
from
cherry-pick-c104a72d298a5d8e30d24860daac1f0f4f24f75f
Aug 2, 2022
Merged
Update K32W in vscode image to matck K32W dockerfile #21114
woody-apple
merged 2 commits into
sve
from
cherry-pick-c104a72d298a5d8e30d24860daac1f0f4f24f75f
Aug 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update K32W in vscode image to matck K32W dockerfile * Update path to be k32w_named. This matches #21063
PR #21114: Size comparison from bcdfbfa to 1e679ea Increases (1 build for esp32)
Decreases (2 builds for bl602, nrfconnect)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #21114: Size comparison from 7069064 to c996b7d Decreases (1 build for nrfconnect)
Full report (3 builds for mbed, nrfconnect)
|
woody-apple
deleted the
cherry-pick-c104a72d298a5d8e30d24860daac1f0f4f24f75f
branch
August 2, 2022 05:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#20472 changed k32w dockerfile but not vscode image. Vscode image does not compile and changes in #21095 fix the compile but make k32w not buildable in vscode image.
o GitHub will auto-close the issue).
Change overview
Set correct copy-from path for k32w and update the env variable for compilation.
Testing
N/A (docker image build will validate).