Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect return codes in door lock cluster #19813

Merged
merged 5 commits into from
Jul 7, 2022
Merged

Fix incorrect return codes in door lock cluster #19813

merged 5 commits into from
Jul 7, 2022

Conversation

Morozov-5F
Copy link
Contributor

Problem

Change overview

  • Now door lock cluster returns generic failure instead of NOT_FOUND when working with Week Day/Year Day credentials.
  • Door lock now checks the enum ranges for Set Credential, Set User and Set Holiday Schedule commands.
  • Refactor the door lock cluster a little bit

Testing

  • Run DL_LockUnlock, DL_Schedules and DL_UsersAndCredentials tests
  • Run commands from linked issues to make sure they return appropriate error codes

@boring-cyborg boring-cyborg bot added the app label Jun 21, 2022
@github-actions
Copy link

github-actions bot commented Jun 21, 2022 •
edited
Loading

PR #19813: Size comparison from 39073b3 to c8d50ed

Increases above 0.2%:

platform target config section 39073b3 c8d50ed change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 .rodata 99527 99927 400 0.4
lock-mtd LP_CC2652R7 .rodata 99407 99807 400 0.4
shell LP_CC2652R7 .rodata 110022 110430 408 0.4
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 156312 156716 404 0.3
Increases (16 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6)
platform target config section 39073b3 c8d50ed change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660127 660335 208 0.0
.text 572576 572784 208 0.0
lock-ftd LP_CC2652R7 (read only) 691511 692175 664 0.1
.rodata 99527 99927 400 0.4
.text 591500 591764 264 0.0
lock-mtd LP_CC2652R7 (read only) 640919 641591 672 0.1
.rodata 99407 99807 400 0.4
.text 541020 541292 272 0.1
shell LP_CC2652R7 (read only) 689870 690566 696 0.1
.rodata 110022 110430 408 0.4
.text 579536 579824 288 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 610602 610810 208 0.0
.app_xip_area 467076 467284 208 0.0
esp32 all-clusters-app c3devkit (read only) 1013698 1013806 108 0.0
(read/write) 1483554 1483962 408 0.0
.flash.rodata 214080 214488 408 0.2
.flash.text 1013698 1013806 108 0.0
m5stack (read only) 1068163 1068295 132 0.0
(read/write) 485640 486040 400 0.1
.flash.rodata 244580 244980 400 0.2
.flash.text 1062779 1062911 132 0.0
k32w lock k32w061+release (read/write) 722132 722804 672 0.1
.text 645128 645800 672 0.1
linux all-clusters-app debug (read only) 2936105 2938105 2000 0.1
.rodata 261149 261565 416 0.2
.text 2498514 2500098 1584 0.1
all-clusters-minimal-app debug (read only) 2789817 2790233 416 0.0
.rodata 262685 263101 416 0.2
lock-app debug (read only) 2463905 2465921 2016 0.1
.rodata 225384 225800 416 0.2
.text 2074130 2075730 1600 0.1
shell debug (read only) 2609921 2611921 2000 0.1
.rodata 231378 231794 416 0.2
.text 2218786 2220370 1584 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2439048 2439136 88 0.0
.text 1401692 1401780 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199927 1200603 676 0.1
rodata 156312 156716 404 0.3
text 823096 823376 280 0.0
p6 all-clusters-app default (read/write) 2555392 2556200 808 0.0
.text 1513656 1514464 808 0.1
lock-app default (read/write) 2452688 2453512 824 0.0
.text 1410952 1411776 824 0.1
Decreases (3 builds for cc13x2_26x2)
platform target config section 39073b3 c8d50ed change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 190744 190536 -208 -0.1
lock-ftd LP_CC2652R7 (read/write) 149472 148808 -664 -0.4
shell LP_CC2652R7 (read/write) 156496 155800 -696 -0.4
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 39073b3 c8d50ed change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660127 660335 208 0.0
(read/write) 190744 190536 -208 -0.1
.bss 73764 73764 0 0.0
.data 3356 3356 0 0.0
.rodata 87239 87239 0 0.0
.text 572576 572784 208 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 648947 648947 0 0.0
(read/write) 157324 157324 0 0.0
.bss 73052 73052 0 0.0
.data 3356 3356 0 0.0
.rodata 90771 90771 0 0.0
.text 557856 557856 0 0.0
lock-ftd LP_CC2652R7 (read only) 691511 692175 664 0.1
(read/write) 149472 148808 -664 -0.4
.bss 70764 70764 0 0.0
.data 3280 3280 0 0.0
.rodata 99527 99927 400 0.4
.text 591500 591764 264 0.0
lock-mtd LP_CC2652R7 (read only) 640919 641591 672 0.1
(read/write) 143896 143896 0 0.0
.bss 66500 66500 0 0.0
.data 3280 3280 0 0.0
.rodata 99407 99807 400 0.4
.text 541020 541292 272 0.1
pump-app LP_CC2652R7 (read only) 672799 672799 0 0.0
(read/write) 169072 169072 0 0.0
.bss 70884 70884 0 0.0
.data 3280 3280 0 0.0
.rodata 87903 87903 0 0.0
.text 584412 584412 0 0.0
pump-controller-app LP_CC2652R7 (read only) 658675 658675 0 0.0
(read/write) 183308 183308 0 0.0
.bss 70996 70996 0 0.0
.data 3276 3276 0 0.0
.rodata 83747 83747 0 0.0
.text 574448 574448 0 0.0
shell LP_CC2652R7 (read only) 689870 690566 696 0.1
(read/write) 156496 155800 -696 -0.4
.bss 76060 76060 0 0.0
.data 3360 3360 0 0.0
.rodata 110022 110430 408 0.4
.text 579536 579824 288 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 613246 613246 0 0.0
.app_xip_area 469896 469896 0 0.0
.bss 86304 86304 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 610602 610810 208 0.0
.app_xip_area 467076 467284 208 0.0
.bss 86480 86480 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 617134 617134 0 0.0
.app_xip_area 474672 474672 0 0.0
.bss 85472 85472 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1013698 1013806 108 0.0
(read/write) 1483554 1483962 408 0.0
.dram0.bss 69400 69400 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214080 214488 408 0.2
.flash.text 1013698 1013806 108 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068163 1068295 132 0.0
(read/write) 485640 486040 400 0.1
.dram0.bss 74920 74920 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244580 244980 400 0.2
.flash.text 1062779 1062911 132 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659604 659604 0 0.0
.bss 68764 68764 0 0.0
.data 1992 1992 0 0.0
.text 583048 583048 0 0.0
lock k32w061+release (read/write) 722132 722804 672 0.1
.bss 69204 69204 0 0.0
.data 2000 2000 0 0.0
.text 645128 645800 672 0.1
linux all-clusters-app debug (read only) 2936105 2938105 2000 0.1
(read/write) 177072 177072 0 0.0
.bss 84160 84160 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84664 84664 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261149 261565 416 0.2
.text 2498514 2500098 1584 0.1
all-clusters-minimal-app debug (read only) 2789817 2790233 416 0.0
(read/write) 168976 168976 0 0.0
.bss 83488 83488 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77304 77304 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 262685 263101 416 0.2
.text 2352866 2352866 0 0.0
bridge-app debug+rpc (read only) 2292513 2292513 0 0.0
(read/write) 147840 147840 0 0.0
.bss 71552 71552 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66728 66728 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 195936 195936 0 0.0
.text 1935394 1935394 0 0.0
chip-tool debug (read only) 10147117 10147117 0 0.0
(read/write) 609544 609544 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 577808 577808 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 510389 510389 0 0.0
.text 8230997 8230997 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9886988 9886988 0 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473180 473180 0 0.0
.text 7877380 7877380 0 0.0
lighting-app debug+rpc (read only) 2525209 2525209 0 0.0
(read/write) 151896 151896 0 0.0
.bss 72032 72032 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71896 71896 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 211688 211688 0 0.0
.text 2143730 2143730 0 0.0
lock-app debug (read only) 2463905 2465921 2016 0.1
(read/write) 146544 146544 0 0.0
.bss 70432 70432 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68568 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225384 225800 416 0.2
.text 2074130 2075730 1600 0.1
ota-provider-app debug (read only) 2301857 2301857 0 0.0
(read/write) 140680 140680 0 0.0
.bss 70112 70112 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 201624 201624 0 0.0
.text 1937986 1937986 0 0.0
ota-requestor-app debug (read only) 2417665 2417665 0 0.0
(read/write) 147392 147392 0 0.0
.bss 72416 72416 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66936 66936 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205280 205280 0 0.0
.text 2041906 2041906 0 0.0
shell debug (read only) 2609921 2611921 2000 0.1
(read/write) 196088 196088 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77808 77808 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231378 231794 416 0.2
.text 2218786 2220370 1584 0.1
thermostat-no-ble arm64 (read only) 2575988 2575988 0 0.0
(read/write) 180577 180577 0 0.0
.bss 87889 87889 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164196 164196 0 0.0
.text 2172720 2172720 0 0.0
tv-app debug (read only) 3073777 3073777 0 0.0
(read/write) 277768 277768 0 0.0
.bss 187656 187656 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79016 79016 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247296 247296 0 0.0
.text 2639618 2639618 0 0.0
tv-casting-app debug (read only) 5539297 5539297 0 0.0
(read/write) 184080 184080 0 0.0
.bss 72840 72840 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102576 102576 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341257 341257 0 0.0
.text 4921810 4921810 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439048 2439136 88 0.0
.bss 208212 208212 0 0.0
.data 5864 5864 0 0.0
.text 1401692 1401780 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199927 1200603 676 0.1
bss 141606 141606 0 0.0
rodata 156312 156716 404 0.3
text 823096 823376 280 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1147887 1147887 0 0.0
bss 140858 140858 0 0.0
rodata 132840 132840 0 0.0
text 795316 795316 0 0.0
p6 all-clusters-app default (read/write) 2555392 2556200 808 0.0
.bss 143392 143392 0 0.0
.data 2776 2776 0 0.0
.text 1513656 1514464 808 0.1
all-clusters-minimal-app default (read/write) 2501240 2501240 0 0.0
.bss 142672 142672 0 0.0
.data 2776 2776 0 0.0
.text 1459504 1459504 0 0.0
light-app default (read/write) 2432000 2432000 0 0.0
.bss 134752 134752 0 0.0
.data 2592 2592 0 0.0
.text 1390264 1390264 0 0.0
lock-app default (read/write) 2452688 2453512 824 0.0
.bss 134576 134576 0 0.0
.data 2600 2600 0 0.0
.text 1410952 1411776 824 0.1
telink light-switch-app tlsr9518adk80d (read/write) 790472 790472 0 0.0
bss 69900 69900 0 0.0
noinit 40416 40416 0 0.0
text 560392 560392 0 0.0
lighting-app tlsr9518adk80d (read/write) 810184 810184 0 0.0
bss 70148 70148 0 0.0
noinit 40416 40416 0 0.0
text 576852 576852 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 22, 2022 •
edited
Loading

PR #19813: Size comparison from 5a44f1e to b50805f

Increases above 0.2%:

platform target config section 5a44f1e b50805f change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 .rodata 99351 99751 400 0.4
lock-mtd LP_CC2652R7 .rodata 99239 99639 400 0.4
shell LP_CC2652R7 .rodata 109758 110166 408 0.4
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 156260 156664 404 0.3
Increases (19 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5a44f1e b50805f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660423 660631 208 0.0
.text 573136 573344 208 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649227 649235 8 0.0
.text 558400 558408 8 0.0
lock-ftd LP_CC2652R7 (read only) 691983 692655 672 0.1
.rodata 99351 99751 400 0.4
.text 592148 592420 272 0.0
lock-mtd LP_CC2652R7 (read only) 641399 642071 672 0.1
.rodata 99239 99639 400 0.4
.text 541668 541940 272 0.1
shell LP_CC2652R7 (read only) 690182 690862 680 0.1
.rodata 109758 110166 408 0.4
.text 580112 580384 272 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 589106 589314 208 0.0
.app_xip_area 459828 460036 208 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1111260 1111916 656 0.1
.text 969464 970120 656 0.1
esp32 all-clusters-app c3devkit (read only) 1014136 1014240 104 0.0
(read/write) 1484770 1485178 408 0.0
.flash.rodata 214064 214472 408 0.2
.flash.text 1014136 1014240 104 0.0
m5stack (read only) 1068459 1068595 136 0.0
(read/write) 486856 487256 400 0.1
.flash.rodata 244564 244964 400 0.2
.flash.text 1063075 1063211 136 0.0
k32w lock k32w061+release (read/write) 723436 724108 672 0.1
.text 645432 646104 672 0.1
linux all-clusters-app debug (read only) 2938689 2940705 2016 0.1
.rodata 261597 262013 416 0.2
.text 2500722 2502322 1600 0.1
all-clusters-minimal-app debug (read only) 2792497 2792913 416 0.0
.rodata 263229 263645 416 0.2
lock-app debug (read only) 2466537 2468537 2000 0.1
.rodata 225864 226280 416 0.2
.text 2076354 2077938 1584 0.1
shell debug (read only) 2612193 2614193 2000 0.1
.rodata 231634 232050 416 0.2
.text 2220898 2222482 1584 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2439432 2439520 88 0.0
.text 1402076 1402164 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202291 1202967 676 0.1
rodata 156260 156664 404 0.3
text 824232 824512 280 0.0
p6 all-clusters-app default (read/write) 2555776 2556584 808 0.0
.text 1514040 1514848 808 0.1
lock-app default (read/write) 2453096 2453904 808 0.0
.text 1411360 1412168 808 0.1
telink light-switch-app tlsr9518adk80d text 561060 561062 2 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 5a44f1e b50805f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191184 190976 -208 -0.1
lock-ftd LP_CC2652R7 (read/write) 149736 149064 -672 -0.4
shell LP_CC2652R7 (read/write) 156928 156248 -680 -0.4
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5a44f1e b50805f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660423 660631 208 0.0
(read/write) 191184 190976 -208 -0.1
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 86975 86975 0 0.0
.text 573136 573344 208 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649227 649235 8 0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90507 90507 0 0.0
.text 558400 558408 8 0.0
lock-ftd LP_CC2652R7 (read only) 691983 692655 672 0.1
(read/write) 149736 149064 -672 -0.4
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99351 99751 400 0.4
.text 592148 592420 272 0.0
lock-mtd LP_CC2652R7 (read only) 641399 642071 672 0.1
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99239 99639 400 0.4
.text 541668 541940 272 0.1
pump-app LP_CC2652R7 (read only) 673223 673223 0 0.0
(read/write) 169392 169392 0 0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87663 87663 0 0.0
.text 585076 585076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659115 659115 0 0.0
(read/write) 183612 183612 0 0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83507 83507 0 0.0
.text 575128 575128 0 0.0
shell LP_CC2652R7 (read only) 690182 690862 680 0.1
(read/write) 156928 156248 -680 -0.4
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 109758 110166 408 0.4
.text 580112 580384 272 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591722 591722 0 0.0
.app_xip_area 462620 462620 0 0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589106 589314 208 0.0
.app_xip_area 459828 460036 208 0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594250 594250 0 0.0
.app_xip_area 466020 466020 0 0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1070848 1070848 0 0.0
.bss 132932 132932 0 0.0
.data 2048 2048 0 0.0
.text 935848 935848 0 0.0
BRD4161A+rpc (read/write) 1124900 1124900 0 0.0
.bss 149620 149620 0 0.0
.data 2260 2260 0 0.0
.text 973000 973000 0 0.0
BRD4161A+rs911x (read/write) 935520 935520 0 0.0
.bss 139304 139304 0 0.0
.data 2048 2048 0 0.0
.text 794148 794148 0 0.0
lock-app BRD4161A+wf200 (read/write) 1111260 1111916 656 0.1
.bss 139720 139720 0 0.0
.data 2056 2056 0 0.0
.text 969464 970120 656 0.1
window-app BRD4161A (read/write) 1056116 1056116 0 0.0
.bss 133004 133004 0 0.0
.data 2076 2076 0 0.0
.text 921016 921016 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014136 1014240 104 0.0
(read/write) 1484770 1485178 408 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214064 214472 408 0.2
.flash.text 1014136 1014240 104 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068459 1068595 136 0.0
(read/write) 486856 487256 400 0.1
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244564 244964 400 0.2
.flash.text 1063075 1063211 136 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661524 661524 0 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 583976 583976 0 0.0
lock k32w061+release (read/write) 723436 724108 672 0.1
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645432 646104 672 0.1
linux all-clusters-app debug (read only) 2938689 2940705 2016 0.1
(read/write) 177072 177072 0 0.0
.bss 84192 84192 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84632 84632 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261597 262013 416 0.2
.text 2500722 2502322 1600 0.1
all-clusters-minimal-app debug (read only) 2792497 2792913 416 0.0
(read/write) 168976 168976 0 0.0
.bss 83520 83520 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77272 77272 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 263229 263645 416 0.2
.text 2355074 2355074 0 0.0
bridge-app debug+rpc (read only) 2296449 2296449 0 0.0
(read/write) 147872 147872 0 0.0
.bss 71616 71616 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66696 66696 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 196384 196384 0 0.0
.text 1938930 1938930 0 0.0
chip-tool debug (read only) 10167541 10167541 0 0.0
(read/write) 610536 610536 0 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 578736 578736 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 507957 507957 0 0.0
.text 8251717 8251717 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9904364 9904364 0 0.0
(read/write) 675201 675201 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614128 614128 0 0.0
.dynamic 528 528 0 0.0
.got 13464 13464 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470652 470652 0 0.0
.text 7894996 7894996 0 0.0
lighting-app debug+rpc (read only) 2533233 2533233 0 0.0
(read/write) 151896 151896 0 0.0
.bss 72064 72064 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71864 71864 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 212136 212136 0 0.0
.text 2151378 2151378 0 0.0
lock-app debug (read only) 2466537 2468537 2000 0.1
(read/write) 146608 146608 0 0.0
.bss 70496 70496 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68568 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225864 226280 416 0.2
.text 2076354 2077938 1584 0.1
ota-provider-app debug (read only) 2304361 2304361 0 0.0
(read/write) 140712 140712 0 0.0
.bss 70176 70176 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62808 62808 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 202040 202040 0 0.0
.text 1940146 1940146 0 0.0
ota-requestor-app debug (read only) 2421465 2421465 0 0.0
(read/write) 147584 147584 0 0.0
.bss 72544 72544 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 67000 67000 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205920 205920 0 0.0
.text 2044994 2044994 0 0.0
shell debug (read only) 2612193 2614193 2000 0.1
(read/write) 196056 196056 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77776 77776 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231634 232050 416 0.2
.text 2220898 2222482 1584 0.1
thermostat-no-ble arm64 (read only) 2578428 2578428 0 0.0
(read/write) 180609 180609 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82896 82896 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164540 164540 0 0.0
.text 2174816 2174816 0 0.0
tv-app debug (read only) 3076409 3076409 0 0.0
(read/write) 277800 277800 0 0.0
.bss 187720 187720 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247712 247712 0 0.0
.text 2641906 2641906 0 0.0
tv-casting-app debug (read only) 5541849 5541849 0 0.0
(read/write) 184080 184080 0 0.0
.bss 72872 72872 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102544 102544 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341673 341673 0 0.0
.text 4924018 4924018 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439432 2439520 88 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402076 1402164 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202291 1202967 676 0.1
bss 142862 142862 0 0.0
rodata 156260 156664 404 0.3
text 824232 824512 280 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149639 1149639 0 0.0
bss 142098 142098 0 0.0
rodata 132592 132592 0 0.0
text 796024 796024 0 0.0
p6 all-clusters-app default (read/write) 2555776 2556584 808 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1514040 1514848 808 0.1
all-clusters-minimal-app default (read/write) 2501624 2501624 0 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1459888 1459888 0 0.0
light-app default (read/write) 2432384 2432384 0 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390648 1390648 0 0.0
lock-app default (read/write) 2453096 2453904 808 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411360 1412168 808 0.1
telink light-switch-app tlsr9518adk80d (read/write) 792080 792080 0 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 561060 561062 2 0.0
lighting-app tlsr9518adk80d (read/write) 811792 811792 0 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577522 577522 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

PR #19813: Size comparison from 777d72d to f022314

Increases above 0.2%:

platform target config section 777d72d f022314 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 .rodata 99463 99863 400 0.4
lock-mtd LP_CC2652R7 .rodata 99351 99751 400 0.4
shell LP_CC2652R7 .rodata 109862 110270 408 0.4
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 156368 156768 400 0.3
Increases (15 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section 777d72d f022314 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660447 660655 208 0.0
.text 573128 573336 208 0.0
lock-ftd LP_CC2652R7 (read only) 692095 692767 672 0.1
.rodata 99463 99863 400 0.4
.text 592148 592420 272 0.0
lock-mtd LP_CC2652R7 (read only) 641511 642183 672 0.1
.rodata 99351 99751 400 0.4
.text 541668 541940 272 0.1
shell LP_CC2652R7 (read only) 690286 690958 672 0.1
.rodata 109862 110270 408 0.4
.text 580112 580376 264 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 589122 589330 208 0.0
.app_xip_area 459844 460052 208 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1111348 1112020 672 0.1
.text 969552 970224 672 0.1
esp32 all-clusters-app c3devkit (read only) 1014134 1014242 108 0.0
(read/write) 1484882 1485290 408 0.0
.flash.rodata 214176 214584 408 0.2
.flash.text 1014134 1014242 108 0.0
m5stack (read only) 1068475 1068611 136 0.0
(read/write) 486960 487360 400 0.1
.flash.rodata 244668 245068 400 0.2
.flash.text 1063091 1063227 136 0.0
k32w lock k32w061+release (read/write) 723540 724212 672 0.1
.text 645536 646208 672 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2439536 2439624 88 0.0
.text 1402180 1402268 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202383 1203071 688 0.1
rodata 156368 156768 400 0.3
text 824228 824508 280 0.0
p6 all-clusters-app default (read/write) 2555936 2556760 824 0.0
.text 1514200 1515024 824 0.1
lock-app default (read/write) 2453256 2454080 824 0.0
.text 1411520 1412344 824 0.1
telink light-switch-app tlsr9518adk80d text 561074 561076 2 0.0
lighting-app tlsr9518adk80d text 577532 577534 2 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 777d72d f022314 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191160 190952 -208 -0.1
lock-ftd LP_CC2652R7 (read/write) 149624 148952 -672 -0.4
shell LP_CC2652R7 (read/write) 156824 156152 -672 -0.4
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 777d72d f022314 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660447 660655 208 0.0
(read/write) 191160 190952 -208 -0.1
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 87007 87007 0 0.0
.text 573128 573336 208 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649347 649347 0 0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90619 90619 0 0.0
.text 558408 558408 0 0.0
lock-ftd LP_CC2652R7 (read only) 692095 692767 672 0.1
(read/write) 149624 148952 -672 -0.4
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99463 99863 400 0.4
.text 592148 592420 272 0.0
lock-mtd LP_CC2652R7 (read only) 641511 642183 672 0.1
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99351 99751 400 0.4
.text 541668 541940 272 0.1
pump-app LP_CC2652R7 (read only) 673327 673327 0 0.0
(read/write) 169288 169288 0 0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87775 87775 0 0.0
.text 585068 585068 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659219 659219 0 0.0
(read/write) 183508 183508 0 0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83619 83619 0 0.0
.text 575120 575120 0 0.0
shell LP_CC2652R7 (read only) 690286 690958 672 0.1
(read/write) 156824 156152 -672 -0.4
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 109862 110270 408 0.4
.text 580112 580376 264 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591738 591738 0 0.0
.app_xip_area 462636 462636 0 0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589122 589330 208 0.0
.app_xip_area 459844 460052 208 0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594258 594258 0 0.0
.app_xip_area 466028 466028 0 0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1071000 1071000 0 0.0
.bss 132932 132932 0 0.0
.data 2048 2048 0 0.0
.text 936000 936000 0 0.0
BRD4161A+rpc (read/write) 1125060 1125060 0 0.0
.bss 149620 149620 0 0.0
.data 2260 2260 0 0.0
.text 973160 973160 0 0.0
BRD4161A+rs911x (read/write) 935672 935672 0 0.0
.bss 139304 139304 0 0.0
.data 2048 2048 0 0.0
.text 794300 794300 0 0.0
lock-app BRD4161A+wf200 (read/write) 1111348 1112020 672 0.1
.bss 139720 139720 0 0.0
.data 2056 2056 0 0.0
.text 969552 970224 672 0.1
window-app BRD4161A (read/write) 1056252 1056252 0 0.0
.bss 133004 133004 0 0.0
.data 2076 2076 0 0.0
.text 921152 921152 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014242 108 0.0
(read/write) 1484882 1485290 408 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214176 214584 408 0.2
.flash.text 1014134 1014242 108 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068475 1068611 136 0.0
(read/write) 486960 487360 400 0.1
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244668 245068 400 0.2
.flash.text 1063091 1063227 136 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661556 661556 0 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 584008 584008 0 0.0
lock k32w061+release (read/write) 723540 724212 672 0.1
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645536 646208 672 0.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9902644 9902644 0 0.0
(read/write) 675265 675265 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614184 614184 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471492 471492 0 0.0
.text 7892292 7892292 0 0.0
thermostat-no-ble arm64 (read only) 2579044 2579044 0 0.0
(read/write) 180673 180673 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82952 82952 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164724 164724 0 0.0
.text 2175104 2175104 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439536 2439624 88 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402180 1402268 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202383 1203071 688 0.1
bss 142862 142862 0 0.0
rodata 156368 156768 400 0.3
text 824228 824508 280 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149731 1149731 0 0.0
bss 142098 142098 0 0.0
rodata 132700 132700 0 0.0
text 796020 796020 0 0.0
p6 all-clusters-app default (read/write) 2555936 2556760 824 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1514200 1515024 824 0.1
all-clusters-minimal-app default (read/write) 2501800 2501800 0 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1460064 1460064 0 0.0
light-app default (read/write) 2432536 2432536 0 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390800 1390800 0 0.0
lock-app default (read/write) 2453256 2454080 824 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411520 1412344 824 0.1
telink light-switch-app tlsr9518adk80d (read/write) 792204 792204 0 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 561074 561076 2 0.0
lighting-app tlsr9518adk80d (read/write) 811908 811908 0 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577532 577534 2 0.0

@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

PR #19813: Size comparison from 1381c8e to 5449e61

Increases above 0.2%:

platform target config section 1381c8e 5449e61 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 .rodata 99467 99867 400 0.4
lock-mtd LP_CC2652R7 .rodata 99355 99755 400 0.4
shell LP_CC2652R7 .rodata 109866 110274 408 0.4
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 156388 156792 404 0.3
Increases (19 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1381c8e 5449e61 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660451 660659 208 0.0
.text 573128 573336 208 0.0
lock-ftd LP_CC2652R7 (read only) 692099 692771 672 0.1
.rodata 99467 99867 400 0.4
.text 592148 592420 272 0.0
lock-mtd LP_CC2652R7 (read only) 641515 642187 672 0.1
.rodata 99355 99755 400 0.4
.text 541668 541940 272 0.1
pump-app LP_CC2652R7 (read/write) 169736 169744 8 0.0
pump-controller-app LP_CC2652R7 (read only) 659215 659223 8 0.0
.text 575112 575120 8 0.0
shell LP_CC2652R7 (read only) 690290 690962 672 0.1
.rodata 109866 110274 408 0.4
.text 580112 580376 264 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 590002 590218 216 0.0
.app_xip_area 459940 460156 216 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1112148 1112804 656 0.1
.text 969568 970224 656 0.1
k32w lock k32w061+release (read/write) 724200 724856 656 0.1
.text 645556 646212 656 0.1
linux all-clusters-app debug (read only) 2939145 2941145 2000 0.1
.rodata 261661 262077 416 0.2
.text 2500994 2502578 1584 0.1
all-clusters-minimal-app debug (read only) 2792921 2793337 416 0.0
.rodata 263261 263677 416 0.2
lock-app debug (read only) 2466977 2468993 2016 0.1
.rodata 225928 226344 416 0.2
.text 2076610 2078210 1600 0.1
shell debug (read only) 2612633 2614649 2016 0.1
.rodata 231698 232114 416 0.2
.text 2221154 2222754 1600 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2439536 2439624 88 0.0
.text 1402180 1402268 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1203187 1203863 676 0.1
rodata 156388 156792 404 0.3
text 824232 824512 280 0.0
p6 all-clusters-app default (read/write) 2555952 2556760 808 0.0
.text 1514216 1515024 808 0.1
lock-app default (read/write) 2453280 2454088 808 0.0
.text 1411544 1412352 808 0.1
telink light-switch-app tlsr9518adk80d text 561082 561086 4 0.0
lighting-app tlsr9518adk80d (read/write) 812704 812712 8 0.0
text 577544 577546 2 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section 1381c8e 5449e61 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191620 191412 -208 -0.1
lock-ftd LP_CC2652R7 (read/write) 150084 149412 -672 -0.4
pump-app LP_CC2652R7 (read only) 673343 673335 -8 -0.0
.text 585076 585068 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 183976 183968 -8 -0.0
shell LP_CC2652R7 (read/write) 157284 156612 -672 -0.4
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1381c8e 5449e61 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660451 660659 208 0.0
(read/write) 191620 191412 -208 -0.1
.bss 74964 74964 0 0.0
.data 3356 3356 0 0.0
.rodata 87011 87011 0 0.0
.text 573128 573336 208 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649351 649351 0 0.0
(read/write) 158524 158524 0 0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 90623 90623 0 0.0
.text 558408 558408 0 0.0
lock-ftd LP_CC2652R7 (read only) 692099 692771 672 0.1
(read/write) 150084 149412 -672 -0.4
.bss 71964 71964 0 0.0
.data 3280 3280 0 0.0
.rodata 99467 99867 400 0.4
.text 592148 592420 272 0.0
lock-mtd LP_CC2652R7 (read only) 641515 642187 672 0.1
(read/write) 145096 145096 0 0.0
.bss 67700 67700 0 0.0
.data 3280 3280 0 0.0
.rodata 99355 99755 400 0.4
.text 541668 541940 272 0.1
pump-app LP_CC2652R7 (read only) 673343 673335 -8 -0.0
(read/write) 169736 169744 8 0.0
.bss 72092 72092 0 0.0
.data 3280 3280 0 0.0
.rodata 87783 87783 0 0.0
.text 585076 585068 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 659215 659223 8 0.0
(read/write) 183976 183968 -8 -0.0
.bss 72204 72204 0 0.0
.data 3276 3276 0 0.0
.rodata 83623 83623 0 0.0
.text 575112 575120 8 0.0
shell LP_CC2652R7 (read only) 690290 690962 672 0.1
(read/write) 157284 156612 -672 -0.4
.bss 77268 77268 0 0.0
.data 3360 3360 0 0.0
.rodata 109866 110274 408 0.4
.text 580112 580376 264 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 592626 592626 0 0.0
.app_xip_area 462740 462740 0 0.0
.bss 72848 72848 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590002 590218 216 0.0
.app_xip_area 459940 460156 216 0.0
.bss 73024 73024 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 595142 595142 0 0.0
.app_xip_area 466128 466128 0 0.0
.bss 72032 72032 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1071784 1071784 0 0.0
.bss 133716 133716 0 0.0
.data 2048 2048 0 0.0
.text 936000 936000 0 0.0
BRD4161A+rpc (read/write) 1125852 1125852 0 0.0
.bss 150404 150404 0 0.0
.data 2260 2260 0 0.0
.text 973164 973164 0 0.0
BRD4161A+rs911x (read/write) 936456 936456 0 0.0
.bss 140088 140088 0 0.0
.data 2048 2048 0 0.0
.text 794300 794300 0 0.0
lock-app BRD4161A+wf200 (read/write) 1112148 1112804 656 0.1
.bss 140504 140504 0 0.0
.data 2056 2056 0 0.0
.text 969568 970224 656 0.1
window-app BRD4161A (read/write) 1057036 1057036 0 0.0
.bss 133788 133788 0 0.0
.data 2076 2076 0 0.0
.text 921152 921152 0 0.0
k32w light k32w061+release (read/write) 662204 662204 0 0.0
.bss 70396 70396 0 0.0
.data 1992 1992 0 0.0
.text 584016 584016 0 0.0
lock k32w061+release (read/write) 724200 724856 656 0.1
.bss 70844 70844 0 0.0
.data 2000 2000 0 0.0
.text 645556 646212 656 0.1
linux all-clusters-app debug (read only) 2939145 2941145 2000 0.1
(read/write) 177136 177136 0 0.0
.bss 84192 84192 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84696 84696 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261661 262077 416 0.2
.text 2500994 2502578 1584 0.1
all-clusters-minimal-app debug (read only) 2792921 2793337 416 0.0
(read/write) 169040 169040 0 0.0
.bss 83520 83520 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77336 77336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 263261 263677 416 0.2
.text 2355346 2355346 0 0.0
bridge-app debug+rpc (read only) 2296905 2296905 0 0.0
(read/write) 147936 147936 0 0.0
.bss 71616 71616 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 196448 196448 0 0.0
.text 1939202 1939202 0 0.0
chip-tool debug (read only) 10165629 10165629 0 0.0
(read/write) 610600 610600 0 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 578792 578792 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508629 508629 0 0.0
.text 8249013 8249013 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9902644 9902644 0 0.0
(read/write) 675265 675265 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614184 614184 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471492 471492 0 0.0
.text 7892292 7892292 0 0.0
lighting-app debug+rpc (read only) 2533673 2533673 0 0.0
(read/write) 151928 151928 0 0.0
.bss 72064 72064 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71912 71912 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 212200 212200 0 0.0
.text 2151634 2151634 0 0.0
lock-app debug (read only) 2466977 2468993 2016 0.1
(read/write) 146672 146672 0 0.0
.bss 70496 70496 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68632 68632 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225928 226344 416 0.2
.text 2076610 2078210 1600 0.1
ota-provider-app debug (read only) 2304817 2304817 0 0.0
(read/write) 140776 140776 0 0.0
.bss 70176 70176 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 202104 202104 0 0.0
.text 1940418 1940418 0 0.0
ota-requestor-app debug (read only) 2421921 2421921 0 0.0
(read/write) 147648 147648 0 0.0
.bss 72544 72544 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 67048 67048 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205984 205984 0 0.0
.text 2045266 2045266 0 0.0
shell debug (read only) 2612633 2614649 2016 0.1
(read/write) 196120 196120 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77832 77832 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231698 232114 416 0.2
.text 2221154 2222754 1600 0.1
thermostat-no-ble arm64 (read only) 2579044 2579044 0 0.0
(read/write) 180673 180673 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82952 82952 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164724 164724 0 0.0
.text 2175104 2175104 0 0.0
tv-app debug (read only) 3079665 3079665 0 0.0
(read/write) 277864 277864 0 0.0
.bss 187720 187720 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247808 247808 0 0.0
.text 2644946 2644946 0 0.0
tv-casting-app debug (read only) 5542289 5542289 0 0.0
(read/write) 184144 184144 0 0.0
.bss 72872 72872 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102592 102592 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341737 341737 0 0.0
.text 4924274 4924274 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439536 2439624 88 0.0
.bss 214692 214692 0 0.0
.data 5864 5864 0 0.0
.text 1402180 1402268 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1203187 1203863 676 0.1
bss 143646 143646 0 0.0
rodata 156388 156792 404 0.3
text 824232 824512 280 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1150535 1150535 0 0.0
bss 142882 142882 0 0.0
rodata 132720 132720 0 0.0
text 796024 796024 0 0.0
p6 all-clusters-app default (read/write) 2555952 2556760 808 0.0
.bss 149872 149872 0 0.0
.data 2776 2776 0 0.0
.text 1514216 1515024 808 0.1
all-clusters-minimal-app default (read/write) 2501800 2501800 0 0.0
.bss 149152 149152 0 0.0
.data 2776 2776 0 0.0
.text 1460064 1460064 0 0.0
light-app default (read/write) 2432552 2432552 0 0.0
.bss 141232 141232 0 0.0
.data 2592 2592 0 0.0
.text 1390816 1390816 0 0.0
lock-app default (read/write) 2453280 2454088 808 0.0
.bss 141056 141056 0 0.0
.data 2600 2600 0 0.0
.text 1411544 1412352 808 0.1
telink light-switch-app tlsr9518adk80d (read/write) 793000 793000 0 0.0
bss 71924 71924 0 0.0
noinit 40416 40416 0 0.0
text 561082 561086 4 0.0
lighting-app tlsr9518adk80d (read/write) 812704 812712 8 0.0
bss 72172 72172 0 0.0
noinit 40416 40416 0 0.0
text 577544 577546 2 0.0

@woody-apple
Copy link
Contributor

Fast tracking, given this has had enough time for review.

@github-actions
Copy link

github-actions bot commented Jun 28, 2022 •
edited
Loading

PR #19813: Size comparison from 6e6892a to 9f8a5fa

Increases above 0.2%:

platform target config section 6e6892a8 9f8a5fa change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 141284 141684 400 0.3
Increases (18 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6e6892a8 9f8a5fa change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 664907 665107 200 0.0
.text 576700 576900 200 0.0
lock-ftd LP_CC2652R7 (read only) 667447 667647 200 0.0
.text 590984 591184 200 0.0
lock-mtd LP_CC2652R7 (read only) 616855 617063 208 0.0
.text 540504 540712 208 0.0
shell LP_CC2652R7 (read only) 657362 657570 208 0.0
.text 572396 572604 208 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 582014 582214 200 0.0
.app_xip_area 458832 459032 200 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1121040 1121712 672 0.1
.text 978040 978712 672 0.1
esp32 all-clusters-app c3devkit (read only) 1018292 1018396 104 0.0
(read/write) 1486610 1487018 408 0.0
.flash.rodata 214688 215096 408 0.2
.flash.text 1018292 1018396 104 0.0
m5stack (read only) 1072459 1072595 136 0.0
(read/write) 488696 489096 400 0.1
.flash.rodata 245172 245572 400 0.2
.flash.text 1067075 1067211 136 0.0
k32w lock k32w061+release (read/write) 685944 686120 176 0.0
.text 606392 606568 176 0.0
linux all-clusters-app debug (read only) 2952905 2954921 2016 0.1
.rodata 263005 263421 416 0.2
.text 2512834 2514434 1600 0.1
all-clusters-minimal-app debug (read only) 2807017 2807433 416 0.0
.rodata 264669 265085 416 0.2
lock-app debug (read only) 2508233 2510249 2016 0.1
.rodata 228104 228520 416 0.2
.text 2115106 2116706 1600 0.1
shell debug (read only) 2542665 2544681 2016 0.1
.rodata 227122 227538 416 0.2
.text 2159250 2160850 1600 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2446672 2446760 88 0.0
.text 1409316 1409404 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174595 1175267 672 0.1
rodata 141284 141684 400 0.3
text 809716 809996 280 0.0
p6 all-clusters-app default (read/write) 2562568 2563392 824 0.0
.text 1520832 1521656 824 0.1
lock-app default (read/write) 2464856 2465680 824 0.0
.text 1423120 1423944 824 0.1
telink lighting-app tlsr9518adk80d text 581092 581094 2 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 6e6892a8 9f8a5fa change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 188076 187876 -200 -0.1
lock-ftd LP_CC2652R7 (read/write) 175680 175480 -200 -0.1
shell LP_CC2652R7 (read/write) 191124 190916 -208 -0.1
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6e6892a8 9f8a5fa change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 664907 665107 200 0.0
(read/write) 188076 187876 -200 -0.1
.bss 75876 75876 0 0.0
.data 3356 3356 0 0.0
.rodata 87891 87891 0 0.0
.text 576700 576900 200 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653639 653639 0 0.0
(read/write) 198640 198640 0 0.0
.bss 75172 75172 0 0.0
.data 3356 3356 0 0.0
.rodata 91359 91359 0 0.0
.text 561964 561964 0 0.0
lock-ftd LP_CC2652R7 (read only) 667447 667647 200 0.0
(read/write) 175680 175480 -200 -0.1
.bss 72908 72908 0 0.0
.data 3280 3280 0 0.0
.rodata 75983 75983 0 0.0
.text 590984 591184 200 0.0
lock-mtd LP_CC2652R7 (read only) 616855 617063 208 0.0
(read/write) 146024 146024 0 0.0
.bss 68628 68628 0 0.0
.data 3280 3280 0 0.0
.rodata 75863 75863 0 0.0
.text 540504 540712 208 0.0
pump-app LP_CC2652R7 (read only) 677007 677007 0 0.0
(read/write) 166976 166976 0 0.0
.bss 72996 72996 0 0.0
.data 3280 3280 0 0.0
.rodata 88367 88367 0 0.0
.text 588156 588156 0 0.0
pump-controller-app LP_CC2652R7 (read only) 662919 662919 0 0.0
(read/write) 181184 181184 0 0.0
.bss 73116 73116 0 0.0
.data 3276 3276 0 0.0
.rodata 84215 84215 0 0.0
.text 578224 578224 0 0.0
shell LP_CC2652R7 (read only) 657362 657570 208 0.0
(read/write) 191124 190916 -208 -0.1
.bss 78180 78180 0 0.0
.data 3360 3360 0 0.0
.rodata 84650 84650 0 0.0
.text 572396 572604 208 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 580446 580446 0 0.0
.app_xip_area 457456 457456 0 0.0
.bss 65952 65952 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 582014 582214 200 0.0
.app_xip_area 458832 459032 200 0.0
.bss 66144 66144 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583494 583494 0 0.0
.app_xip_area 461352 461352 0 0.0
.bss 65160 65160 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081380 1081380 0 0.0
.bss 134756 134756 0 0.0
.data 2048 2048 0 0.0
.text 944556 944556 0 0.0
BRD4161A+rpc (read/write) 1135668 1135668 0 0.0
.bss 151444 151444 0 0.0
.data 2260 2260 0 0.0
.text 981944 981944 0 0.0
BRD4161A+rs911x (read/write) 943880 943880 0 0.0
.bss 140472 140472 0 0.0
.data 2048 2048 0 0.0
.text 801340 801340 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121040 1121712 672 0.1
.bss 140920 140920 0 0.0
.data 2060 2060 0 0.0
.text 978040 978712 672 0.1
window-app BRD4161A (read/write) 1066660 1066660 0 0.0
.bss 134836 134836 0 0.0
.data 2076 2076 0 0.0
.text 929724 929724 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018292 1018396 104 0.0
(read/write) 1486610 1487018 408 0.0
.dram0.bss 71864 71864 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 214688 215096 408 0.2
.flash.text 1018292 1018396 104 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072459 1072595 136 0.0
(read/write) 488696 489096 400 0.1
.dram0.bss 77384 77384 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245172 245572 400 0.2
.flash.text 1067075 1067211 136 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659688 659688 0 0.0
.bss 71276 71276 0 0.0
.data 1992 1992 0 0.0
.text 580620 580620 0 0.0
lock k32w061+release (read/write) 685944 686120 176 0.0
.bss 71748 71748 0 0.0
.data 2004 2004 0 0.0
.text 606392 606568 176 0.0
linux all-clusters-app debug (read only) 2952905 2954921 2016 0.1
(read/write) 178136 178136 0 0.0
.bss 84960 84960 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84936 84936 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263005 263421 416 0.2
.text 2512834 2514434 1600 0.1
all-clusters-minimal-app debug (read only) 2807017 2807433 416 0.0
(read/write) 170072 170072 0 0.0
.bss 84288 84288 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77576 77576 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264669 265085 416 0.2
.text 2367458 2367458 0 0.0
bridge-app debug+rpc (read only) 2310481 2310481 0 0.0
(read/write) 148896 148896 0 0.0
.bss 72352 72352 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66952 66952 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197600 197600 0 0.0
.text 1951266 1951266 0 0.0
chip-tool debug (read only) 10169573 10169573 0 0.0
(read/write) 610824 610824 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579056 579056 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509029 509029 0 0.0
.text 8251813 8251813 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9902724 9902724 0 0.0
(read/write) 675665 675665 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614640 614640 0 0.0
.dynamic 528 528 0 0.0
.got 13440 13440 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472148 472148 0 0.0
.text 7890980 7890980 0 0.0
lighting-app debug+rpc (read only) 2547001 2547001 0 0.0
(read/write) 152952 152952 0 0.0
.bss 72896 72896 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213416 213416 0 0.0
.text 2163378 2163378 0 0.0
lock-app debug (read only) 2508233 2510249 2016 0.1
(read/write) 147896 147896 0 0.0
.bss 71264 71264 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228104 228520 416 0.2
.text 2115106 2116706 1600 0.1
ota-provider-app debug (read only) 2317401 2317401 0 0.0
(read/write) 141736 141736 0 0.0
.bss 70944 70944 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63064 63064 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203224 203224 0 0.0
.text 1951522 1951522 0 0.0
ota-requestor-app debug (read only) 2434521 2434521 0 0.0
(read/write) 148608 148608 0 0.0
.bss 73280 73280 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207232 207232 0 0.0
.text 2056258 2056258 0 0.0
shell debug (read only) 2542665 2544681 2016 0.1
(read/write) 164488 164488 0 0.0
.bss 80904 80904 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76672 76672 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227122 227538 416 0.2
.text 2159250 2160850 1600 0.1
thermostat-no-ble arm64 (read only) 2590428 2590428 0 0.0
(read/write) 181761 181761 0 0.0
.bss 88705 88705 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83256 83256 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165004 165004 0 0.0
.text 2185696 2185696 0 0.0
tv-app debug (read only) 3096529 3096529 0 0.0
(read/write) 279240 279240 0 0.0
.bss 188648 188648 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79312 79312 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248768 248768 0 0.0
.text 2660002 2660002 0 0.0
tv-casting-app debug (read only) 5554449 5554449 0 0.0
(read/write) 185136 185136 0 0.0
.bss 73704 73704 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102776 102776 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343049 343049 0 0.0
.text 4934594 4934594 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2446672 2446760 88 0.0
.bss 215716 215716 0 0.0
.data 5872 5872 0 0.0
.text 1409316 1409404 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174595 1175267 672 0.1
bss 144650 144650 0 0.0
rodata 141284 141684 400 0.3
text 809716 809996 280 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155463 1155463 0 0.0
bss 143886 143886 0 0.0
rodata 133216 133216 0 0.0
text 799428 799428 0 0.0
p6 all-clusters-app default (read/write) 2562568 2563392 824 0.0
.bss 150896 150896 0 0.0
.data 2776 2776 0 0.0
.text 1520832 1521656 824 0.1
all-clusters-minimal-app default (read/write) 2508416 2508416 0 0.0
.bss 150176 150176 0 0.0
.data 2776 2776 0 0.0
.text 1466680 1466680 0 0.0
light-app default (read/write) 2438584 2438584 0 0.0
.bss 142232 142232 0 0.0
.data 2592 2592 0 0.0
.text 1396848 1396848 0 0.0
lock-app default (read/write) 2464856 2465680 824 0.0
.bss 142080 142080 0 0.0
.data 2600 2600 0 0.0
.text 1423120 1423944 824 0.1
telink light-switch-app tlsr9518adk80d (read/write) 797712 797712 0 0.0
bss 72344 72344 0 0.0
noinit 40416 40416 0 0.0
text 564548 564548 0 0.0
lighting-app tlsr9518adk80d (read/write) 817780 817780 0 0.0
bss 73164 73164 0 0.0
noinit 40416 40416 0 0.0
text 581092 581094 2 0.0

@github-actions
Copy link

github-actions bot commented Jul 2, 2022 •
edited
Loading

PR #19813: Size comparison from 19d0f52 to 6502e58

Increases above 0.2%:

platform target config section 19d0f52 6502e58 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 141356 141756 400 0.3
Increases (18 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 19d0f52 6502e58 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665363 665571 208 0.0
.text 576948 577156 208 0.0
lock-ftd LP_CC2652R7 (read only) 668023 668215 192 0.0
.text 591352 591544 192 0.0
lock-mtd LP_CC2652R7 (read only) 617439 617623 184 0.0
.text 540880 541064 184 0.0
shell LP_CC2652R7 (read only) 657806 658006 200 0.0
.text 572644 572844 200 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 580478 580686 208 0.0
.app_xip_area 459064 459272 208 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1126984 1127672 688 0.1
.text 980716 981404 688 0.1
esp32 all-clusters-app c3devkit (read only) 1018732 1018840 108 0.0
(read/write) 1484906 1485314 408 0.0
.flash.rodata 214792 215200 408 0.2
.flash.text 1018732 1018840 108 0.0
m5stack (read only) 1072767 1072927 160 0.0
(read/write) 486984 487384 400 0.1
.flash.rodata 245244 245644 400 0.2
.flash.text 1067383 1067543 160 0.0
k32w lock k32w061+release (read/write) 684692 684868 176 0.0
.text 606908 607084 176 0.0
linux all-clusters-app debug (read only) 2955345 2957361 2016 0.1
.rodata 263229 263645 416 0.2
.text 2514930 2516530 1600 0.1
all-clusters-minimal-app debug (read only) 2809489 2809905 416 0.0
.rodata 264925 265341 416 0.2
lock-app debug (read only) 2510577 2512593 2016 0.1
.rodata 228328 228744 416 0.2
.text 2117106 2118706 1600 0.1
shell debug (read only) 2544961 2546977 2016 0.1
.rodata 227346 227762 416 0.2
.text 2161250 2162850 1600 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2447312 2447400 88 0.0
.text 1409956 1410044 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173259 1173947 688 0.1
rodata 141356 141756 400 0.3
text 810108 810388 280 0.0
p6 all-clusters-app default (read/write) 2562928 2563736 808 0.0
.text 1521192 1522000 808 0.1
lock-app default (read/write) 2465576 2466400 824 0.0
.text 1423840 1424664 824 0.1
telink lighting-app tlsr9518adk80d (read/write) 816332 816340 8 0.0
text 581328 581330 2 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 19d0f52 6502e58 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 185860 185652 -208 -0.1
lock-ftd LP_CC2652R7 (read/write) 173344 173152 -192 -0.1
shell LP_CC2652R7 (read/write) 188920 188720 -200 -0.1
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 19d0f52 6502e58 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665363 665571 208 0.0
(read/write) 185860 185652 -208 -0.1
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88099 88099 0 0.0
.text 576948 577156 208 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631363 631363 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77339 77339 0 0.0
.text 553700 553700 0 0.0
lock-ftd LP_CC2652R7 (read only) 668023 668215 192 0.0
(read/write) 173344 173152 -192 -0.1
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591352 591544 192 0.0
lock-mtd LP_CC2652R7 (read only) 617439 617623 184 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540880 541064 184 0.0
pump-app LP_CC2652R7 (read only) 677375 677375 0 0.0
(read/write) 164840 164840 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88439 88439 0 0.0
.text 588452 588452 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663207 663207 0 0.0
(read/write) 179128 179128 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84279 84279 0 0.0
.text 578448 578448 0 0.0
shell LP_CC2652R7 (read only) 657806 658006 200 0.0
(read/write) 188920 188720 -200 -0.1
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572644 572844 200 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578830 578830 0 0.0
.app_xip_area 457608 457608 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580478 580686 208 0.0
.app_xip_area 459064 459272 208 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581894 581894 0 0.0
.app_xip_area 461520 461520 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080268 1080268 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945204 945204 0 0.0
BRD4161A+rpc (read/write) 1134628 1134628 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982672 982672 0 0.0
BRD4161A+rs911x (read/write) 946372 946372 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803536 803536 0 0.0
lock-app BRD4161A+wf200 (read/write) 1126984 1127672 688 0.1
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 980716 981404 688 0.1
window-app BRD4161A (read/write) 1065532 1065532 0 0.0
.bss 133076 133076 0 0.0
.data 2076 2076 0 0.0
.text 930356 930356 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018732 1018840 108 0.0
(read/write) 1484906 1485314 408 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214792 215200 408 0.2
.flash.text 1018732 1018840 108 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072767 1072927 160 0.0
(read/write) 486984 487384 400 0.1
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245244 245644 400 0.2
.flash.text 1067383 1067543 160 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658112 658112 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580804 580804 0 0.0
lock k32w061+release (read/write) 684692 684868 176 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606908 607084 176 0.0
linux all-clusters-app debug (read only) 2955345 2957361 2016 0.1
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263229 263645 416 0.2
.text 2514930 2516530 1600 0.1
all-clusters-minimal-app debug (read only) 2809489 2809905 416 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264925 265341 416 0.2
.text 2369554 2369554 0 0.0
bridge-app debug+rpc (read only) 2312409 2312409 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1952722 1952722 0 0.0
chip-tool debug (read only) 10196725 10196725 0 0.0
(read/write) 611816 611816 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 580032 580032 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 507493 507493 0 0.0
.text 8278197 8278197 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9923396 9923396 0 0.0
(read/write) 676609 676609 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615592 615592 0 0.0
.dynamic 528 528 0 0.0
.got 13448 13448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470260 470260 0 0.0
.text 7911236 7911236 0 0.0
lighting-app debug+rpc (read only) 2548185 2548185 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2164578 2164578 0 0.0
lock-app debug (read only) 2510577 2512593 2016 0.1
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228328 228744 416 0.2
.text 2117106 2118706 1600 0.1
ota-provider-app debug (read only) 2319217 2319217 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1953026 1953026 0 0.0
ota-requestor-app debug (read only) 2436433 2436433 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207424 207424 0 0.0
.text 2057858 2057858 0 0.0
shell debug (read only) 2544961 2546977 2016 0.1
(read/write) 141064 141064 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227346 227762 416 0.2
.text 2161250 2162850 1600 0.1
thermostat-no-ble arm64 (read only) 2591988 2591988 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2186864 2186864 0 0.0
tv-app debug (read only) 3099329 3099329 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249216 249216 0 0.0
.text 2662210 2662210 0 0.0
tv-casting-app debug (read only) 5560121 5560121 0 0.0
(read/write) 161712 161712 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102824 102824 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343433 343433 0 0.0
.text 4939762 4939762 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447312 2447400 88 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409956 1410044 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173259 1173947 688 0.1
bss 142900 142900 0 0.0
rodata 141356 141756 400 0.3
text 810108 810388 280 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154111 1154111 0 0.0
bss 142136 142136 0 0.0
rodata 133288 133288 0 0.0
text 799804 799804 0 0.0
p6 all-clusters-app default (read/write) 2562928 2563736 808 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521192 1522000 808 0.1
all-clusters-minimal-app default (read/write) 2508792 2508792 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467056 1467056 0 0.0
light-app default (read/write) 2439160 2439160 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397424 1397424 0 0.0
lock-app default (read/write) 2465576 2466400 824 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423840 1424664 824 0.1
telink light-switch-app tlsr9518adk80d (read/write) 796504 796504 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565004 565004 0 0.0
lighting-app tlsr9518adk80d (read/write) 816332 816340 8 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581328 581330 2 0.0

@woody-apple woody-apple added the sve label Jul 6, 2022
@Morozov-5F Morozov-5F force-pushed the bugfix/fix-incorrect-return-codes-in-door-lock-cluster branch from 6502e58 to 49fe2f3 Compare July 6, 2022 15:08
@restyled-io restyled-io bot mentioned this pull request Jul 6, 2022
Closed
@Morozov-5F Morozov-5F force-pushed the bugfix/fix-incorrect-return-codes-in-door-lock-cluster branch from c41d9ef to 72d5531 Compare July 6, 2022 15:17
@github-actions
Copy link

github-actions bot commented Jul 6, 2022 •
edited
Loading

PR #19813: Size comparison from 126f6b2 to 9f25124

Increases above 0.2%:

platform target config section 126f6b2 9f25124 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 141376 141776 400 0.3
Increases (15 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section 126f6b2 9f25124 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665443 665651 208 0.0
.text 577060 577268 208 0.0
lock-ftd LP_CC2652R7 (read only) 668343 668551 208 0.0
.text 591656 591864 208 0.0
lock-mtd LP_CC2652R7 (read only) 617759 617959 200 0.0
.text 541184 541384 200 0.0
pump-controller-app LP_CC2652R7 (read/write) 178808 178816 8 0.0
shell LP_CC2652R7 (read only) 657942 658150 208 0.0
.text 572780 572988 208 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 584862 585070 208 0.0
.app_xip_area 458896 459104 208 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1127272 1127960 688 0.1
.text 981004 981692 688 0.1
esp32 all-clusters-app c3devkit (read only) 1019368 1019474 106 0.0
(read/write) 1485050 1485458 408 0.0
.flash.rodata 214936 215344 408 0.2
.flash.text 1019368 1019474 106 0.0
m5stack (read only) 1073243 1073383 140 0.0
(read/write) 487136 487536 400 0.1
.flash.rodata 245396 245796 400 0.2
.flash.text 1067859 1067999 140 0.0
k32w lock k32w061+release (read/write) 684788 684964 176 0.0
.text 607004 607180 176 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2447400 2447488 88 0.0
.text 1410044 1410132 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173807 1174495 688 0.1
rodata 141376 141776 400 0.3
text 810640 810916 276 0.0
p6 all-clusters-app default (read/write) 2563088 2563896 808 0.0
.text 1521352 1522160 808 0.1
lock-app default (read/write) 2465672 2466496 824 0.0
.text 1423936 1424760 824 0.1
telink lighting-app tlsr9518adk80d text 581454 581456 2 0.0
Decreases (5 builds for cc13x2_26x2, linux)
platform target config section 126f6b2 9f25124 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 185780 185572 -208 -0.1
lock-ftd LP_CC2652R7 (read/write) 173024 172816 -208 -0.1
pump-controller-app LP_CC2652R7 (read only) 663527 663519 -8 -0.0
.text 578752 578744 -8 -0.0
shell LP_CC2652R7 (read/write) 188784 188576 -208 -0.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9939972 9939956 -16 -0.0
.rodata 473508 473492 -16 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 126f6b2 9f25124 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665443 665651 208 0.0
(read/write) 185780 185572 -208 -0.1
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577060 577268 208 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631443 631443 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 553812 553812 0 0.0
lock-ftd LP_CC2652R7 (read only) 668343 668551 208 0.0
(read/write) 173024 172816 -208 -0.1
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 591656 591864 208 0.0
lock-mtd LP_CC2652R7 (read only) 617759 617959 200 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541184 541384 200 0.0
pump-app LP_CC2652R7 (read only) 677703 677703 0 0.0
(read/write) 164512 164512 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 588788 588788 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663527 663519 -8 -0.0
(read/write) 178808 178816 8 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 578752 578744 -8 -0.0
shell LP_CC2652R7 (read only) 657942 658150 208 0.0
(read/write) 188784 188576 -208 -0.1
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572780 572988 208 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579134 579134 0 0.0
.app_xip_area 457904 457904 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 584862 585070 208 0.0
.app_xip_area 458896 459104 208 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582206 582206 0 0.0
.app_xip_area 461824 461824 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080652 1080652 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945588 945588 0 0.0
BRD4161A+rpc (read only) 983040 983040 0 0.0
(read/write) 151948 151948 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983032 983032 0 0.0
BRD4161A+rs911x (read/write) 946756 946756 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803920 803920 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127272 1127960 688 0.1
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 981004 981692 688 0.1
window-app BRD4161A (read/write) 1074436 1074436 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937868 937868 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019368 1019474 106 0.0
(read/write) 1485050 1485458 408 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214936 215344 408 0.2
.flash.text 1019368 1019474 106 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073243 1073383 140 0.0
(read/write) 487136 487536 400 0.1
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245396 245796 400 0.2
.flash.text 1067859 1067999 140 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658192 658192 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 580884 0 0.0
lock k32w061+release (read/write) 684788 684964 176 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607004 607180 176 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9939972 9939956 -16 -0.0
(read/write) 675889 675889 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614864 614864 0 0.0
.dynamic 528 528 0 0.0
.got 13448 13448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473508 473492 -16 -0.0
.text 7926164 7926164 0 0.0
thermostat-no-ble arm64 (read only) 2592644 2592644 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187520 2187520 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447400 2447488 88 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410044 1410132 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173807 1174495 688 0.1
bss 142900 142900 0 0.0
rodata 141376 141776 400 0.3
text 810640 810916 276 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154691 0 0.0
bss 142136 142136 0 0.0
rodata 133308 133308 0 0.0
text 800360 800360 0 0.0
p6 all-clusters-app default (read/write) 2563088 2563896 808 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521352 1522160 808 0.1
all-clusters-minimal-app default (read/write) 2508952 2508952 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467216 1467216 0 0.0
light-app default (read/write) 2439240 2439240 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397504 1397504 0 0.0
lock-app default (read/write) 2465672 2466496 824 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423936 1424760 824 0.1
telink light-switch-app tlsr9518adk80d (read/write) 796636 796636 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565130 565130 0 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816464 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581454 581456 2 0.0

@Morozov-5F Morozov-5F force-pushed the bugfix/fix-incorrect-return-codes-in-door-lock-cluster branch from 9f25124 to b6293e8 Compare July 7, 2022 11:05
@restyled-io restyled-io bot mentioned this pull request Jul 7, 2022
Closed
@Morozov-5F Morozov-5F force-pushed the bugfix/fix-incorrect-return-codes-in-door-lock-cluster branch from b6293e8 to 4864fd2 Compare July 7, 2022 11:12
@github-actions
Copy link

github-actions bot commented Jul 7, 2022 •
edited
Loading

PR #19813: Size comparison from 1107d8e to 4864fd2

Increases above 0.2%:

platform target config section 1107d8e 4864fd2 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 141376 141776 400 0.3
Increases (15 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section 1107d8e 4864fd2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665443 665651 208 0.0
.text 577060 577268 208 0.0
lock-ftd LP_CC2652R7 (read only) 668343 668551 208 0.0
.text 591656 591864 208 0.0
lock-mtd LP_CC2652R7 (read only) 617759 617959 200 0.0
.text 541184 541384 200 0.0
shell LP_CC2652R7 (read only) 657942 658150 208 0.0
.text 572780 572988 208 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 584862 585070 208 0.0
.app_xip_area 458896 459104 208 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582198 582206 8 0.0
.app_xip_area 461816 461824 8 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1127288 1127960 672 0.1
.text 981020 981692 672 0.1
esp32 all-clusters-app c3devkit (read only) 1019366 1019472 106 0.0
(read/write) 1485050 1485458 408 0.0
.flash.rodata 214936 215344 408 0.2
.flash.text 1019366 1019472 106 0.0
m5stack (read only) 1073243 1073383 140 0.0
(read/write) 487136 487536 400 0.1
.flash.rodata 245396 245796 400 0.2
.flash.text 1067859 1067999 140 0.0
k32w lock k32w061+release (read/write) 684788 684964 176 0.0
.text 607004 607180 176 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2447400 2447488 88 0.0
.text 1410044 1410132 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173807 1174495 688 0.1
rodata 141376 141776 400 0.3
text 810640 810916 276 0.0
p6 all-clusters-app default (read/write) 2563088 2563896 808 0.0
.text 1521352 1522160 808 0.1
lock-app default (read/write) 2465672 2466496 824 0.0
.text 1423936 1424760 824 0.1
telink light-switch-app tlsr9518adk80d (read/write) 796628 796636 8 0.0
text 565128 565130 2 0.0
Decreases (5 builds for cc13x2_26x2, linux, telink)
platform target config section 1107d8e 4864fd2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 185780 185572 -208 -0.1
lock-ftd LP_CC2652R7 (read/write) 173024 172816 -208 -0.1
shell LP_CC2652R7 (read/write) 188784 188576 -208 -0.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9971956 9971940 -16 -0.0
.rodata 475572 475556 -16 -0.0
telink lighting-app tlsr9518adk80d text 581456 581454 -2 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1107d8e 4864fd2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665443 665651 208 0.0
(read/write) 185780 185572 -208 -0.1
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577060 577268 208 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631443 631443 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 553812 553812 0 0.0
lock-ftd LP_CC2652R7 (read only) 668343 668551 208 0.0
(read/write) 173024 172816 -208 -0.1
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 591656 591864 208 0.0
lock-mtd LP_CC2652R7 (read only) 617759 617959 200 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541184 541384 200 0.0
pump-app LP_CC2652R7 (read only) 677703 677703 0 0.0
(read/write) 164512 164512 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 588788 588788 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663527 663527 0 0.0
(read/write) 178808 178808 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 578752 578752 0 0.0
shell LP_CC2652R7 (read only) 657942 658150 208 0.0
(read/write) 188784 188576 -208 -0.1
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572780 572988 208 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579134 579134 0 0.0
.app_xip_area 457904 457904 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 584862 585070 208 0.0
.app_xip_area 458896 459104 208 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582198 582206 8 0.0
.app_xip_area 461816 461824 8 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080652 1080652 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945588 945588 0 0.0
BRD4161A+rpc (read only) 983040 983040 0 0.0
(read/write) 151948 151948 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983032 983032 0 0.0
BRD4161A+rs911x (read/write) 946756 946756 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803920 803920 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127288 1127960 672 0.1
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 981020 981692 672 0.1
window-app BRD4161A (read/write) 1074436 1074436 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937868 937868 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019366 1019472 106 0.0
(read/write) 1485050 1485458 408 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214936 215344 408 0.2
.flash.text 1019366 1019472 106 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073243 1073383 140 0.0
(read/write) 487136 487536 400 0.1
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245396 245796 400 0.2
.flash.text 1067859 1067999 140 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658192 658192 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580884 580884 0 0.0
lock k32w061+release (read/write) 684788 684964 176 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607004 607180 176 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9971956 9971940 -16 -0.0
(read/write) 680689 680689 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 619624 619624 0 0.0
.dynamic 528 528 0 0.0
.got 13488 13488 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 475572 475556 -16 -0.0
.text 7944804 7944804 0 0.0
thermostat-no-ble arm64 (read only) 2592644 2592644 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2187520 2187520 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447400 2447488 88 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410044 1410132 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173807 1174495 688 0.1
bss 142900 142900 0 0.0
rodata 141376 141776 400 0.3
text 810640 810916 276 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154691 1154691 0 0.0
bss 142136 142136 0 0.0
rodata 133308 133308 0 0.0
text 800360 800360 0 0.0
p6 all-clusters-app default (read/write) 2563088 2563896 808 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521352 1522160 808 0.1
all-clusters-minimal-app default (read/write) 2508952 2508952 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467216 1467216 0 0.0
light-app default (read/write) 2439240 2439240 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397504 1397504 0 0.0
lock-app default (read/write) 2465672 2466496 824 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423936 1424760 824 0.1
telink light-switch-app tlsr9518adk80d (read/write) 796628 796636 8 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565128 565130 2 0.0
lighting-app tlsr9518adk80d (read/write) 816464 816464 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581456 581454 -2 -0.0

@selissia selissia merged commit acbe9cd into project-chip:master Jul 7, 2022
github-actions bot pushed a commit that referenced this pull request Jul 7, 2022
@Morozov-5F @web-flow
Fix incorrect return codes in door lock cluster (#19813)
a6ce628 
* [#19622] Return generic failure instead of not found for schedule operations in the door lock

* [#19563] Check enum ranges for Door Lock commands
- Refactor the cluster, so it is consistent in way of handling commands

* Refactoring of the door lock cluster: move credential error checking into a single function, fix typos

* Fix tests for Door Lock cluster and run them against the lock app

* Update auto-generated files
andy31415 pushed a commit that referenced this pull request Jul 7, 2022
@woody-apple @Morozov-5F
Fix incorrect return codes in door lock cluster (#19813) (#20433)
0f0ddcf 
* [#19622] Return generic failure instead of not found for schedule operations in the door lock

* [#19563] Check enum ranges for Door Lock commands
- Refactor the cluster, so it is consistent in way of handling commands

* Refactoring of the door lock cluster: move credential error checking into a single function, fix typos

* Fix tests for Door Lock cluster and run them against the lock app

* Update auto-generated files

Co-authored-by: Evgeniy Morozov <[email protected]>
@mykrupp mykrupp mentioned this pull request Aug 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app darwin examples fast track review - pending scripts sve
Projects
None yet
Milestone
No milestone
3 participants
@Morozov-5F @woody-apple @selissia