Need to validate userType values in door lock server

[bzbarsky-apple]

Problem

In emberAfDoorLockClusterSetUserTypeCallback and in setUser we have a uint8_t userType that we are casting to EmberAfDoorLockUserType, but nothing makes sure that it's a valid value.

Proposed Solution

Add a check. I'm not sure how best to do that, given the enum is generated. Maybe we could
add something in the generated code that lets us check whether the value is valid for a given enum?

@vivien-apple

[issue-label-bot]

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.62. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[bzbarsky-apple]

This might not be relevant with the door lock cluster rewrites (and the fact that the "Set User Type" command is gone to start with in Matter)....

@mykrupp can you confirm that this is not an issue anymore, please?

[mykrupp]

I don't see emberAfDoorLockClusterSetUserTypeCallback in the connectedhomeip repo anywhere.

Although 4.26 in the doorlock spec indicates that Set User Type should be there. Was it decided at some point to remove the Set User Type command from matter?

[bzbarsky-apple]

Set User Type is Zigbe-only. The Matter equivalent is SetUser. The question is whether SetUser validates the user type it's passed @mykrupp

[mykrupp]

#19813 This PR took care of it for SetUser

[bzbarsky-apple]

Perfect!