Fix unexpected firmware selection by flashing scripts #12345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the flashing scripts will flash a firmware .bin from the current directory, if it exists with the right filename, and otherwise finds the firmware in the same directory as the wrapper. It is confusing that changing directories influences the firmware selection. Downloading a built firmware archive, unpacking it, and running the wrapper should always flash the firmware that was unpacked. Remove the search logic. Similarly, remove the concept of detection of "optional" firmware constituents by file presence. The command line should determine the requisite artifacts; continuing when expected files are missing is not desirable. Finally, fix rebuilds of flashing scripts after the python generator's imports change by adding those to inputs in the build file.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia and
tecimovic
Merged
Closed
This was referenced Sep 8, 2022
This was referenced Sep 20, 2022
Merged
This was referenced Sep 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the flashing scripts will flash a firmware .bin from the
current directory, if it exists with the right filename, and otherwise
finds the firmware in the same directory as the wrapper.
It is confusing that changing directories influences the firmware
selection. Downloading a built firmware archive, unpacking it, and
running the wrapper should always flash the firmware that was unpacked.
Change overview
Remove the search logic. Similarly, remove the concept of detection of
"optional" firmware constituents by file presence. The command line
should determine the requisite artifacts; continuing when expected files
are missing is not desirable.
Finally, fix rebuilds of flashing scripts after the python generator's
imports change by adding those to inputs in the build file.
Testing
Flashed ESP32, EFR32, nRF Connect via wrapper