Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0 Cherrypick] Fix use-after-free in CommissioningWindowOpener. (#22767) #22849

Merged
merged 1 commit into from
Sep 23, 2022
Merged

[1.0 Cherrypick] Fix use-after-free in CommissioningWindowOpener. (#22767) #22849

merged 1 commit into from
Sep 23, 2022

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Sep 23, 2022 •
edited
Loading

Once we call back into our client, it can delete us, so we need to do any logging that uses mSetupPayload before we do that.

Fixes #22765

@bzbarsky-apple @andy31415
Fix use-after-free in CommissioningWindowOpener. (project-chip#22767)
5059157 
Once we call back into our client, it can delete us, so we need to do
any logging that uses `mSetupPayload` before we do that.

Fixes project-chip#22765
@github-actions
Copy link

github-actions bot commented Sep 23, 2022 •
edited
Loading

PR #22849: Size comparison from 062f85c to 5059157

Increases (5 builds for bl702, esp32, nrfconnect, telink)
platform target config section 062f85c 5059157 change % change
bl702 lighting-app bl702+rpc .debug_info 41802406 41802407 1 0.0
.text 1030502 1030504 2 0.0
esp32 all-clusters-app c3devkit (read only) 1222926 1222930 4 0.0
.flash.text 1222926 1222930 4 0.0
m5stack (read/write) 563940 563948 8 0.0
.flash.rodata 314672 314680 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 803140 803144 4 0.0
telink ota-requestor-app tlsr9518adk80d (read/write) 843732 843740 8 0.0
text 598976 598978 2 0.0
Decreases (7 builds for bl602, bl702, psoc6, qpg)
platform target config section 062f85c 5059157 change % change
bl602 lighting-app bl602+rpc (read/write) 1428306 1428298 -8 -0.0
.text 1096290 1096288 -2 -0.0
bl702 lighting-app bl702 .debug_info 37895803 37895802 -1 -0.0
.text 956800 956798 -2 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26816904 26816903 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 2655368 26553685 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22017881 22017880 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22397202 22397200 -2 -0.0
qpg lighting-app qpg6105+debug (read/write) 1146320 1146312 -8 -0.0
.text 593416 593408 -8 -0.0
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 062f85c 5059157 change % change
bl602 lighting-app bl602 (read/write) 1383086 1383086 0 0.0
.bss 89337 89337 0 0.0
.data 9816 9816 0 0.0
.text 1064940 1064940 0 0.0
bl602+rpc (read/write) 1428306 1428298 -8 -0.0
.bss 96769 96769 0 0.0
.data 10200 10200 0 0.0
.text 1096290 1096288 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188027 1188027 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66958 66958 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1506715 1506715 0 0.0
.debug_aranges 133088 133088 0 0.0
.debug_frame 486412 486412 0 0.0
.debug_info 37895803 37895802 -1 -0.0
.debug_line 5252141 5252141 0 0.0
.debug_loc 3362054 3362054 0 0.0
.debug_ranges 359760 359760 0 0.0
.debug_str 3455801 3455801 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116488 116488 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564895 564895 0 0.0
.symtab 171616 171616 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956800 956798 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283971 1283971 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75006 75006 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644294 1644294 0 0.0
.debug_aranges 140592 140592 0 0.0
.debug_frame 511788 511788 0 0.0
.debug_info 41802406 41802407 1 0.0
.debug_line 5626680 5626680 0 0.0
.debug_loc 3554761 3554761 0 0.0
.debug_ranges 382216 382216 0 0.0
.debug_str 3851768 3851768 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129896 129896 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624068 624068 0 0.0
.symtab 189424 189424 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030502 1030504 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676595 676595 0 0.0
(read/write) 174940 174940 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89603 89603 0 0.0
.text 586680 586680 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640835 640835 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78739 78739 0 0.0
.text 561776 561776 0 0.0
lock-ftd LP_CC2652R7 (read only) 678119 678119 0 0.0
(read/write) 170584 170584 0 0.0
.bss 78484 78484 0 0.0
.data 3304 3304 0 0.0
.rodata 77287 77287 0 0.0
.text 600352 600352 0 0.0
lock-mtd LP_CC2652R7 (read only) 661947 661947 0 0.0
(read/write) 182444 182444 0 0.0
.bss 74172 74172 0 0.0
.data 3304 3304 0 0.0
.rodata 103123 103123 0 0.0
.text 558344 558344 0 0.0
pump-app LP_CC2652R7 (read only) 687275 687275 0 0.0
(read/write) 162132 162132 0 0.0
.bss 78420 78420 0 0.0
.data 3296 3296 0 0.0
.rodata 90507 90507 0 0.0
.text 596284 596284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671783 671783 0 0.0
(read/write) 177736 177736 0 0.0
.bss 78532 78532 0 0.0
.data 3292 3292 0 0.0
.rodata 86063 86063 0 0.0
.text 585240 585240 0 0.0
shell LP_CC2652R7 (read only) 667614 667614 0 0.0
(read/write) 186232 186232 0 0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86318 86318 0 0.0
.text 580980 580980 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587330 587330 0 0.0
.app_xip_area 463988 463988 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594394 594394 0 0.0
.app_xip_area 465724 465724 0 0.0
.bss 71096 71096 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543330 543330 0 0.0
.app_xip_area 425012 425012 0 0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1110320 1110320 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 971896 971896 0 0.0
BRD4161A+rpc (read/write) 973444 973444 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 820328 820328 0 0.0
BRD4161A+rs911x (read/write) 1003584 1003584 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 832332 832332 0 0.0
lock-app BRD4161A+wf200 (read/write) 1151308 1151308 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 996968 996968 0 0.0
window-app BRD4161A (read/write) 1102368 1102368 0 0.0
.bss 137780 137780 0 0.0
.data 2096 2096 0 0.0
.text 962472 962472 0 0.0
esp32 all-clusters-app c3devkit (read only) 1222926 1222930 4 0.0
(read/write) 1788054 1788054 0 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257624 257624 0 0.0
.flash.text 1222926 1222930 4 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1232991 1232991 0 0.0
(read/write) 563940 563948 8 0.0
.dram0.bss 82304 82304 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314672 314680 8 0.0
.flash.text 1227607 1227607 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 649884 649884 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574376 574376 0 0.0
lock k32w0+release (read/write) 706856 706856 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630892 630892 0 0.0
linux all-clusters-app debug (read only) 3077577 3077577 0 0.0
(read/write) 157944 157944 0 0.0
.bss 62208 62208 0 0.0
.data 2208 2208 0 0.0
.data.rel.ro 86952 86952 0 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 1200 1200 0 0.0
.rodata 280331 280331 0 0.0
.text 2613666 2613666 0 0.0
all-clusters-minimal-app debug (read only) 2904681 2904681 0 0.0
(read/write) 149376 149376 0 0.0
.bss 61408 61408 0 0.0
.data 2176 2176 0 0.0
.data.rel.ro 79320 79320 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 279851 279851 0 0.0
.text 2444194 2444194 0 0.0
bridge-app debug+rpc (read only) 2406185 2406185 0 0.0
(read/write) 129272 129272 0 0.0
.bss 50880 50880 0 0.0
.data 3728 3728 0 0.0
.data.rel.ro 68616 68616 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 210176 210176 0 0.0
.text 2029266 2029266 0 0.0
chip-tool debug (read only) 10986065 10986065 0 0.0
(read/write) 658344 658344 0 0.0
.bss 26104 26104 0 0.0
.data 2690 2690 0 0.0
.data.rel.ro 623016 623016 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 577237 577237 0 0.0
.text 8886836 8886836 0 0.0
chip-tool-ipv6only arm64 (read only) 10353684 10353684 0 0.0
(read/write) 706273 706273 0 0.0
.bss 33953 33953 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13912 13912 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 503860 503860 0 0.0
.text 8195828 8195828 0 0.0
lighting-app debug+rpc (read only) 2632961 2632961 0 0.0
(read/write) 132184 132184 0 0.0
.bss 50080 50080 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 73720 73720 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 226976 226976 0 0.0
.text 2230818 2230818 0 0.0
lock-app debug (read only) 2616097 2616097 0 0.0
(read/write) 127392 127392 0 0.0
.bss 48576 48576 0 0.0
.data 1840 1840 0 0.0
.data.rel.ro 70760 70760 0 0.0
.dynamic 608 608 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 244232 244232 0 0.0
.text 2200946 2200946 0 0.0
ota-provider-app debug (read only) 2393025 2393025 0 0.0
(read/write) 120824 120824 0 0.0
.bss 48096 48096 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 64584 64584 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 215880 215880 0 0.0
.text 2009410 2009410 0 0.0
ota-requestor-app debug (read only) 2558417 2558417 0 0.0
(read/write) 129136 129136 0 0.0
.bss 50624 50624 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 69928 69928 0 0.0
.dynamic 608 608 0 0.0
.got 4656 4656 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 222928 222928 0 0.0
.text 2158658 2158658 0 0.0
shell debug (read only) 2621201 2621201 0 0.0
(read/write) 142856 142856 0 0.0
.bss 57768 57768 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77984 77984 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 239698 239698 0 0.0
.text 2222002 2222002 0 0.0
thermostat-no-ble arm64 (read only) 2387436 2387436 0 0.0
(read/write) 143649 143649 0 0.0
.bss 55361 55361 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 77208 77208 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 143652 143652 0 0.0
.text 2001472 2001472 0 0.0
tv-app debug (read only) 3221649 3221649 0 0.0
(read/write) 261144 261144 0 0.0
.bss 170200 170200 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 80192 80192 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 267096 267096 0 0.0
.text 2763202 2763202 0 0.0
tv-casting-app debug (read only) 5526393 5526393 0 0.0
(read/write) 161496 161496 0 0.0
.bss 52120 52120 0 0.0
.data 1872 1872 0 0.0
.data.rel.ro 101032 101032 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 350713 350713 0 0.0
.text 4902578 4902578 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455640 2455640 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418284 1418284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182051 1182051 0 0.0
bss 143633 143633 0 0.0
rodata 144196 144196 0 0.0
text 815276 815276 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160703 1160703 0 0.0
bss 142860 142860 0 0.0
rodata 135768 135768 0 0.0
text 803140 803144 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1743900 1743900 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229301 1229301 0 0.0
.debug_aranges 111800 111800 0 0.0
.debug_frame 373268 373268 0 0.0
.debug_info 26816904 26816903 -1 -0.0
.debug_line 3667914 3667914 0 0.0
.debug_loc 3580260 3580260 0 0.0
.debug_ranges 339928 339928 0 0.0
.debug_str 3439445 3439445 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569356 569356 0 0.0
.symtab 421168 421168 0 0.0
.text 1544136 1544136 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1686508 1686508 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221100 1221100 0 0.0
.debug_aranges 111272 111272 0 0.0
.debug_frame 376348 376348 0 0.0
.debug_info 2655368 26553685 -1 -0.0
.debug_line 3688630 3688630 0 0.0
.debug_loc 3567897 3567897 0 0.0
.debug_ranges 338544 338544 0 0.0
.debug_str 3428458 3428458 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533445 533445 0 0.0
.symtab 407600 407600 0 0.0
.text 1487480 1487480 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1605060 1605060 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055156 1055156 0 0.0
.debug_aranges 103480 103480 0 0.0
.debug_frame 346676 346676 0 0.0
.debug_info 22017881 22017880 -1 -0.0
.debug_line 3258550 3258550 0 0.0
.debug_loc 3266004 3266004 0 0.0
.debug_ranges 303872 303872 0 0.0
.debug_str 3233990 3233990 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 469822 469822 0 0.0
.symtab 376048 376048 0 0.0
.text 1414224 1414224 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845864 845864 0 0.0
(read/write) 1642684 1642684 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185008 185008 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1062575 1062575 0 0.0
.debug_aranges 104152 104152 0 0.0
.debug_frame 349500 349500 0 0.0
.debug_info 22397202 22397200 -2 -0.0
.debug_line 3267242 3267242 0 0.0
.debug_loc 3305832 3305832 0 0.0
.debug_ranges 307216 307216 0 0.0
.debug_str 3261445 3261445 0 0.0
.heap 845864 845864 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476025 476025 0 0.0
.symtab 379232 379232 0 0.0
.text 1446816 1446816 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1146320 1146312 -8 -0.0
.bss 110344 110344 0 0.0
.data 1028 1028 0 0.0
.text 593416 593408 -8 -0.0
lock-app qpg6105+debug (read/write) 1116220 1116220 0 0.0
.bss 106176 106176 0 0.0
.data 1032 1032 0 0.0
.text 563320 563320 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 813676 813676 0 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574574 574574 0 0.0
lighting-app tlsr9518adk80d (read/write) 835780 835780 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592794 592794 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843732 843740 8 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598976 598978 2 0.0

@andy31415 andy31415 merged commit 5f29159 into project-chip:v1.0 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

Assignees
No one assigned
Labels
controller fast track
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @mrjerryjohns @yunhanw-google @bzbarsky-apple