[1.0 Cherrypick] [BUG] Fix ReadClient to use the right parameters when computing the l… #22760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iveness timeout (project-chip#22699) * Fix ReadClient to use the right parameters when computing the liveness timeout This fixes the logic in ReadClient to use the local IDLE interval when computing the liveness timeout instead of the IDLE interval of our peer. Testing: Using the REPL and the liveness timer print, confirmed the fixes are indeed applied. Restyled by whitespace Restyled by clang-format Build fixes * Review feedback
yunhanw-google
approved these changes
Sep 20, 2022
tcarmelveilleux
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iveness timeout (#22699)
This fixes the logic in ReadClient to use the local IDLE interval when computing the liveness timeout instead of the IDLE interval of our peer.
Testing:
Using the REPL and the liveness timer print, confirmed the fixes are indeed applied.
Restyled by whitespace
Restyled by clang-format
Build fixes
Issue Being Resolved
Change overview
What's in this PR