-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove read client/handler and write handler when corresponding fabric is removed #21204
Merged
mrjerryjohns
merged 4 commits into
project-chip:master
from
yunhanw-google:feature/IM_Handle_OnFabricChanged
Aug 12, 2022
Merged
remove read client/handler and write handler when corresponding fabric is removed #21204
mrjerryjohns
merged 4 commits into
project-chip:master
from
yunhanw-google:feature/IM_Handle_OnFabricChanged
Aug 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
msandstedt and
mspang
July 26, 2022 00:39
PR #21204: Size comparison from 8f6623c to e87d364 Increases above 0.2%:
Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for cc13x2_26x2, p6)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
yunhanw-google
force-pushed
the
feature/IM_Handle_OnFabricChanged
branch
3 times, most recently
from
August 10, 2022 06:59
a2970e3
to
28b0941
Compare
yunhanw-google
changed the title
remove read/write handlers when corresponding fabric is removed
remove read client/handler and write handler when corresponding fabric is removed
Aug 10, 2022
PR #21204: Size comparison from fe4ea59 to 28b0941 Increases above 0.2%:
Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for cc13x2_26x2, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Show resolved
Hide resolved
yunhanw-google
force-pushed
the
feature/IM_Handle_OnFabricChanged
branch
3 times, most recently
from
August 11, 2022 08:08
8d41362
to
da81c13
Compare
yunhanw-google
force-pushed
the
feature/IM_Handle_OnFabricChanged
branch
from
August 11, 2022 15:28
da81c13
to
f83c21b
Compare
PR #21204: Size comparison from 1845133 to f83c21b Increases (34 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
Decreases (10 builds for cc13x2_26x2, p6)
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
|
yunhanw-google
force-pushed
the
feature/IM_Handle_OnFabricChanged
branch
from
August 11, 2022 17:19
0f7da65
to
8d8cc7f
Compare
PR #21204: Size comparison from 1845133 to 8d8cc7f Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for cc13x2_26x2, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Aug 11, 2022
PR #21204: Size comparison from 1845133 to 0bea2ed Increases above 0.2%:
Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (11 builds for cc13x2_26x2, linux, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
mrjerryjohns
approved these changes
Aug 12, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…c is removed (project-chip#21204) * remove read client/handler and write handler when corresponding fabric is removed * address comments * address comments * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#21084
Change overview
remove read client, read handler and write handler when corresponding fabric is removed
Testing
add unit testing to validate if read client and handler can be deleted when its fabric is removed.
add unit testing to validate if write handler can be deleted when its fabric is removed.