Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabric deletion should synchronously clean-up all relevant IM objects #21084

Closed
mrjerryjohns opened this issue Jul 21, 2022 · 1 comment
Closed

Fabric deletion should synchronously clean-up all relevant IM objects #21084

mrjerryjohns opened this issue Jul 21, 2022 · 1 comment
Assignees
@yunhanw-google
Labels
Interaction Model Work V1.0

Comments

@mrjerryjohns
Copy link
Contributor

Problem

Fabric deletion doesn't actually synchronously clean-up affected IM objects today. They each discover this implicitly when they get around to allocating exchanges off of a session that no longer exists.

Solution

Register for OnFabricChanged in the IM engine, and use that to drive the clean-up.
@mrjerryjohns mrjerryjohns mentioned this issue Jul 21, 2022
Merged
@woody-apple
Copy link
Contributor

Issue Review: Keeping in v1.0 for now.

@yunhanw-google yunhanw-google mentioned this issue Jul 26, 2022
Merged
@yunhanw-google yunhanw-google mentioned this issue Aug 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yunhanw-google yunhanw-google

Labels
Interaction Model Work V1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrjerryjohns @yunhanw-google @woody-apple @bzbarsky-apple