Establish CASE on re-subscription #20080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for re-establishing CASE on re-subscription as a default policy implementation, with the application having the ability to over-ride that if needed.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple and
jelderton
mrjerryjohns
force-pushed
the
im/case-on-resub
branch
from
ee1775a to
d5ef73f
Compare
|
PR #20080: Size comparison from 79e8c9e to a495e41 Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (29 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
reviewed
Jul 26, 2022
mrjerryjohns
force-pushed
the
im/case-on-resub
branch
from
da671aa to
9b6fbb7
Compare
|
PR #20080: Size comparison from a7ad1d8 to 9b6fbb7 Increases (6 builds for cyw30739, mbed, telink)
Decreases (5 builds for cyw30739, telink)
Full report (6 builds for cyw30739, mbed, telink)
|
mrjerryjohns
force-pushed
the
im/case-on-resub
branch
from
9b6fbb7 to
10ab053
Compare
|
PR #20080: Size comparison from a7ad1d8 to 10ab053 Increases above 0.2%:
Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (29 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 27, 2022
|
PR #20080: Size comparison from a7ad1d8 to c707843 Increases above 0.2%:
Increases (10 builds for bl602, cyw30739, linux, mbed, telink)
Decreases (8 builds for bl602, cyw30739, linux, telink)
Full report (10 builds for bl602, cyw30739, linux, mbed, telink)
|
mrjerryjohns
force-pushed
the
im/case-on-resub
branch
from
c707843 to
00f7ac3
Compare
|
PR #20080: Size comparison from 750eedf to 00f7ac3 Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (29 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
yunhanw-google
approved these changes
Jul 27, 2022
msandstedt
approved these changes
Jul 27, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 27, 2022
* Establish CASE on re-subscription This adds support for re-establishing CASE on re-subscription as a default policy implementation, with the application having the ability to over-ride that if needed. * Review feedback WIP * Further fixes * Added a Python test to validate re-subscription * Updated comment style * More minor cleanup * More build fixes * Update to master * Review feedback * Review
woody-apple
added a commit
that referenced
this pull request
Jul 28, 2022
* Establish CASE on re-subscription This adds support for re-establishing CASE on re-subscription as a default policy implementation, with the application having the ability to over-ride that if needed. * Review feedback WIP * Further fixes * Added a Python test to validate re-subscription * Updated comment style * More minor cleanup * More build fixes * Update to master * Review feedback * Review Co-authored-by: Jerry Johns <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Establish CASE on re-subscription This adds support for re-establishing CASE on re-subscription as a default policy implementation, with the application having the ability to over-ride that if needed. * Review feedback WIP * Further fixes * Added a Python test to validate re-subscription * Updated comment style * More minor cleanup * More build fixes * Update to master * Review feedback * Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for re-establishing CASE on re-subscription if a
CHIP_ERROR_TIMEOUTwas encountered as a default policy implementation, with the application having the ability to over-ride that if needed.Fixes #16202
This works out-of-the-box if you call
SendAutoResubscribeRequest.This deletes the function-callback approach in
ReadPrepareParams::mResubscribePolicyand uses instead the re-named,ReadClient::Callback::OnResubscriptionNeededcallback to effect the right re-subscription policy.That callback now pivots from being just an informational callback to one that places the onus on the application (if it over-rides the default impl) to schedule the ensuing re-subscription by calling back into
ReadClient::ScheduleResubscription.Helper methods are provided to help applications pick and select elements of the default re-sub implementation as they desire.
Other notables:
Testing
TestSubscribeAttributeTimeoutinTestRead.cppthat validates re-subscription sans CASE.TestResubscriptionin the Python test suite that validates re-subscription with CASE.