Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super coole Änderungen #1

Closed
wants to merge 3,378 commits into from
Closed

Conversation

dbahrdt
Copy link
Owner

@dbahrdt dbahrdt commented Jan 26, 2024

Problem

What is being fixed? Examples:

Change overview

What's in this PR

Testing

How was this tested? (at least one bullet point required)

  • If unit tests were added, how do they cover this issue?
  • If unit tests existed, how were they fixed/modified to prevent this in future?
  • If new unit tests are not added, why not?
  • If integration tests were added, how do they verify this change?
  • If new integration tests are not added, why not?
  • If manually tested, what platforms controller and device platforms were manually tested, and how?
  • If no testing is required, why not?

yunhanw-google and others added 30 commits November 23, 2022 00:30
* EFR32 : Updated Matter_support pointer to latest commit

* EFR32 : Updated Matter_support pointer to latest commit
…retry mechanism for commissioner discovery (project-chip#23692)

* MatterTvCastingBridge.Framework: Add a way to provide DAC creds

* Android tv-casting lib: Implementing a retry mechanism for commissioner service resolution using NsdManager
* [Shell] Read cluster attributes from matter shell
- Received data but DataResponse is still not printed out
- Support more OnOff commands for matter shell

* [Shell] enable inputting arguments for certain commands

* [Shell] Add levelcontrol commands to shell
- Separate different cluster commands into header files

* [Shell] Add colorcontrol commands to shell

* [Shell] Add thermostat commands to shell

* [Shell] Add handlers for group commands

* [README] Update readme for all-clusters-app

* [Shell] Add identify commands to shell

* [Shell] Increase the number of tokens to fit more arguments
- Add in missing colorcontrol commands
- Fix readme link

* [Shell] Enable reading of attribute list

* [Shell] Fix transition data type and argument errors
- Added logs for levelcontrol commands

* [Shell] Fix compile errors for when CONFIG_ENABLE_CHIP_SHELL is disabled
- Added CONFIG_ENABLE_CHIP_SHELL macro to block off code that requires shell

* [Resyle] fix styling

* Restyled by prettier-markdown

* [Shell] Change ColorTemperature to ColorTemperatureMireds

* [Readme] Update all-clusters-app readme

* [Shell] Change currentx and currenty to current-x and current-y respectively
- To avoid spell check failing as it identifies currenty as mispelling of currently

* [Readme] Restyle

* [Shell] Fix typecasting error

* [Shell] restyle

Co-authored-by: Restyled.io <[email protected]>
…t-chip#23722)

* fix paths for dynamic-bridge-app still pointing to bridge-app

* Restyled by gn

Co-authored-by: Restyled.io <[email protected]>
…falo Lab SoC build (project-chip#23700)

* Update Dockerfile to setup toolchain for Bouffalo Lab SoC build

* Fix restyle

* Update docker image version

* setup toolchain under /opt/bouffalolab_sdk

* fix Restyle
* [Telink] Add thermostat example

* [Telink] Add new target for CI

* [Telink] Fix build after rebase

* [Telink] misspell fix

* [Telink] correct app name
…ip#23654)

Bumps [third_party/mbedtls/repo](https://github.com/ARMmbed/mbedtls) from `4637ed2` to `e530b5b`.
- [Release notes](https://github.com/ARMmbed/mbedtls/releases)
- [Commits](Mbed-TLS/mbedtls@4637ed2...e530b5b)

---
updated-dependencies:
- dependency-name: third_party/mbedtls/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…eader (project-chip#23617)

* Move all non-codegen callbacks into a separate header file. Compilation still needs to be fixed

* Update some ember files so that at least chip-tool compiles. Only generic callbacks are required

* Add back callbacks.h to the attribute storage header

* Minor comment update

* Restyle
* Update Pigweed to 9264e686

* Disable NRF pw tokenized tracing in RPC build

This is failing to build after the pigweed roll, disable for now and we
can fix it after we get this update done.

* Fix broken github CI workflows

Increase EFR32 time, and rm out after efr and  Imx builds,
which was running out of space.
Current factory data generation version has a bug that results
in throwing expection if optional --user value is specified.
Additionally the documentation guide is slightly out of date.

* Fixed a bug by passing dict argument instead of string
* Removed from guide information about spake2p_path and SPAKE2
executable generation.
* [Tizen] Remove platform API for cancel of dnssd

Signed-off-by: hyunuk.tak <[email protected]>

* Restyled by clang-format

Signed-off-by: hyunuk.tak <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
…ure (project-chip#23679)

* Added ability to disable transitioning and onoff feature

* Fixes from restyle

* Fixed missing OnOff attribute change

* Only handle OnOff state for off
…p#23304)

* Update SetupPayload to include if Discriminator is short

The device Discriminator is a 12-bit unsigned integer. For
machine-readable formats, the full 12-bit Discriminator is used. For the
Manual Pairing Code, only the upper 4 bits out of the 12-bit
Discriminator are used.

Also adding @deprecated tags to the pairDevice APIs in
MTRDeviceController

* Restyled by google-java-format

* Adding flags to ignore deprecated warnings around pairDevice
implementations

* Restyled by whitespace

* Restyled by clang-format

* Removing deprecation messages in MTR code

Co-authored-by: Restyled.io <[email protected]>
… yaml python parser (project-chip#23599)

* Adding ability to process config variables, saveAs and constraints

* Rename class

* Refactor save as a little

* Address PR comments

* remove unneeded change in format_converter.py

* Address PR comment

* Update comment in docstring

* Update build file to renamed file

* Address PR comment
…ct-chip#23736)

* src/platform/silabs folder changes

* examples/lighting-app and examples/platform folder modification for silabs/efr32

* Skeleton for the SiWx917 folder

* CI fix for the lighting app due to modified folder structure

* Revert "Skeleton for the SiWx917 folder"

This reverts commit bbe322d.

* Build changes for different applications

* Restyle PR

* Fixing the build failures

* fixing the lock app

* updating the dry run efr32 for the new folder structure]

* Added a variable for the BUILD.gn file

* restyle the last commit

* src/platform/silabs folder changes

* examples/lighting-app and examples/platform folder modification for silabs/efr32

* Skeleton for the SiWx917 folder

* CI fix for the lighting app due to modified folder structure

* Revert "Skeleton for the SiWx917 folder"

This reverts commit bbe322d.

* Build changes for different applications

* Restyle PR

* Fixing the build failures

* fixing the lock app

* updating the dry run efr32 for the new folder structure]

* Added a variable for the BUILD.gn file

* restyle the last commit
* Fix CASE Churn caused by subscriptions on tv

* Address comments

* User feature flag for IM fix since it only applies when both server and controller are enabled

* Address feedback

* fix build
* Add documentation for how codegen works in the sdk

* Fix some typos after self-code-review

* Fix spelling

* One more spell fix

* More spell fixes from pyspelling

* Restyle pass after spell fixes

* Apply one round of code review comments

* Restyle

* One more review pass changes applied

* Fix typo
)

* [ESP32] Use spake2p.py to generate the PAKE verifier

* lets import rather than executing the script
This warning was bugging me, so I fixed it. That being said,
this warning does point to a strange circular dependency between
the transitions and the state machine where the state machine owns
transitions, but transitions can post events to the state machine.
It was abstracted out somewhat by the virtual Context interface,
but that still leaves us with this circular dependency. A better
solution would be to fix this circular dependency.

One solution would be to have the transitions table either return
a state or an event, and have the state machine dispatch to itself
rather than having the transitions hold a reference back to the
state machine. Then the transitions would only need to know about
states and events.
…p#23715)

* [nrfconnect] Added Wi-Fi support to nrfconnect examples.

In this commit:
- Added the first support for Wi-Fi to nrfconnect examples:
lightinig-app, lock-app, light-switch-app, all-clusters-app

- Enabled CI all wi-fi samples checking for Wi-Fi target
nrf7002 - all-clusters-app on each commit, others related
to nrfconnect sources.

- Aligned Common api to NCS 2.1.1.

- Updated documentation for all samples and added Wi-Fi
nRF7002 target and descriptions

* Restyled by clang-format

* Restyled by prettier-markdown

* Some fixes after a review.

Co-authored-by: Restyled.io <[email protected]>
…ges (project-chip#23751)

* example/platform/silabs/efr32 modifications of common files

* App modifications for the logging

* src/platform folder modification with logging and common file modifications

* restyling and some build changes that were missed

* adding logs to places where it was missed for the build to pass
tehampson and others added 29 commits December 15, 2022 11:29
* Initial commit of 3 files from Vivien's branch

These 3 files came from commit ID
e391dad

* Adding a test commit containing a TODO

* Restyle

* Small tweaks plus adding unit test

* Moving towards PEP8 naming convension
* Refactor results to be less focused string matching
* Added very basic unit test file

Test run using:
`python3 scripts/tests/test_yaml_parser.py`

* Refactor constraints

* [Yaml Parser] Add scripts/tests/yamltests/SpecDefinitions.py with some unit tests

* [Yaml Parser] Use SpecDefinitions API instead of ClusterDefinitions

* [Yaml Parser] Uses convert_yaml_octet_string_to_bytes for octet_string

* [Yaml Parser / Constraints] Move the check for None before the type checking

* [Yaml Parser] Add _convert_single_value_to_values and make it sooner such that some code can be made simpler

* Small fixes

* [Yaml Parser] Moves _convert_single_value_to_values up one block such that update_with_definition can be simplified

* Move `__update_placeholder` to TestStep

Also TestStep have internal pointer to config dictionary

* Add docstring, and initial constraint parsing

* Refactor for TestStep into two parts

As well as stype formatting to get it ready for review

* Converge to PEP8 python format standard

* Add and clean up doc strings

* Attempt at creating a python package

* Make Restyle Happy

* Clean up yaml parser unit test to be self contained

* Fix test name

* Fix test name

* Address PR comments

Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Vivien Nicolas <[email protected]>
Brings in Darwin availability annotations backend.
It keeps timing out at 60 mins, and when it passes it's around 55-58 mins.
…roject-chip#24093)

If a ReadHandler failed out of SendReportData (e.g. because the session it's on
had been marked as defunct), we would increment mNumReportsInFlight and never
decrement it.  After this happened CHIP_IM_MAX_REPORTS_IN_FLIGHT times (4 by
default), we would stop being able to send out any more data reports.

This situation is pretty easy to trigger as follows:

1. Use chip-tool to commission a device with node id 17.
2. Start chip-tool interactive mode.
3. Run the following commands in interactive mode:

   onoff subscribe on-off 0 60 17 1 --keepSubscriptions true
   onoff subscribe on-off 0 60 17 1 --keepSubscriptions true
   onoff subscribe on-off 0 60 17 1 --keepSubscriptions true
   onoff subscribe on-off 0 60 17 1 --keepSubscriptions true
   onoff subscribe on-off 0 2 17 1 --keepSubscriptions true

4. quit interactive mode (Ctrl-C or quit() command).
5. Wait 60 seconds for all the subscriptions to error out.

After this the device will no longer respond with data reports to any
read or subscribe requests.
* Auto-generate availability annotations for Darwin.

The changes to the generated code are as follows:

* MTRBaseClusters.h:
  * Some newlines after MTR_NEWLY_AVAILABLE were removed.  This led to a
    smaller diff than adding blank lines in all the places that do not use
    MTR_NEWLY_AVAILABLE.  The newlines will return once we add availability
    annotations to everything we shipped in the initial Matter release, in a
    followup.
  * MTRLevelControlOptions gained the availability annotation it was missing.
  * Enum and bitmap values now have availability annotations.
* MTRClusterConstants.h:
  * ClientMonitoring bits that should not have been generated (because it was
    added after we made the API changes that those bits are backwards compat
    shims for) were removed.
  * The availability annotations on
    MTRClusterDescriptorAttributeDeviceTypeListID got reordered (because the
    new autogenerated things put API_AVAILABLE before the deprecation
    annotation).
* MTRClusters.h:
  * Some newlines after MTR_NEWLY_AVAILABLE were removed, similar to
    MTRBaseClusters.h.
  * Various selectors on clusters that have been newly added (e.g. due to
    renames) now have the right availability annotations.  Most of the diff
    here is from the UnitTesting cluster.
  * Some typos in deprecation messages ("writeAtribute" instead of
    "writeAttribute" were fixed).
* MTRCommandPayloadsObjc.h
  * Commands fields now have availability annotations.
  * MTRClientMonitoringClusterRegisterClientMonitoringParams and
    MTRClientMonitoringClusterStayAwakeRequestParams gained the availability
    annotation they were missing.
* MTRStructsObjc.h
  * Struct fields now have availability annotations.
  * Deprecation annotation added to MTRDescriptorClusterDeviceType.
  * MTRClientMonitoringClusterMonitoringRegistration gained the availability
    annotation it was missing.

* Fixes project-chip#23880
* Fixes project-chip#23680

* Address review comments:

* Put the availability data filename in templates.json.
* Deprecation of a container should deprecate all its contents.

* Add renames as well.

* Update to containers with newer ZAP.
Pulls in workaround for clang-format bug.
…l. (project-chip#24116)

This should add availability annotations to all the code-generated
APIs that did not have them yet.
Starts using the Darwin availability YAML for rename information, instead of hardcoding that.
* Rename "Basic" cluster to "Basic Information".

This matches the spec name.

* Use newer ZAP version.
…hip#24137)

This will let us avoid generating incorrect backwards-compat shims for
things that get added after our big API update but have a name that
includes acronyms.
Adds ability to remove APIs in Darwin codegen.
* Remove the MfgSpecificPing command from Darwin API.

Except for the backwards-compat shims, of course.

The template refactorings are to reduce repetition and to enable
handling for removal and renaming of commands.

* Fix darwin-framework-tool compile.
Pulls in Darwin old name information.
…ject-chip#24163)

project-chip#23409 changed the key under
which we store group fabric info, which breaks reception of group messages if a
node updates from before that change to after that change.

We should just keep using the same key name, especially because sharing a single
storage key for all possible fabric lists (groups and whatever else will want to
store lists of fabric indices) does not necessarily make sense.

Fixes project-chip#24161
This commit changes the SSID of the Wifi AP to PREFIX-<SERIALNUMBER> in
accordance with Eltako wifi ap. This change is likely not compatible
with Matter. However we do not support commissioning using Wifi anyway.
Yet we need wifi to be available to configure the device by other means.
In the future we need to find a way to either enable the ap without
using Matter functions or provide proper commissioning over wifi.
The latter is likely the better way.
This PR changes the default SSID of the wifi AP to
PREFIX-<SERIALNUMBER>.
Enable SOFT_AP in Matter configuration to use this.

Depends on:

* #1
…f it produced a On value. Also we were not checking the featuremap of the right cluster (project-chip#24800)
#3)

Patch from project-chip#24800 of connectedhomeip repository:

Original message:
This PR Fixes
project-chip#24638
MoveToLevelWithOnOff should only set the GlobalSceneControl to true if
it produced a On action when the on off feature map cluster indicate the
lighting feature.

The wrong cluster's featuremap was also verified. The command is from
the level cluster but the GlobalSceneControl attributes is enable with
to the onoff ligthing featuremap.

Tested using the lighting app on efr32 and the chip-tool tests
Test_TC_OO_2_3
`[1675282792.995858][398020:398025] CHIP:TOO: **** Test Complete:
Test_TC_OO_2_3`
…#25393) (#4)

Fix build error in case esp-idf's mDNS implementation is used
@dbahrdt dbahrdt closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.