-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples/tv-casting-app: Allow setting DACCredentials on iOS and add retry mechanism for commissioner discovery #23692
Merged
chrisdecenzo
merged 2 commits into
project-chip:master
from
sharadb-amazon:dac-20221117
Nov 23, 2022
Merged
examples/tv-casting-app: Allow setting DACCredentials on iOS and add retry mechanism for commissioner discovery #23692
chrisdecenzo
merged 2 commits into
project-chip:master
from
sharadb-amazon:dac-20221117
Nov 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
November 21, 2022 03:07
pullapprove
bot
requested review from
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 21, 2022 03:07
chrisdecenzo
approved these changes
Nov 21, 2022
PR #23692: Size comparison from 494f5f5 to c2dcc43 Increases (8 builds for bl602, bl702, cc13x2_26x2, cyw30739, nrfconnect, psoc6, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…er service resolution using NsdManager
sharadb-amazon
force-pushed
the
dac-20221117
branch
from
November 22, 2022 00:47
c2dcc43
to
5bf3aff
Compare
PR #23692: Size comparison from 669cd47 to 5bf3aff Increases (6 builds for cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
hawk248
approved these changes
Nov 22, 2022
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Nov 28, 2022
…retry mechanism for commissioner discovery (project-chip#23692) * MatterTvCastingBridge.Framework: Add a way to provide DAC creds * Android tv-casting lib: Implementing a retry mechanism for commissioner service resolution using NsdManager
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Nov 28, 2022
…retry mechanism for commissioner discovery (project-chip#23692) * MatterTvCastingBridge.Framework: Add a way to provide DAC creds * Android tv-casting lib: Implementing a retry mechanism for commissioner service resolution using NsdManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23691 and #23514
Change summary
Testing
Tested with the iOS and Android tv-casting-apps