[Telink] Allow to erase entire NVS on factory reset by default; Fix IDM-7.1 test. #23676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #23676: Size comparison from e241184 to 7ec2d54 Increases (8 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6)
Decreases (8 builds for cc13x2_26x2, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 18, 2022
arkq
approved these changes
Nov 23, 2022
andy31415
pushed a commit
that referenced
this pull request
Nov 24, 2022
…DM-7.1 test. (Cherry-pick #23434 & #23676) (#23677) * [Zephyr] Allow to erase entire NVS on factory reset (#23434) * [Zephyr] Allow to erase entire NVS on factory reset Currently, the default factory reset implementation simply removes Matter (and OpenThread) settings instead of formatting the non-volatile storage partition. The latter approach may be advisable in the cases where no settings need to survive a factory reset, as it is expected to work properly regardless of the state of the storage partition. Additionally, it will regain the original storage performance if it has been loaded with a lot of stale data. Signed-off-by: Damian Krolik <[email protected]> * [Telink] Allow to erase entire NVS on factory reset by default; Fix IDM-7.1 test. Signed-off-by: Damian Krolik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Commissioning Failed After Opening Multiple Commissioning Windows
Change overview
Allow to erase entire NVS on factory reset by default
Testing
Tested manually with chip-tool.
Steps:
Use chip-tool to perform commissioning with operational dataset in Terminal 1 and ensure our Matter device joins the network.
./chip-tool pairing ble-thread 1 hex:${DATASET} ${PIN_CODE}
In Terminal 1, use the following command to open a new ECM commissioning window:
./chip-tool pairing open-commissioning-window 1 1 400 2000 2001
This command will also generate and print out a manual pairing code (16384853021). The code will be used in the next step.
Open a new terminal 2. Perform commissioning and then open a new ECM Commissioning Window 2:
./chip-tool pairing code 2 16384853021 --commissioner-name beta
./chip-tool pairing open-commissioning-window 2 1 400 2000 2001 --commissioner-name beta
It will generate a new manual pairing code (16260155555).
Open a new terminal 3. Perform commissioning and then open a new ECM Commissioning Window 3:
./chip-tool pairing code 3 16260155555 --commissioner-name gamma
./chip-tool pairing open-commissioning-window 3 1 400 2000 2001 --commissioner-name gamma
A new manual pairing code (15433908150).
Open a new terminal 4. Perform commissioning and then open a new ECM Commissioning Window 4:
./chip-tool pairing code 4 15433908150 --commissioner-name 4
./chip-tool pairing open-commissioning-window 4 1 400 2000 2001 --commissioner-name 4
A new manual pairing code (16322914702).
Open a new terminal 5. Perform commissioning and then open a new ECM Commissioning Window 5:
./chip-tool pairing code 5 16322914702 --commissioner-name 5
./chip-tool pairing open-commissioning-window 5 1 400 2000 2001 --commissioner-name 5
After opening 5 ECM commissioning windows, just press the key 1 to perform factory reset.
Open a new terminal 6. Use chip-tool to perform commissioning with operational dataset in the new terminal.
./chip-tool pairing ble-thread 2 hex:${DATASET} ${PIN_CODE} 2001