[Level Control] Added ability to disable transitioning and OnOff feature #23679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
pullapprove
bot
requested review from
msandstedt,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
…transition-and-onoff
|
PR #23679: Size comparison from 54d8dd0 to a2af57c Increases (32 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl702, cc13x2_26x2, psoc6)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 19, 2022
mgarb1
approved these changes
Nov 23, 2022
ReneJosefsen
added a commit
to Grundfos/connectedhomeip
that referenced
this pull request
Dec 22, 2022
…ure (project-chip#23679) * Added ability to disable transitioning and onoff feature * Fixes from restyle * Fixed missing OnOff attribute change * Only handle OnOff state for off
andy31415
pushed a commit
that referenced
this pull request
Jan 4, 2023
…on time and OnOff feature (#24187) * [Level Control] Added ability to disable transitioning and OnOff feature (#23679) * Added ability to disable transitioning and onoff feature * Fixes from restyle * Fixed missing OnOff attribute change * Only handle OnOff state for off * Move Level Control OnOff feature check into OnOff cluster. (#23820) This simplifies the coupling a bit by doing this runtime feature check in the same place where we are already doing the runtime check for existence of a relevant Level Control cluster. This allows us to remove some code in Level Control that was duplicating existing code in On/Off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address 2 issues in the current implementation:
Currently the spec allows devices to ignore transition times if a device is not capable of transitioning to a new level, but the implementation does not have any ability to ignore these transition times.
The OnOff feature defined in the spec allowes a device to disable the linking to the OnOff cluster. Based on the discussion on slack (https://csamembers.slack.com/archives/CUXQ5QRMK/p1659951745245609) the link between OnOff and CurrentLevel should be possible to disable. The current implementation does not allow to disable this and in general, the OnOff feature has no effect.
Change overview
Testing
Tested on a Pump implementation based on CC2652R7