Move Level Control OnOff feature check into OnOff cluster. #23820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the coupling a bit by doing this runtime feature check in the same place where we are already doing the runtime check for existence of a relevant Level Control cluster. This allows us to remove some code in Level Control that was duplicating existing code in On/Off.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
rgoliver and
robszewczyk
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
|
PR #23820: Size comparison from 2e2ae99 to b14e281 Increases (12 builds for bl702, cc13x2_26x2, cyw30739, psoc6, qpg, telink)
Decreases (26 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ReneJosefsen
approved these changes
Nov 30, 2022
Damian-Nordic
approved these changes
Nov 30, 2022
andy31415
approved these changes
Nov 30, 2022
ReneJosefsen
added a commit
to Grundfos/connectedhomeip
that referenced
this pull request
Dec 22, 2022
…hip#23820) This simplifies the coupling a bit by doing this runtime feature check in the same place where we are already doing the runtime check for existence of a relevant Level Control cluster. This allows us to remove some code in Level Control that was duplicating existing code in On/Off.
andy31415
pushed a commit
that referenced
this pull request
Jan 4, 2023
…on time and OnOff feature (#24187) * [Level Control] Added ability to disable transitioning and OnOff feature (#23679) * Added ability to disable transitioning and onoff feature * Fixes from restyle * Fixed missing OnOff attribute change * Only handle OnOff state for off * Move Level Control OnOff feature check into OnOff cluster. (#23820) This simplifies the coupling a bit by doing this runtime feature check in the same place where we are already doing the runtime check for existence of a relevant Level Control cluster. This allows us to remove some code in Level Control that was duplicating existing code in On/Off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the coupling a bit by doing this runtime feature check in the same place where we are already doing the runtime check for existence of a relevant Level Control cluster. This allows us to remove some code in Level Control that was duplicating existing code in On/Off.