New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to process config variables, saveAs and constraints to yaml python parser #23599

Merged

tehampson merged 9 commits into project-chip:master from tehampson:yaml-parser-add-saveAs-read-attr-rebase

Nov 23, 2022

Contributor

tehampson commented Nov 14, 2022

Adding ability to process config variables in yaml file, saveAs and response constraints to yaml python parser

Tested inside chip-repl with the following commands (with all-cluster app running on separate terminal already commissioned):

import chip.yaml
foo = chip.yaml.Yaml.YamlTestParser("src/app/tests/suites/TestCluster.yaml")
foo.ExecuteTests(devCtrl)

Also tested with src/app/tests/suites/TestConstraints.yaml

github-actions bot added the controller label

pullapprove bot requested review from andy31415, anush-apple, arkq, Byungjoo-Lee, bzbarsky-apple, carol-apple, chrisdecenzo, chshu, chulspro, Damian-Nordic, dhrishi, electrocucaracha, emargolis, erjiaqing, franck-apple, gjc13, harsha-rajendran, hawk248, isiu-apple, jelderton, jepenven-silabs, jmartinez-silabs, jtung-apple, kghost, lazarkov, LuDuda, mlepage-google, mrjerryjohns and msandstedt

November 14, 2022 22:38

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Outdated Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Outdated Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Outdated Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Outdated Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Outdated Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Outdated Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Outdated Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Outdated Show resolved Hide resolved

cecille reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Show resolved Hide resolved

src/controller/python/chip/yaml/format_converter.py Outdated Show resolved Hide resolved

src/controller/python/chip/yaml/parser.py Show resolved Hide resolved

src/controller/python/chip/yaml/parser.py Outdated Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Outdated Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/response_storage.py Outdated Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

Contributor

tcarmelveilleux left a comment

Looks great so far 👍 ! Some minor comments within.

tehampson added 5 commits

November 23, 2022 18:11


          Address PR comments

f4c9cc8


          remove unneeded change in format_converter.py

389e478


          Address PR comment

db9a022


          Update comment in docstring

aacfbc9


          Update build file to renamed file

9277ceb

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Outdated Show resolved Hide resolved

tcarmelveilleux reviewed

View reviewed changes

src/controller/python/chip/yaml/parser.py Outdated Show resolved Hide resolved

tcarmelveilleux approved these changes

View reviewed changes


          Address PR comment

9d09a68

cecille approved these changes

View reviewed changes

andy31415 added the fast track label

tehampson enabled auto-merge (squash)

November 23, 2022 21:30

tehampson merged commit 7f1b4b8 into project-chip:master

tehampson deleted the yaml-parser-add-saveAs-read-attr-rebase branch

November 23, 2022 22:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cecille cecille approved these changes

tcarmelveilleux tcarmelveilleux approved these changes

andy31415 Awaiting requested review from andy31415

anush-apple Awaiting requested review from anush-apple

arkq Awaiting requested review from arkq

Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

bzbarsky-apple Awaiting requested review from bzbarsky-apple

carol-apple Awaiting requested review from carol-apple

chrisdecenzo Awaiting requested review from chrisdecenzo

chshu Awaiting requested review from chshu

chulspro Awaiting requested review from chulspro

Damian-Nordic Awaiting requested review from Damian-Nordic

dhrishi Awaiting requested review from dhrishi

electrocucaracha Awaiting requested review from electrocucaracha

emargolis Awaiting requested review from emargolis

franck-apple Awaiting requested review from franck-apple

gjc13 Awaiting requested review from gjc13

harsha-rajendran Awaiting requested review from harsha-rajendran

hawk248 Awaiting requested review from hawk248

isiu-apple Awaiting requested review from isiu-apple

jelderton Awaiting requested review from jelderton

jepenven-silabs Awaiting requested review from jepenven-silabs

jmartinez-silabs Awaiting requested review from jmartinez-silabs

jtung-apple Awaiting requested review from jtung-apple

lazarkov Awaiting requested review from lazarkov

LuDuda Awaiting requested review from LuDuda

mlepage-google Awaiting requested review from mlepage-google

mrjerryjohns Awaiting requested review from mrjerryjohns

msandstedt Awaiting requested review from msandstedt

rgoliver Awaiting requested review from rgoliver

robszewczyk Awaiting requested review from robszewczyk

saurabhst Awaiting requested review from saurabhst

selissia Awaiting requested review from selissia

tecimovic Awaiting requested review from tecimovic

turon Awaiting requested review from turon

vijs Awaiting requested review from vijs

vivien-apple Awaiting requested review from vivien-apple

wbschiller Awaiting requested review from wbschiller

woody-apple Awaiting requested review from woody-apple

xylophone21 Awaiting requested review from xylophone21

yunhanw-google Awaiting requested review from yunhanw-google

harimau-qirex Awaiting requested review from harimau-qirex

mspang Awaiting requested review from mspang

Labels

controller fast track review - pending