Fix warning on TestStateMachine #23744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning was bugging me, so I fixed it. That being said, this warning does point to a strange circular dependency between the transitions and the state machine where the state machine owns transitions, but transitions can post events to the state machine. It was abstracted out somewhat by the virtual Context interface, but that still leaves us with this circular dependency. A better solution would be to fix this circular dependency. One solution would be to have the transitions table either return a state or an event, and have the state machine dispatch to itself rather than having the transitions hold a reference back to the state machine. Then the transitions would only need to know about states and events.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple and
chrisdecenzo
pullapprove
bot
requested review from
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #23744: Size comparison from 7f1b4b8 to ba365d9 Increases (6 builds for bl602, efr32, esp32, psoc6, qpg, telink)
Decreases (7 builds for bl602, bl702, esp32, psoc6, telink)
Full report (34 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 24, 2022
|
PR #23744: Size comparison from 6026c60 to 8f76443 Increases (8 builds for bl602, bl702, esp32, nrfconnect, qpg, telink)
Decreases (4 builds for cc13x2_26x2, esp32, k32w, psoc6)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning was bugging me, so I fixed it. That being said, this warning does point to a strange circular dependency between the transitions and the state machine where the state machine owns transitions, but transitions can post events to the state machine. It was abstracted out somewhat by the virtual Context interface, but that still leaves us with this circular dependency if you want to use references. A better solution would be to fix this circular dependency.
One solution would be to have the transitions table either return a state or an event, and have the state machine dispatch to itself rather than having the transitions hold a reference back to the state machine. Then the transitions would only need to know about states and events.