-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement command to discover commission-able devices #23729
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yufengwangca:pr/java/commissionable
Nov 23, 2022
Merged
Implement command to discover commission-able devices #23729
yunhanw-google
merged 1 commit into
project-chip:master
from
yufengwangca:pr/java/commissionable
Nov 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
approved these changes
Nov 22, 2022
PR #23729: Size comparison from d4a2ec0 to cf79827 Increases (8 builds for bl602, cc13x2_26x2, efr32, psoc6, telink)
Decreases (10 builds for bl702, cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23729: Size comparison from c90354b to ab698e5 Increases (6 builds for cc13x2_26x2, esp32, nrfconnect, telink)
Decreases (11 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
#23806
Implement command to discover commission-able Matter devices.
Use the following command to discover commission-able Matter devices
java -Djava.library.path=out/linux-x64-java-matter-controller/lib/jni -jar out/linux-x64-java-matter-controller/bin/java-matter-controller discover commissionables
Currently, we are able to call discoverCommissionableNodes() to SDK and getDiscoveredDevice() from SDK successfully, but the found device does not have valid content in it, anyway, this is the problem in SDK and will be looked at seperately.