-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML test parser #24066
Merged
tehampson
merged 23 commits into
project-chip:master
from
tehampson:yaml-parser-collaboration
Dec 15, 2022
Merged
YAML test parser #24066
tehampson
merged 23 commits into
project-chip:master
from
tehampson:yaml-parser-collaboration
Dec 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These 3 files came from commit ID e391dad
* Moving towards PEP8 naming convension * Refactor results to be less focused string matching * Added very basic unit test file Test run using: `python3 scripts/tests/test_yaml_parser.py`
…such that some code can be made simpler
… that update_with_definition can be simplified
Also TestStep have internal pointer to config dictionary
As well as stype formatting to get it ready for review
PR #24066: Size comparison from 12b1744 to 005cc7e Increases (2 builds for bl602, cyw30739)
Decreases (7 builds for bl602, bl702, k32w, nrfconnect, psoc6, telink)
Full report (35 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu and
chulspro
December 14, 2022 14:31
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
December 14, 2022 14:31
PR #24066: Size comparison from 12b1744 to 6151607 Increases above 0.2%:
Increases (9 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, linux, telink)
Decreases (8 builds for bl702, cc13x2_26x2, cyw30739, esp32, linux, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
approved these changes
Dec 14, 2022
tehampson
commented
Dec 14, 2022
PR #24066: Size comparison from 12b1744 to 8573cfd Increases above 0.2%:
Increases (13 builds for bl702, cc13x2_26x2, linux, psoc6)
Decreases (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML test parser that is agnostic as to what is actually running the parsed YAML tests