Update android for build, fix artifacts for tv server app #20422

andy31415 · 2022-07-07T12:39:29Z

Problem

TV server app artifact naming is wrong:

FileNotFoundError: [Errno 2] No such file or directory: '/workspace/out/android-arm-chip-tvserver/outputs/apk/debug/app-debug.apk'

Odd naming in tv server (uses camecase, no other constants do that)
Lots of smurf-naming using 'chip' prefix everywhere.

Change overview

Split out APKs for tv app into content and platform app (this seems to be since around #17378 and #17302)
Rename things to proper casing and remove the CHIP prefix from names because it is too repetitive
Fix up build rules.

Testing

Locally compiled with artifact output directory for arm64, saw it pass.

- fix naming to remove CHIP_ prefix (too repretitive) - fix artifact names for TV app as it is split in content and platform sides. Verfied by running: ``` ./scripts/build/build_examples.py --target android-arm64-chip-tvserver build --copy-artifacts-to out/artifacts ```

github-actions · 2022-07-07T12:56:16Z

PR #20422: Size comparison from ef588e1 to b513293

Increases (2 builds for cc13x2_26x2, telink)

platform	target	config	section	`ef588e1`	`b513293`	change
cc13x2_26x2	shell	LP_CC2652R7	(read only)	657934	657942	8
			.text	572772	572780	8
telink	lighting-app	tlsr9518adk80d	text	581452	581456	4

Decreases (2 builds for cc13x2_26x2, esp32)

platform	target	config	section	`ef588e1`	`b513293`	change	% change
cc13x2_26x2	shell	LP_CC2652R7	(read/write)	188792	188784	-8	-0.0
esp32	all-clusters-app	c3devkit	(read only)	1019368	1019366	-2	-0.0
			.flash.text	1019368	1019366	-2	-0.0

Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	`ef588e1`	`b513293`	change	% change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	665443	665443	0	0.0
			(read/write)	185780	185780	0	0.0
			.bss	74116	74116	0	0.0
			.data	3356	3356	0	0.0
			.rodata	88067	88067	0	0.0
			.text	577060	577060	0	0.0
	all-clusters-minimal-app	LP_CC2652R7	(read only)	631443	631443	0	0.0
			(read/write)	157684	157684	0	0.0
			.bss	73412	73412	0	0.0
			.data	3356	3356	0	0.0
			.rodata	77307	77307	0	0.0
			.text	553812	553812	0	0.0
	lock-ftd	LP_CC2652R7	(read only)	668343	668343	0	0.0
			(read/write)	173024	173024	0	0.0
			.bss	71148	71148	0	0.0
			.data	3280	3280	0	0.0
			.rodata	76207	76207	0	0.0
			.text	591656	591656	0	0.0
	lock-mtd	LP_CC2652R7	(read only)	617751	617751	0	0.0
			(read/write)	144264	144264	0	0.0
			.bss	66868	66868	0	0.0
			.data	3280	3280	0	0.0
			.rodata	76087	76087	0	0.0
			.text	541176	541176	0	0.0
	pump-app	LP_CC2652R7	(read only)	677703	677703	0	0.0
			(read/write)	164512	164512	0	0.0
			.bss	71228	71228	0	0.0
			.data	3280	3280	0	0.0
			.rodata	88431	88431	0	0.0
			.text	588788	588788	0	0.0
	pump-controller-app	LP_CC2652R7	(read only)	663527	663527	0	0.0
			(read/write)	178808	178808	0	0.0
			.bss	71348	71348	0	0.0
			.data	3276	3276	0	0.0
			.rodata	84295	84295	0	0.0
			.text	578752	578752	0	0.0
	shell	LP_CC2652R7	(read only)	657934	657942	8	0.0
			(read/write)	188792	188784	-8	-0.0
			.bss	76420	76420	0	0.0
			.data	3360	3360	0	0.0
			.rodata	84846	84846	0	0.0
			.text	572772	572780	8	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	579134	579134	0	0.0
			.app_xip_area	457904	457904	0	0.0
			.bss	64184	64184	0	0.0
			.data	716	716	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	lock	cyw930739m2evb_01	(read/write)	584862	584862	0	0.0
			.app_xip_area	458896	458896	0	0.0
			.bss	68912	68912	0	0.0
			.data	720	720	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	582206	582206	0	0.0
			.app_xip_area	461824	461824	0	0.0
			.bss	63392	63392	0	0.0
			.data	660	660	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read/write)	1080652	1080652	0	0.0
			.bss	132996	132996	0	0.0
			.data	2048	2048	0	0.0
			.text	945588	945588	0	0.0
		BRD4161A+rpc	(read only)	983040	983040	0	0.0
			(read/write)	151948	151948	0	0.0
			.bss	149676	149676	0	0.0
			.data	2260	2260	0	0.0
			.text	983032	983032	0	0.0
		BRD4161A+rs911x	(read/write)	946756	946756	0	0.0
			.bss	140768	140768	0	0.0
			.data	2048	2048	0	0.0
			.text	803920	803920	0	0.0
	lock-app	BRD4161A+wf200	(read/write)	1127288	1127288	0	0.0
			.bss	144184	144184	0	0.0
			.data	2060	2060	0	0.0
			.text	981020	981020	0	0.0
	window-app	BRD4161A	(read/write)	1074436	1074436	0	0.0
			.bss	134468	134468	0	0.0
			.data	2076	2076	0	0.0
			.text	937868	937868	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	1019368	1019366	-2	-0.0
			(read/write)	1485050	1485050	0	0.0
			.dram0.bss	70080	70080	0	0.0
			.dram0.data	14600	14600	0	0.0
			.flash.rodata	214936	214936	0	0.0
			.flash.text	1019368	1019366	-2	-0.0
			.iram0.text	62902	62902	0	0.0
		m5stack	(read only)	1073243	1073243	0	0.0
			(read/write)	487136	487136	0	0.0
			.dram0.bss	75600	75600	0	0.0
			.dram0.data	34144	34144	0	0.0
			.flash.rodata	245396	245396	0	0.0
			.flash.text	1067859	1067859	0	0.0
			.iram0.text	123267	123267	0	0.0
k32w	light	k32w061+release	(read/write)	658192	658192	0	0.0
			.bss	69516	69516	0	0.0
			.data	1992	1992	0	0.0
			.text	580884	580884	0	0.0
	lock	k32w061+release	(read/write)	684788	684788	0	0.0
			.bss	69980	69980	0	0.0
			.data	2004	2004	0	0.0
			.text	607004	607004	0	0.0
linux	chip-tool-no-interactive-ipv6only	arm64	(read only)	`9971956`	`9971956`	0	0.0
			(read/write)	680689	680689	0	0.0
			.bss	42609	42609	0	0.0
			.data	1152	1152	0	0.0
			.data.rel.ro	619624	619624	0	0.0
			.dynamic	528	528	0	0.0
			.got	13488	13488	0	0.0
			.init	24	24	0	0.0
			.init_array	192	192	0	0.0
			.rodata	475572	475572	0	0.0
			.text	7944804	7944804	0	0.0
	thermostat-no-ble	arm64	(read only)	2592644	2592644	0	0.0
			(read/write)	158289	158289	0	0.0
			.bss	65249	65249	0	0.0
			.data	1704	1704	0	0.0
			.data.rel.ro	83240	83240	0	0.0
			.dynamic	528	528	0	0.0
			.got	5072	5072	0	0.0
			.init	24	24	0	0.0
			.init_array	400	400	0	0.0
			.rodata	165348	165348	0	0.0
			.text	2187520	2187520	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2447400	2447400	0	0.0
			.bss	213940	213940	0	0.0
			.data	5872	5872	0	0.0
			.text	1410044	1410044	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1173807	1173807	0	0.0
			bss	142900	142900	0	0.0
			rodata	141376	141376	0	0.0
			text	810640	810640	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read/write)	1154691	1154691	0	0.0
			bss	142136	142136	0	0.0
			rodata	133308	133308	0	0.0
			text	800360	800360	0	0.0
p6	all-clusters-app	default	(read/write)	2563088	2563088	0	0.0
			.bss	149120	149120	0	0.0
			.data	2776	2776	0	0.0
			.text	`1521352`	`1521352`	0	0.0
	all-clusters-minimal-app	default	(read/write)	2508952	2508952	0	0.0
			.bss	148400	148400	0	0.0
			.data	2776	2776	0	0.0
			.text	1467216	1467216	0	0.0
	light-app	default	(read/write)	2439240	2439240	0	0.0
			.bss	140456	140456	0	0.0
			.data	2592	2592	0	0.0
			.text	1397504	1397504	0	0.0
	lock-app	default	(read/write)	2465672	2465672	0	0.0
			.bss	140304	140304	0	0.0
			.data	2600	2600	0	0.0
			.text	`1423936`	`1423936`	0	0.0
telink	light-switch-app	tlsr9518adk80d	(read/write)	796636	796636	0	0.0
			bss	70576	70576	0	0.0
			noinit	40416	40416	0	0.0
			text	565130	565130	0	0.0
	lighting-app	tlsr9518adk80d	(read/write)	816464	816464	0	0.0
			bss	71420	71420	0	0.0
			noinit	40416	40416	0	0.0
			text	581452	581456	4	0.0

…chip#20422

…JNI library (#20973) * Fixing break in build script for android tv-casting-app from #20422 * Android tv-casting-app: Adding support to send several Media commands

…JNI library (#20973) (#20981) * Fixing break in build script for android tv-casting-app from #20422 * Android tv-casting-app: Adding support to send several Media commands Co-authored-by: Sharad Binjola <[email protected]>

…JNI library (project-chip#20973) * Fixing break in build script for android tv-casting-app from project-chip#20422 * Android tv-casting-app: Adding support to send several Media commands

andy31415 added 3 commits July 7, 2022 08:23

Update naming build build_all to remove some of the chip prefixes

df18f97

Fix glob for full android builds now that chip prefix was removed

b513293

boring-cyborg bot added github scripts workflows labels Jul 7, 2022

pullapprove bot requested review from mlepage-google, msandstedt, mspang, rgoliver, saurabhst, selissia, tcarmelveilleux, tecimovic, vijs, vivien-apple, wbschiller, woody-apple, xylophone21, yufengwangca and yunhanw-google July 7, 2022 12:39

pullapprove bot added the review - pending label Jul 7, 2022

arkq approved these changes Jul 7, 2022

View reviewed changes

woody-apple approved these changes Jul 7, 2022

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Jul 7, 2022

woody-apple merged commit 150b16b into project-chip:master Jul 7, 2022

sharadb-amazon added a commit to sharadb-amazon/connectedhomeip that referenced this pull request Jul 19, 2022

Fixing break in build script for android tv-casting-app from project-…

0171d73

…chip#20422

sharadb-amazon mentioned this pull request Jul 20, 2022

Android tv-casting-app: Add support for additional Media commands to JNI library #20973

Merged

sharadb-amazon added a commit to sharadb-amazon/connectedhomeip that referenced this pull request Jul 20, 2022

Fixing break in build script for android tv-casting-app from project-…

a8ecc2f

…chip#20422

woody-apple mentioned this pull request Jul 20, 2022

Android tv-casting-app: Add support for additional Media commands to JNI library #20981

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update android for build, fix artifacts for tv server app #20422

Update android for build, fix artifacts for tv server app #20422

andy31415 commented Jul 7, 2022

github-actions bot commented Jul 7, 2022 •

edited

Loading

Update android for build, fix artifacts for tv server app #20422

Update android for build, fix artifacts for tv server app #20422

Conversation

andy31415 commented Jul 7, 2022

Problem

Change overview

Testing

github-actions bot commented Jul 7, 2022 • edited Loading

github-actions bot commented Jul 7, 2022 •

edited

Loading