-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ameba] Populate other threadmetrics fields #19752
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
June 20, 2022 03:30
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
June 20, 2022 03:30
PR #19752: Size comparison from c60233d to a4469f1 Increases (3 builds for cyw30739, nrfconnect, telink)
Decreases (1 build for esp32)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 21, 2022
Fast tracking platform changes. |
Prerequisite: #19763 |
andy31415
approved these changes
Jun 22, 2022
/rebase |
pankore
force-pushed
the
threadmetrics_update
branch
from
June 23, 2022 02:02
a4469f1
to
0b5a5b1
Compare
PR #19752: Size comparison from 1e4e037 to 0b5a5b1 Decreases (1 build for nrfconnect)
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
- stackSize - stackFreeCurrent
pankore
force-pushed
the
threadmetrics_update
branch
from
July 7, 2022 03:29
0b5a5b1
to
905c3ce
Compare
PR #19752: Size comparison from ae2913f to 905c3ce Increases (4 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (1 build for esp32)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 7, 2022
- stackSize - stackFreeCurrent
andy31415
added a commit
that referenced
this pull request
Jul 14, 2022
- stackSize - stackFreeCurrent Co-authored-by: pankore <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When reading threadmetrics, stackSize and stackFreeCurrent shows garbage values.
Change overview
Get stackSize and stackFreeCurrent using implemented API
Testing
Read threadmetrics and checked that these 2 fields shows the correct values.