[python] Split Python wheel in two separate wheels #20054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248 and
isiu-apple
woody-apple
approved these changes
Jul 1, 2022
mrjerryjohns
approved these changes
Jul 1, 2022
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Pass library name via command line arguments. This makes build-chip-wheel.py more generic.
agners
force-pushed
the
split-python-wheel-new
branch
from
d6dca6f to
1f02266
Compare
|
PR #20054: Size comparison from 06599bb to 1f02266 Increases (2 builds for cc13x2_26x2, telink)
Decreases (3 builds for bl602, cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #20054: Size comparison from 06599bb to 97231f0 Increases (3 builds for cc13x2_26x2, telink)
Decreases (8 builds for bl602, cc13x2_26x2, esp32, linux)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
* Move package information into manifest file * Specify scripts in manifest as well * Make build-chip-wheel.py independent of build variant Pass library name via command line arguments. This makes build-chip-wheel.py more generic. * Move package requirements to manifest file as well * Split Python into library and repl package * Introduce common GN template chip_python_wheel_action * Add runtime dependency between chip-repl and chip-library * Split chip-library into chip-core and chip-clusters * Apply restyled * Install all wheels for unit tests * Use new chip-repl build target * Fix Cirque failures * Fix wheel names for chip_clusters/chip_repl
andy31415
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Move package information into manifest file * Specify scripts in manifest as well * Make build-chip-wheel.py independent of build variant Pass library name via command line arguments. This makes build-chip-wheel.py more generic. * Move package requirements to manifest file as well * Split Python into library and repl package * Introduce common GN template chip_python_wheel_action * Add runtime dependency between chip-repl and chip-library * Split chip-library into chip-core and chip-clusters * Apply restyled * Install all wheels for unit tests * Use new chip-repl build target * Fix Cirque failures * Fix wheel names for chip_clusters/chip_repl Co-authored-by: Stefan Agner <[email protected]>
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Jul 21, 2022
As of 61dd4d0 ("[python] Split Python wheel in two separate wheels (project-chip#20054)") ninja will forever try to regenerate this file because the filename is specified incorrectly: ninja: Entering directory `out/debug' ninja explain: output linux_x64_gcc/controller/python/chip_repl-0.0-py3-any.whl doesn't exist ninja explain: linux_x64_gcc/controller/python/chip_repl-0.0-py3-any.whl is dirty ninja explain: output linux_x64_gcc/controller/python/chip_clusters-0.0-py3-any.whl doesn't exist ninja explain: linux_x64_gcc/controller/python/chip_clusters-0.0-py3-any.whl is dirty ninja explain: linux_x64_gcc/obj/src/controller/python/chip-repl.stamp is dirty ninja explain: linux_x64_gcc/obj/default.stamp is dirty ninja explain: obj/host_gcc.stamp is dirty ninja explain: obj/default.stamp is dirty [2/3] ACTION //src/controller/python:chip-clusters(//build/toolchain/host:linux_x64_gcc) Fix the filename.
mspang
added a commit
that referenced
this pull request
Jul 21, 2022
As of 61dd4d0 ("[python] Split Python wheel in two separate wheels (#20054)") ninja will forever try to regenerate this file because the filename is specified incorrectly: ninja: Entering directory `out/debug' ninja explain: output linux_x64_gcc/controller/python/chip_repl-0.0-py3-any.whl doesn't exist ninja explain: linux_x64_gcc/controller/python/chip_repl-0.0-py3-any.whl is dirty ninja explain: output linux_x64_gcc/controller/python/chip_clusters-0.0-py3-any.whl doesn't exist ninja explain: linux_x64_gcc/controller/python/chip_clusters-0.0-py3-any.whl is dirty ninja explain: linux_x64_gcc/obj/src/controller/python/chip-repl.stamp is dirty ninja explain: linux_x64_gcc/obj/default.stamp is dirty ninja explain: obj/host_gcc.stamp is dirty ninja explain: obj/default.stamp is dirty [2/3] ACTION //src/controller/python:chip-clusters(//build/toolchain/host:linux_x64_gcc) Fix the filename.
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
As of 61dd4d0 ("[python] Split Python wheel in two separate wheels (project-chip#20054)") ninja will forever try to regenerate this file because the filename is specified incorrectly: ninja: Entering directory `out/debug' ninja explain: output linux_x64_gcc/controller/python/chip_repl-0.0-py3-any.whl doesn't exist ninja explain: linux_x64_gcc/controller/python/chip_repl-0.0-py3-any.whl is dirty ninja explain: output linux_x64_gcc/controller/python/chip_clusters-0.0-py3-any.whl doesn't exist ninja explain: linux_x64_gcc/controller/python/chip_clusters-0.0-py3-any.whl is dirty ninja explain: linux_x64_gcc/obj/src/controller/python/chip-repl.stamp is dirty ninja explain: linux_x64_gcc/obj/default.stamp is dirty ninja explain: obj/host_gcc.stamp is dirty ninja explain: obj/default.stamp is dirty [2/3] ACTION //src/controller/python:chip-clusters(//build/toolchain/host:linux_x64_gcc) Fix the filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the Python Controller library is one large wheel, with the native library, the clusters, the interaction model and the REPL packed in a single wheel.
This PR is a first step in break out the library into smaller wheels.
Change overview
The first few commits aim to make the current wheel build logic more generic by moving most wheel specific information into
BUILD.gn. Then this splits it in two wheels: The main wheel namedchip-library(still fairly monolithic, with cluster library and interaction model in a single wheel), and achip-repl, with the REPL and its dependency.This lowers the dependency of
chip-libraryalready. I also plan to split the fairly independent cluster library into a separate wheel in a follow up PR.Testing
Build and runtime tested locally (using
scripts/build_python.sh -m minimal -i separateandchip-repl).