Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify component_discarded_events_total and component_errors_total for all sources/sinks #13995

Closed
86 of 90 tasks
jszwedko opened this issue Aug 16, 2022 · 0 comments
Closed
86 of 90 tasks

Verify component_discarded_events_total and component_errors_total for all sources/sinks #13995

jszwedko opened this issue Aug 16, 2022 · 0 comments

Comments

@jszwedko
Copy link
Member

jszwedko commented Aug 16, 2022 •
edited by StephenWakely
Loading

For each component:

  • Verify internal event processing metrics are tested via assert_X_compliance test helpers
  • Update component_discarded_events_total to match the new instrumentation spec by adding reason to the emitted logs, and intentional to emitted logs and metrics
  • Verify that the component correctly emits the correct error events per the component spec

Copy this checklist when creating the issue for each component.

After the audit:

  • Document component_errors_total for all components

Sources:

@spencergilbert

@neuronull

@StephenWakely

@prognant

Sinks:

@spencergilbert

@StephenWakely

@neuronull

@prognant
This was referenced Aug 18, 2022
Merged
Merged
@prognant prognant mentioned this issue Aug 23, 2022
Closed
3 tasks
@JeanMertz JeanMertz mentioned this issue Aug 23, 2022
Closed
17 tasks
@prognant prognant mentioned this issue Aug 23, 2022
Merged
This was referenced Aug 23, 2022
Merged
Merged
@prognant prognant mentioned this issue Aug 24, 2022
Closed
@neuronull neuronull mentioned this issue Aug 24, 2022
Merged
neuronull added a commit that referenced this issue Aug 26, 2022
@neuronull
enhancement(host_metrics source): Add unit test with assert_source_co…
a00a3f9 
…mpliance test helper (#14103)

<!--
**Your PR title must conform to the conventional commit spec!**

  <type>(<scope>)!: <description>

  * `type` = chore, enhancement, feat, fix, docs
  * `!` = OPTIONAL: signals a breaking change
  * `scope` = Optional when `type` is "chore" or "docs", available scopes https://github.com/vectordotdev/vector/blob/master/.github/semantic.yml#L20
  * `description` = short description of the change

Examples:

  * enhancement(file source): Add `sort` option to sort discovered files
  * feat(new source): Initial `statsd` source
  * fix(file source): Fix a bug discovering new files
  * chore(external docs): Clarify `batch_size` option
-->

part of #14055

part of #13995.
This was referenced Aug 26, 2022
Merged
Merged
Merged
@prognant prognant mentioned this issue Aug 29, 2022
Merged
This was referenced Aug 29, 2022
Merged
Open
Merged
Merged
Merged
@prognant prognant mentioned this issue Aug 31, 2022
Merged
This was referenced Sep 6, 2022
Merged
Merged
Merged
@jszwedko jszwedko changed the title Verify component_discarded_events_total for all sources/sinks Verify component_discarded_events_total and component_errors_total for all sources/sinks Sep 8, 2022
This was referenced Sep 9, 2022
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 13, 2022
Merged
Merged
Merged
This was referenced Sep 22, 2022
Merged
Merged
Merged
@StephenWakely StephenWakely mentioned this issue Sep 26, 2022
Merged
@neuronull neuronull mentioned this issue Nov 9, 2022
Merged
@jszwedko jszwedko closed this as completed Dec 6, 2022
@jszwedko jszwedko mentioned this issue Dec 24, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jszwedko