Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify http sink #14301

Closed
3 tasks done
Tracked by #13995
neuronull opened this issue Sep 6, 2022 · 4 comments · Fixed by #14361
Closed
3 tasks done
Tracked by #13995

Verify http sink #14301

neuronull opened this issue Sep 6, 2022 · 4 comments · Fixed by #14361
Assignees
@neuronull
Labels
domain: observability Anything related to monitoring/observing Vector sink: http Anything `http` sink related

Comments

@neuronull
Copy link
Contributor

neuronull commented Sep 6, 2022 •
edited
Loading

  • Verify internal event processing metrics are tested via assert_X_compliance test helpers
  • Update component_discarded_events_total to match the new instrumentation spec by adding reason to the emitted logs, and intentional to emitted logs and metrics
  • Verify that the component correctly emits the correct error events per the component spec
@neuronull neuronull added sink: http Anything `http` sink related domain: observability Anything related to monitoring/observing Vector labels Sep 6, 2022
@neuronull neuronull self-assigned this Sep 6, 2022
@neuronull neuronull mentioned this issue Sep 6, 2022
Closed
90 tasks
@neuronull
Copy link
Contributor Author

neuronull commented Sep 6, 2022 •
edited
Loading

Need assert_sink_error test helper from #14173.

Happy path is covered though.

@neuronull
Copy link
Contributor Author

Regarding the Error and EventsDropped event emission , I think everything is covered already... the http sink infrastructure is a little hard to follow.

@neuronull
Copy link
Contributor Author

Regarding the Error and EventsDropped event emission , I think everything is covered already... the http sink infrastructure is a little hard to follow.

But as far as I can tell, the encoder is the main source of errors in this path, and that is already handling errors.

@neuronull
Copy link
Contributor Author

Need write_all from #14173.

@neuronull neuronull mentioned this issue Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neuronull neuronull

Labels
domain: observability Anything related to monitoring/observing Vector sink: http Anything `http` sink related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancement(http sink): Adhere to instrumentation spec vectordotdev/vector
1 participant
@neuronull