Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify datadog_traces sink #14298

Closed
3 tasks done
Tracked by #13995
neuronull opened this issue Sep 6, 2022 · 2 comments · Fixed by #14300
Closed
3 tasks done
Tracked by #13995

Verify datadog_traces sink #14298

neuronull opened this issue Sep 6, 2022 · 2 comments · Fixed by #14300
Assignees
Labels
sink: datadog_traces Anything `datadog_traces` sink related

Comments

@neuronull
Copy link
Contributor

neuronull commented Sep 6, 2022

  • Verify internal event processing metrics are tested via assert_X_compliance test helpers
  • Update component_discarded_events_total to match the new instrumentation spec by adding reason to the emitted logs, and intentional to emitted logs and metrics
  • Verify that the component correctly emits the correct error events per the component spec
@neuronull
Copy link
Contributor Author

neuronull commented Sep 6, 2022

  • sink.rs
  • config.rs
  • service.rs
  • request_builder.rs
  • stats.rs

Errors are propagated up to the run_inner , and it contains both error and dropped events.
The rest of the places are already covered by changes for these two:

#14173

#14262

@neuronull
Copy link
Contributor Author

Completed the compliance test helpers on branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sink: datadog_traces Anything `datadog_traces` sink related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant