-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify datadog_metrics
sink
#14262
Comments
Added compliance test helper |
For adhering to spec, evaluated (may reach into other files):
|
Should we fire internal events for errors while building the DatadogMetricsRequestBuilder, or basically anything in the sink build path that is utilizing |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
I'm contemplating if we should be emitting internal events at these sink infrastructure common code locations, , or if we should be catching the errors downstream of that and emitting there. vector/lib/vector-core/src/stream/driver.rs Lines 122 to 125 in 7b877d6
(2): vector/lib/vector-core/src/stream/driver.rs Lines 170 to 173 in 7b877d6
|
Looks like that is handled in |
assert_X_compliance
test helperscomponent_discarded_events_total
to match the new instrumentation spec by addingreason
to the emitted logs, andintentional
to emitted logs and metricsThe text was updated successfully, but these errors were encountered: