Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify datadog_metrics sink #14262

Closed
2 of 3 tasks
Tracked by #13995
neuronull opened this issue Sep 2, 2022 · 6 comments · Fixed by #14299
Closed
2 of 3 tasks
Tracked by #13995

Verify datadog_metrics sink #14262

neuronull opened this issue Sep 2, 2022 · 6 comments · Fixed by #14299
Assignees
Labels
sink: datadog_metrics Anything `datadog_metrics` sink related

Comments

@neuronull
Copy link
Contributor

neuronull commented Sep 2, 2022

  • Verify internal event processing metrics are tested via assert_X_compliance test helpers
  • Update component_discarded_events_total to match the new instrumentation spec by adding reason to the emitted logs, and intentional to emitted logs and metrics
  • Verify that the component correctly emits the correct error events per the component spec
@neuronull
Copy link
Contributor Author

neuronull commented Sep 2, 2022

Added compliance test helper

@neuronull
Copy link
Contributor Author

neuronull commented Sep 2, 2022

For adhering to spec, evaluated (may reach into other files):

  • sink.rs
  • config.rs
  • encoder.rs
  • service.rs
  • normalizer.rs
  • request_builder.rs

@neuronull
Copy link
Contributor Author

Should we fire internal events for errors while building the DatadogMetricsRequestBuilder, or basically anything in the sink build path that is utilizing ? to cascade up errors.

1 similar comment
@neuronull

This comment was marked as duplicate.

@neuronull
Copy link
Contributor Author

neuronull commented Sep 2, 2022

I'm contemplating if we should be emitting internal events at these sink infrastructure common code locations, , or if we should be catching the errors downstream of that and emitting there.
(1) :

Poll::Ready(Err(err)) => {
error!(message = "Service return error from `poll_ready()`.", ?err);
return Err(())
}

(2):
Err(error) => {
error!(message = "Service call failed.", ?error, request_id);
finalizers.update_status(EventStatus::Rejected);
}

@neuronull
Copy link
Contributor Author

Should we fire internal events for errors while building the DatadogMetricsRequestBuilder, or basically anything in the sink build path that is utilizing ? to cascade up errors.

Looks like that is handled in run_inner(), using the RequestBuilderError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sink: datadog_metrics Anything `datadog_metrics` sink related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant