Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(journald source): emit events to comply with Error instrumentation spec #14147

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

neuronull
Copy link
Contributor

Closes: #14134
Part of: #13995.

  • converted error! log messages to Error events
  • emit StreamClosed event

@neuronull neuronull added the source: journald Anything `journald` source related label Aug 29, 2022
@neuronull neuronull self-assigned this Aug 29, 2022
@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 2dcf9cb
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/630e30c591d70b000a9afdb1
😎 Deploy Preview https://deploy-preview-14147--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Aug 29, 2022
src/internal_events/journald.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

Soak Test Results

Baseline: 9b73df3
Comparison: 269ce16
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_blackhole 983.52KiB 1.59 100.00% 60.28MiB 4.56MiB 95.03KiB 0 0.0756868 61.24MiB 3.21MiB 67.09KiB 0 0.0524763 False False
splunk_hec_route_s3 205.26KiB 1.06 99.85% 19.0MiB 2.25MiB 46.8KiB 0 0.11828 19.2MiB 2.14MiB 44.83KiB 0 0.111678 False False
datadog_agent_remap_blackhole_acks 569.85KiB 0.92 100.00% 60.73MiB 5.21MiB 108.49KiB 0 0.0858 61.29MiB 3.6MiB 75.37KiB 0 0.0587237 False False
http_pipelines_blackhole_acks 6.44KiB 0.52 98.47% 1.21MiB 104.08KiB 2.12KiB 0 0.0837549 1.22MiB 78.32KiB 1.6KiB 0 0.0627002 False False
syslog_splunk_hec_logs 68.07KiB 0.41 99.90% 16.3MiB 812.39KiB 16.53KiB 0 0.0486546 16.37MiB 610.65KiB 12.47KiB 0 0.0364237 False False
syslog_regex_logs2metric_ddmetrics 12.84KiB 0.1 57.76% 12.67MiB 592.74KiB 12.08KiB 0 0.0456694 12.68MiB 514.86KiB 10.5KiB 0 0.0396297 False False
splunk_hec_indexer_ack_blackhole 21.94KiB 0.09 64.54% 23.75MiB 869.93KiB 17.69KiB 0 0.0357615 23.77MiB 774.04KiB 15.76KiB 0 0.0317909 False False
splunk_hec_to_splunk_hec_logs_acks 17.07KiB 0.07 51.28% 23.76MiB 887.56KiB 18.05KiB 0 0.0364797 23.77MiB 819.07KiB 16.67KiB 0 0.0336413 False False
syslog_loki 10.22KiB 0.07 45.00% 13.84MiB 430.72KiB 8.81KiB 0 0.0303855 13.85MiB 720.72KiB 14.65KiB 0 0.0508073 False False
splunk_hec_to_splunk_hec_logs_noack 5.49KiB 0.02 39.87% 23.83MiB 387.96KiB 7.92KiB 0 0.0158933 23.84MiB 337.51KiB 6.89KiB 0 0.0138236 False False
enterprise_http_to_http -1.63KiB -0.01 18.04% 23.85MiB 247.72KiB 5.06KiB 0 0.0101422 23.85MiB 246.09KiB 5.04KiB 0 0.0100763 False False
file_to_blackhole -68.56KiB -0.07 50.50% 95.34MiB 3.09MiB 63.98KiB 0 0.032362 95.28MiB 3.73MiB 77.47KiB 0 0.0391159 False False
http_to_http_json -32.04KiB -0.13 98.94% 23.84MiB 345.32KiB 7.05KiB 0 0.0141408 23.81MiB 507.67KiB 10.36KiB 0 0.0208161 False False
syslog_humio_logs -22.39KiB -0.14 97.37% 16.15MiB 383.44KiB 7.83KiB 0 0.0231868 16.12MiB 310.19KiB 6.35KiB 0 0.018783 False False
syslog_log2metric_splunk_hec_metrics -28.51KiB -0.16 88.78% 17.95MiB 575.12KiB 11.72KiB 0 0.03128 17.92MiB 666.9KiB 13.59KiB 0 0.036328 False False
syslog_log2metric_humio_metrics -38.19KiB -0.31 99.84% 12.16MiB 278.26KiB 5.68KiB 0 0.02235 12.12MiB 525.9KiB 10.7KiB 0 0.0423715 False False
fluent_elasticsearch -265.02KiB -0.33 100.00% 79.47MiB 54.48KiB 1.1KiB 0 0.000669285 79.21MiB 2.81MiB 57.68KiB 0 0.0354121 False False
http_to_http_noack -105.26KiB -0.43 100.00% 23.85MiB 249.78KiB 5.1KiB 0 0.0102269 23.74MiB 1.11MiB 23.1KiB 0 0.0466531 False False
datadog_agent_remap_datadog_logs_acks -401.22KiB -0.63 99.95% 62.44MiB 3.34MiB 69.84KiB 0 0.0535175 62.05MiB 4.39MiB 91.35KiB 0 0.0707104 False False
http_pipelines_blackhole -11.34KiB -0.65 100.00% 1.7MiB 12.0KiB 251.25B 0 0.00689946 1.69MiB 98.72KiB 2.01KiB 0 0.0571196 False False
datadog_agent_remap_datadog_logs -514.15KiB -0.8 100.00% 62.88MiB 713.98KiB 14.61KiB 0 0.0110865 62.38MiB 4.24MiB 88.29KiB 0 0.0679682 False False
http_to_http_acks -147.94KiB -0.83 48.42% 17.42MiB 8.12MiB 169.63KiB 0 0.465698 17.28MiB 7.28MiB 151.8KiB 0 0.421181 True True
http_pipelines_no_grok_blackhole -153.46KiB -1.38 100.00% 10.89MiB 280.13KiB 5.72KiB 0 0.0251109 10.74MiB 1.1MiB 22.93KiB 0 0.102508 False False
socket_to_socket_blackhole -555.55KiB -2.36 100.00% 22.95MiB 339.22KiB 6.92KiB 0 0.014432 22.41MiB 181.62KiB 3.71KiB 0 0.00791419 False False
http_text_to_http_json -1.4MiB -3.54 100.00% 39.6MiB 917.51KiB 18.73KiB 0 0.0226222 38.2MiB 850.03KiB 17.36KiB 0 0.0217275 False False

@github-actions
Copy link

Soak Test Results

Baseline: 2731071
Comparison: 2dcf9cb
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_log2metric_splunk_hec_metrics 505.43KiB 2.93 100.00% 16.85MiB 1.13MiB 23.54KiB 0 0.0669449 17.34MiB 1.15MiB 23.97KiB 0 0.0662563 False False
splunk_hec_route_s3 401.58KiB 2.25 100.00% 17.43MiB 2.41MiB 50.08KiB 0 0.137951 17.83MiB 2.38MiB 49.72KiB 0 0.133283 False False
syslog_humio_logs 377.13KiB 2.25 100.00% 16.35MiB 362.3KiB 7.4KiB 0 0.0216364 16.72MiB 170.78KiB 3.5KiB 0 0.00997409 False False
syslog_regex_logs2metric_ddmetrics 226.26KiB 1.77 100.00% 12.48MiB 595.03KiB 12.12KiB 0 0.0465396 12.7MiB 494.27KiB 10.08KiB 0 0.0379861 False False
http_text_to_http_json 515.97KiB 1.31 100.00% 38.42MiB 846.43KiB 17.28KiB 0 0.0215126 38.92MiB 893.38KiB 18.24KiB 0 0.0224119 False False
syslog_splunk_hec_logs 197.94KiB 1.19 100.00% 16.24MiB 768.67KiB 15.64KiB 0 0.0462229 16.43MiB 533.31KiB 10.89KiB 0 0.0316926 False False
datadog_agent_remap_blackhole_acks 399.06KiB 0.69 92.22% 56.88MiB 7.99MiB 166.33KiB 0 0.140442 57.27MiB 7.33MiB 153.34KiB 0 0.127927 False False
http_pipelines_blackhole_acks 5.62KiB 0.45 96.71% 1.23MiB 105.95KiB 2.16KiB 0 0.0843461 1.23MiB 73.99KiB 1.51KiB 0 0.0586424 False False
http_to_http_acks 78.26KiB 0.44 25.82% 17.29MiB 8.05MiB 168.27KiB 0 0.465536 17.37MiB 8.02MiB 167.59KiB 0 0.461795 True True
datadog_agent_remap_blackhole 224.6KiB 0.35 95.56% 61.79MiB 4.18MiB 87.14KiB 0 0.0677021 62.01MiB 3.35MiB 69.86KiB 0 0.0540099 False False
splunk_hec_to_splunk_hec_logs_noack 15.08KiB 0.06 80.17% 23.82MiB 469.54KiB 9.58KiB 0 0.0192433 23.84MiB 330.44KiB 6.75KiB 0 0.0135341 False False
splunk_hec_to_splunk_hec_logs_acks 6.48KiB 0.03 20.47% 23.75MiB 880.24KiB 17.9KiB 0 0.0361805 23.76MiB 856.48KiB 17.42KiB 0 0.0351942 False False
enterprise_http_to_http 1.82KiB 0.01 19.46% 23.84MiB 256.46KiB 5.23KiB 0 0.0105013 23.85MiB 255.28KiB 5.22KiB 0 0.0104522 False False
splunk_hec_indexer_ack_blackhole -1.0KiB -0 3.49% 23.76MiB 789.03KiB 16.05KiB 0 0.032428 23.76MiB 803.16KiB 16.34KiB 0 0.0330099 False False
file_to_blackhole -53.17KiB -0.05 40.06% 95.34MiB 3.1MiB 64.19KiB 0 0.0324726 95.29MiB 3.76MiB 78.24KiB 0 0.0394697 False False
socket_to_socket_blackhole -31.01KiB -0.13 99.92% 22.49MiB 302.74KiB 6.18KiB 0 0.0131405 22.46MiB 336.97KiB 6.88KiB 0 0.014646 False False
http_to_http_json -42.09KiB -0.17 99.82% 23.84MiB 344.84KiB 7.04KiB 0 0.0141203 23.8MiB 563.42KiB 11.49KiB 0 0.0231105 False False
fluent_elasticsearch -181.33KiB -0.22 100.00% 79.47MiB 53.4KiB 1.08KiB 0 0.000656033 79.3MiB 1.6MiB 33.02KiB 0 0.0202247 False False
datadog_agent_remap_datadog_logs_acks -250.39KiB -0.39 97.52% 62.54MiB 3.0MiB 62.69KiB 0 0.0479315 62.29MiB 4.43MiB 92.2KiB 0 0.0710877 False False
http_to_http_noack -104.48KiB -0.43 100.00% 23.84MiB 403.09KiB 8.24KiB 0 0.0165102 23.74MiB 1.14MiB 23.83KiB 0 0.0481526 False False
http_pipelines_blackhole -9.28KiB -0.53 100.00% 1.71MiB 21.68KiB 453.58B 0 0.0124137 1.7MiB 90.72KiB 1.85KiB 0 0.0522187 False False
datadog_agent_remap_datadog_logs -562.66KiB -0.88 100.00% 62.72MiB 262.82KiB 5.38KiB 0 0.00409132 62.17MiB 4.3MiB 89.49KiB 0 0.0691246 False False
http_pipelines_no_grok_blackhole -101.08KiB -0.9 100.00% 10.99MiB 46.6KiB 974.35B 0 0.00414033 10.89MiB 1.11MiB 23.1KiB 0 0.101909 False False
syslog_loki -315.08KiB -2.1 100.00% 14.64MiB 358.96KiB 7.35KiB 0 0.0239351 14.34MiB 793.02KiB 16.12KiB 0 0.0540123 False False
syslog_log2metric_humio_metrics -321.98KiB -2.56 100.00% 12.28MiB 703.27KiB 14.36KiB 0 0.0558961 11.97MiB 838.39KiB 17.07KiB 0 0.0683856 False False

@neuronull neuronull merged commit 4cb953a into master Aug 30, 2022
@neuronull neuronull deleted the neuronull/audit1_source_journald branch August 30, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sources Anything related to the Vector's sources source: journald Anything `journald` source related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify journald source
2 participants