Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify pulsar sink #14096

Closed
2 of 3 tasks
Tracked by #13995
prognant opened this issue Aug 24, 2022 · 2 comments
Closed
2 of 3 tasks
Tracked by #13995

Verify pulsar sink #14096

prognant opened this issue Aug 24, 2022 · 2 comments

Comments

@prognant
Copy link
Contributor

prognant commented Aug 24, 2022

  • Verify internal event processing metrics are tested via assert_X_compliance test helpers
  • Update component_discarded_events_total to match the new instrumentation spec by adding reason to the emitted logs, and intentional to emitted logs and metrics
  • Verify that the component correctly emits the correct error events per the component spec
@prognant
Copy link
Contributor Author

Encoding failure are the only non-recoverable, thus component_discarded_events_total matches the new instrumentation spec thanks to #14021.

@jszwedko
Copy link
Member

@prognant I think the pulsar sink is not emitting an error whenever the send fails?

vector/src/sinks/pulsar.rs

Lines 359 to 363 in 553763f

Some((Err(error), _, finalizers)) => {
finalizers.update_status(EventStatus::Errored);
error!(message = "Pulsar sink generated an error.", %error);
return Poll::Ready(Err(()));
}

I'll reopen, but let me know if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants