Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(prometheus_remote_write sink): Adhere to instrumentation spec #14405

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

neuronull
Copy link
Contributor

Closes: #14092

Epic: #13995

  • Adds test compliance test helpers
  • Adds emission of EndpointBytesSent
  • emits EventsDropped when template rendering error occurs.

Note: wanted to use a Registered event, but I don't think it exists yet for EndpointBytesSent

@neuronull neuronull added domain: observability Anything related to monitoring/observing Vector sink: prometheus_remote_write Anything `prometheus_remote_write` sink related ci-condition: integration tests enable Run integration tests on this PR labels Sep 13, 2022
@neuronull neuronull self-assigned this Sep 13, 2022
@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 85d93f7
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/6321edf805bd2b00092237b6
😎 Deploy Preview https://deploy-preview-14405--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Sep 13, 2022
@github-actions
Copy link

Soak Test Results

Baseline: 2c58589
Comparison: 862583e
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_splunk_hec_logs 490.22KiB 3.13 100.00% 15.28MiB 1.03MiB 21.51KiB 0 0.0675596 15.75MiB 996.7KiB 20.33KiB 0 0.0617675 False False
http_text_to_http_json 987.16KiB 2.62 100.00% 36.74MiB 1.12MiB 23.44KiB 0 0.0305155 37.71MiB 1.22MiB 25.58KiB 0 0.0324525 False False
socket_to_socket_blackhole 528.43KiB 2.22 100.00% 23.25MiB 513.14KiB 10.47KiB 0 0.0215464 23.77MiB 532.42KiB 10.87KiB 0 0.0218704 False False
syslog_loki 294.6KiB 1.98 100.00% 14.5MiB 302.14KiB 6.19KiB 0 0.0203387 14.79MiB 736.23KiB 14.97KiB 0 0.0485955 False False
datadog_agent_remap_blackhole_acks 647.22KiB 1.06 100.00% 59.46MiB 4.4MiB 91.54KiB 0 0.0739297 60.09MiB 2.5MiB 52.27KiB 0 0.041532 False False
syslog_log2metric_splunk_hec_metrics 165.14KiB 0.92 100.00% 17.55MiB 637.85KiB 13.0KiB 0 0.0354756 17.72MiB 749.6KiB 15.26KiB 0 0.0413117 False False
syslog_humio_logs 69.06KiB 0.42 99.99% 16.0MiB 609.15KiB 12.43KiB 0 0.0371641 16.07MiB 586.38KiB 12.0KiB 0 0.0356245 False False
splunk_hec_route_s3 52.8KiB 0.28 54.46% 18.13MiB 2.42MiB 50.38KiB 0 0.133321 18.18MiB 2.37MiB 49.64KiB 0 0.130545 False False
datadog_agent_remap_blackhole 139.57KiB 0.23 79.39% 59.48MiB 4.16MiB 86.62KiB 0 0.0699174 59.62MiB 3.28MiB 68.39KiB 0 0.054986 False False
splunk_hec_to_splunk_hec_logs_noack 14.12KiB 0.06 77.90% 23.82MiB 456.33KiB 9.32KiB 0 0.0187023 23.84MiB 333.4KiB 6.81KiB 0 0.0136561 False False
enterprise_http_to_http -1.16KiB -0 12.72% 23.85MiB 249.97KiB 5.1KiB 0 0.0102348 23.85MiB 252.48KiB 5.16KiB 0 0.0103381 False False
splunk_hec_indexer_ack_blackhole -4.76KiB -0.02 14.75% 23.75MiB 881.67KiB 17.94KiB 0 0.0362392 23.75MiB 898.98KiB 18.29KiB 0 0.0369578 False False
splunk_hec_to_splunk_hec_logs_acks -6.99KiB -0.03 21.27% 23.76MiB 889.01KiB 18.08KiB 0 0.0365347 23.75MiB 911.48KiB 18.54KiB 0 0.0374688 False False
file_to_blackhole -41.52KiB -0.04 36.90% 95.36MiB 2.78MiB 57.58KiB 0 0.0291295 95.31MiB 3.1MiB 64.49KiB 0 0.0325093 False False
http_to_http_json -36.72KiB -0.15 99.59% 23.85MiB 331.37KiB 6.77KiB 0 0.0135678 23.81MiB 531.65KiB 10.85KiB 0 0.0218006 False False
fluent_elasticsearch -160.09KiB -0.2 99.98% 79.47MiB 54.63KiB 1.1KiB 0 0.000671131 79.32MiB 2.1MiB 43.21KiB 0 0.0264454 False False
http_to_http_noack -68.2KiB -0.28 99.85% 23.84MiB 407.92KiB 8.34KiB 0 0.0167081 23.77MiB 973.95KiB 19.84KiB 0 0.0400041 False False
syslog_regex_logs2metric_ddmetrics -47.04KiB -0.38 99.00% 12.18MiB 617.36KiB 12.59KiB 0 0.0494872 12.13MiB 648.29KiB 13.21KiB 0 0.0521634 False False
http_pipelines_no_grok_blackhole -71.95KiB -0.66 99.82% 10.62MiB 211.18KiB 4.31KiB 0 0.0194234 10.55MiB 1.09MiB 22.64KiB 0 0.103105 False False
syslog_log2metric_humio_metrics -114.53KiB -0.87 100.00% 12.9MiB 250.64KiB 5.12KiB 0 0.0189666 12.79MiB 554.28KiB 11.28KiB 0 0.0423101 False False
datadog_agent_remap_datadog_logs_acks -558.45KiB -0.88 100.00% 61.7MiB 3.3MiB 68.86KiB 0 0.0534086 61.15MiB 4.36MiB 90.82KiB 0 0.0713298 False False
datadog_agent_remap_datadog_logs -622.72KiB -0.98 100.00% 61.81MiB 1.4MiB 29.26KiB 0 0.0226048 61.2MiB 4.22MiB 87.94KiB 0 0.0689879 False False
http_pipelines_blackhole_acks -20.14KiB -1.64 100.00% 1.2MiB 108.27KiB 2.2KiB 0 0.0882843 1.18MiB 86.63KiB 1.77KiB 0 0.0718152 False False
http_to_http_acks -394.3KiB -2.2 89.94% 17.51MiB 8.14MiB 170.25KiB 0 0.464921 17.13MiB 8.11MiB 169.3KiB 0 0.473206 True True
http_pipelines_blackhole -48.27KiB -2.78 100.00% 1.69MiB 14.36KiB 300.5B 0 0.00827558 1.65MiB 117.94KiB 2.4KiB 0 0.0699051 False False

@github-actions
Copy link

Soak Test Results

Baseline: 5d1550a
Comparison: 85d93f7
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_log2metric_humio_metrics 405.28KiB 3.25 100.00% 12.19MiB 231.2KiB 4.72KiB 0 0.0185171 12.59MiB 549.78KiB 11.19KiB 0 0.0426481 False False
syslog_regex_logs2metric_ddmetrics 350.15KiB 2.81 100.00% 12.18MiB 620.94KiB 12.65KiB 0 0.0497755 12.52MiB 549.64KiB 11.21KiB 0 0.042857 False False
socket_to_socket_blackhole 615.76KiB 2.62 100.00% 22.96MiB 519.46KiB 10.6KiB 0 0.0220861 23.57MiB 620.4KiB 12.67KiB 0 0.0257045 False False
syslog_splunk_hec_logs 425.23KiB 2.59 100.00% 16.03MiB 777.93KiB 15.82KiB 0 0.0473832 16.45MiB 699.78KiB 14.26KiB 0 0.041547 False False
syslog_log2metric_splunk_hec_metrics 426.36KiB 2.52 100.00% 16.5MiB 983.76KiB 20.05KiB 0 0.058224 16.91MiB 1.04MiB 21.61KiB 0 0.0612688 False False
datadog_agent_remap_blackhole_acks 1.2MiB 2 100.00% 60.15MiB 4.06MiB 84.61KiB 0 0.0675245 61.35MiB 2.79MiB 58.41KiB 0 0.0455186 False False
http_pipelines_blackhole_acks 23.94KiB 1.98 100.00% 1.18MiB 112.57KiB 2.29KiB 0 0.092947 1.21MiB 87.64KiB 1.79KiB 0 0.0709617 False False
http_text_to_http_json 529.74KiB 1.34 100.00% 38.64MiB 903.77KiB 18.45KiB 0 0.0228391 39.15MiB 873.27KiB 17.84KiB 0 0.0217767 False False
datadog_agent_remap_blackhole 670.06KiB 1.08 100.00% 60.53MiB 4.35MiB 90.56KiB 0 0.0718506 61.19MiB 3.17MiB 66.2KiB 0 0.0518597 False False
syslog_humio_logs 174.14KiB 1.06 100.00% 16.09MiB 377.15KiB 7.7KiB 0 0.0228842 16.26MiB 452.59KiB 9.26KiB 0 0.0271743 False False
http_pipelines_blackhole 8.15KiB 0.49 100.00% 1.63MiB 19.69KiB 412.28B 0 0.0117735 1.64MiB 79.19KiB 1.62KiB 0 0.0471255 False False
splunk_hec_to_splunk_hec_logs_noack 22.12KiB 0.09 92.18% 23.82MiB 516.65KiB 10.54KiB 0 0.0211811 23.84MiB 333.75KiB 6.82KiB 0 0.0136702 False False
splunk_hec_route_s3 12.11KiB 0.07 13.76% 18.19MiB 2.4MiB 49.92KiB 0 0.131761 18.2MiB 2.34MiB 48.88KiB 0 0.128427 False False
enterprise_http_to_http 1.82KiB 0.01 19.38% 23.85MiB 256.23KiB 5.23KiB 0 0.0104914 23.85MiB 258.47KiB 5.29KiB 0 0.0105825 False False
syslog_loki -3.09KiB -0.02 12.30% 14.44MiB 526.77KiB 10.79KiB 0 0.0356061 14.44MiB 826.85KiB 16.81KiB 0 0.0559017 False False
splunk_hec_indexer_ack_blackhole -5.62KiB -0.02 17.36% 23.75MiB 873.73KiB 17.78KiB 0 0.0359135 23.75MiB 907.54KiB 18.46KiB 0 0.037312 False False
file_to_blackhole -72.6KiB -0.07 48.58% 95.34MiB 3.39MiB 70.35KiB 0 0.0355899 95.27MiB 4.15MiB 86.22KiB 0 0.0435331 False False
splunk_hec_to_splunk_hec_logs_acks -18.58KiB -0.08 54.20% 23.76MiB 833.68KiB 16.96KiB 0 0.0342617 23.74MiB 905.45KiB 18.41KiB 0 0.0372399 False False
http_to_http_json -33.82KiB -0.14 99.28% 23.85MiB 335.37KiB 6.85KiB 0 0.0137308 23.81MiB 516.33KiB 10.54KiB 0 0.0211691 False False
fluent_elasticsearch -195.69KiB -0.24 99.99% 79.47MiB 55.41KiB 1.12KiB 0 0.000680759 79.28MiB 2.45MiB 50.51KiB 0 0.0309585 False False
datadog_agent_remap_datadog_logs -147.76KiB -0.24 92.52% 60.74MiB 956.95KiB 19.59KiB 0 0.0153834 60.59MiB 3.87MiB 80.56KiB 0 0.0638062 False False
http_to_http_noack -93.55KiB -0.38 100.00% 23.84MiB 256.88KiB 5.25KiB 0 0.0105183 23.75MiB 1.05MiB 21.8KiB 0 0.0439925 False False
http_pipelines_no_grok_blackhole -52.38KiB -0.48 97.93% 10.69MiB 183.89KiB 3.76KiB 0 0.0167911 10.64MiB 1.07MiB 22.32KiB 0 0.100708 False False
datadog_agent_remap_datadog_logs_acks -386.08KiB -0.62 99.53% 60.87MiB 4.03MiB 84.16KiB 0 0.0661379 60.49MiB 5.16MiB 107.51KiB 0 0.0853666 False False
http_to_http_acks -261.85KiB -1.47 73.53% 17.36MiB 7.99MiB 167.03KiB 0 0.460159 17.11MiB 7.89MiB 164.91KiB 0 0.461109 True True

@neuronull neuronull merged commit 52f2015 into master Sep 14, 2022
@neuronull neuronull deleted the neuronull/audit1_sink_prometheus_remote_write branch September 14, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-condition: integration tests enable Run integration tests on this PR domain: observability Anything related to monitoring/observing Vector domain: sinks Anything related to the Vector's sinks sink: prometheus_remote_write Anything `prometheus_remote_write` sink related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify prometheus_remote_write sink
2 participants