Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify socket sink #14211

Closed
3 tasks done
Tracked by #13995
prognant opened this issue Aug 31, 2022 · 1 comment · Fixed by #14425
Closed
3 tasks done
Tracked by #13995

Verify socket sink #14211

prognant opened this issue Aug 31, 2022 · 1 comment · Fixed by #14425
Assignees
@neuronull
Labels
sink: socket Anything `socket` sink related

Comments

@prognant
Copy link
Contributor

prognant commented Aug 31, 2022 •
edited by neuronull
Loading

  • Verify internal event processing metrics are tested via assert_X_compliance test helpers
  • Update component_discarded_events_total to match the new instrumentation spec by adding reason to the emitted logs, and intentional to emitted logs and metrics
  • Verify that the component correctly emits the correct error events per the component spec
@prognant prognant mentioned this issue Aug 31, 2022
Closed
90 tasks
@neuronull neuronull added the sink: socket Anything `socket` sink related label Sep 14, 2022
@neuronull neuronull self-assigned this Sep 14, 2022
@neuronull
Copy link
Contributor

Have TODOs on a branch but waiting for the socket source audit to be complete to avoid conflicts.

@neuronull neuronull mentioned this issue Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neuronull neuronull

Labels
sink: socket Anything `socket` sink related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancement(socket sink): Adhere to instrumentation spec vectordotdev/vector
2 participants
@neuronull @prognant