fix(observability): emit RequestBuildError when HttpSink::request_builder errors
#14575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Wakely <[email protected]>
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
domain: sinks
spencergilbert
approved these changes
Sep 26, 2022
| let byte_size = request.body().len(); | ||
| let request = request.map(Body::from); | ||
| let (protocol, endpoint) = uri::protocol_endpoint(request.uri().clone()); | ||
|
|
||
| // Any errors raised in `http_client.call` results in a `GotHttpWarning` event being emmited |
There was a problem hiding this comment.
🤔 unrelated to this change, but since you mentioned it - should that always be a warning or does it already depend on the error raised?
There was a problem hiding this comment.
Yeah I think it is badly named. Will fix that in a separate PR.
Soak Test ResultsBaseline: 677ef7f ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
neuronull
approved these changes
Sep 26, 2022
StephenWakely
deleted the
stephen/http_batch_service_request_builder_error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #14526
Epic: #13995
This emits a
RequestBuildErrorif therequest_builderfunction returns an error.I have looked through all the sinks that implement this trait, and none currently emit an event here, so as far as I can tell there doesn't appear to be any risk of duplicate events.
Signed-off-by: Stephen Wakely [email protected]