Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(influxdb_logs, influxdb_metrics sinks): Adhere to instrumentation spec #14355

Merged
merged 7 commits into from
Sep 13, 2022

Conversation

neuronull
Copy link
Contributor

Closes: #14311
Closes: #14317

Epic: #13995

@neuronull neuronull added domain: observability Anything related to monitoring/observing Vector sink: influxdb_metrics Anything `influxdb_metrics` sink related sink: influxdb_logs Anything `influxdb_logs` sink related labels Sep 9, 2022
@neuronull neuronull self-assigned this Sep 9, 2022
@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 66c8d44
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/631bb0e1214dbb000983b5c0

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Soak Test Results

Baseline: 675cbf4
Comparison: 5874d69
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_pipelines_blackhole_acks 17.4KiB 1.52 100.00% 1.12MiB 154.12KiB 3.14KiB 0 0.134649 1.13MiB 142.15KiB 2.9KiB 0 0.122334 False False
datadog_agent_remap_blackhole 830.05KiB 1.41 100.00% 57.51MiB 4.41MiB 91.88KiB 0 0.0766781 58.33MiB 3.46MiB 72.15KiB 0 0.0592706 False False
http_to_http_acks 185.26KiB 1.06 58.12% 17.15MiB 7.81MiB 163.33KiB 0 0.455549 17.33MiB 7.7MiB 160.68KiB 0 0.444298 True True
datadog_agent_remap_blackhole_acks 655.88KiB 1.05 100.00% 61.14MiB 4.02MiB 83.65KiB 0 0.0656686 61.78MiB 2.07MiB 43.31KiB 0 0.0334748 False False
syslog_humio_logs 123.87KiB 0.74 100.00% 16.45MiB 188.27KiB 3.84KiB 0 0.0111773 16.57MiB 154.79KiB 3.17KiB 0 0.00912244 False False
syslog_splunk_hec_logs 101.77KiB 0.62 100.00% 16.01MiB 670.53KiB 13.66KiB 0 0.0408851 16.11MiB 697.42KiB 14.2KiB 0 0.0422624 False False
syslog_regex_logs2metric_ddmetrics 70.6KiB 0.57 100.00% 12.19MiB 637.56KiB 12.98KiB 0 0.0510505 12.26MiB 534.68KiB 10.9KiB 0 0.0425726 False False
http_text_to_http_json 143.39KiB 0.37 100.00% 38.2MiB 834.47KiB 17.03KiB 0 0.0213273 38.34MiB 822.81KiB 16.8KiB 0 0.0209525 False False
splunk_hec_to_splunk_hec_logs_noack 25.84KiB 0.11 95.46% 23.81MiB 541.15KiB 11.04KiB 0 0.0221871 23.84MiB 328.08KiB 6.7KiB 0 0.0134368 False False
splunk_hec_indexer_ack_blackhole 16.81KiB 0.07 48.91% 23.74MiB 920.37KiB 18.71KiB 0 0.0378534 23.76MiB 856.44KiB 17.42KiB 0 0.0351998 False False
datadog_agent_remap_datadog_logs_acks 13.93KiB 0.02 7.96% 59.41MiB 4.23MiB 88.44KiB 0 0.07121 59.42MiB 5.18MiB 107.73KiB 0 0.0870839 False False
enterprise_http_to_http -2.84KiB -0.01 29.78% 23.85MiB 255.8KiB 5.22KiB 0 0.0104732 23.84MiB 257.44KiB 5.27KiB 0 0.0105415 False False
splunk_hec_to_splunk_hec_logs_acks -12.3KiB -0.05 39.22% 23.77MiB 811.06KiB 16.5KiB 0 0.0333203 23.75MiB 854.67KiB 17.38KiB 0 0.0351298 False False
file_to_blackhole -57.08KiB -0.06 46.13% 95.34MiB 3.0MiB 62.14KiB 0 0.0314348 95.28MiB 3.32MiB 68.97KiB 0 0.0348068 False False
syslog_log2metric_humio_metrics -12.37KiB -0.09 72.86% 12.95MiB 273.17KiB 5.58KiB 0 0.0206023 12.93MiB 479.43KiB 9.77KiB 0 0.0361924 False False
http_to_http_json -28.02KiB -0.11 98.20% 23.85MiB 330.49KiB 6.75KiB 0 0.0135308 23.82MiB 475.7KiB 9.73KiB 0 0.019498 False False
socket_to_socket_blackhole -29.4KiB -0.13 71.38% 22.6MiB 934.64KiB 19.08KiB 0 0.0403787 22.57MiB 974.23KiB 19.89KiB 0 0.0421424 False False
http_to_http_noack -33.98KiB -0.14 88.60% 23.82MiB 604.38KiB 12.35KiB 0 0.0247722 23.79MiB 863.41KiB 17.6KiB 0 0.0354389 False False
fluent_elasticsearch -175.02KiB -0.22 100.00% 79.47MiB 53.32KiB 1.08KiB 0 0.000655118 79.3MiB 1.55MiB 31.83KiB 0 0.019498 False False
splunk_hec_route_s3 -44.22KiB -0.25 41.75% 17.4MiB 2.72MiB 56.69KiB 0 0.156442 17.36MiB 2.73MiB 57.07KiB 0 0.157113 False False
datadog_agent_remap_datadog_logs -162.34KiB -0.26 92.43% 61.44MiB 1.07MiB 22.52KiB 0 0.0174844 61.29MiB 4.25MiB 88.56KiB 0 0.069388 False False
http_pipelines_blackhole -4.85KiB -0.28 94.06% 1.69MiB 11.64KiB 243.74B 0 0.00673742 1.68MiB 125.6KiB 2.56KiB 0 0.0728804 False False
http_pipelines_no_grok_blackhole -66.31KiB -0.6 99.83% 10.84MiB 41.37KiB 864.83B 0 0.00372679 10.77MiB 1.01MiB 21.07KiB 0 0.0938942 False False
syslog_log2metric_splunk_hec_metrics -154.81KiB -0.94 100.00% 16.14MiB 1.13MiB 23.6KiB 0 0.0700806 15.99MiB 1.2MiB 24.96KiB 0 0.0748907 False False
syslog_loki -175.47KiB -1.15 100.00% 14.86MiB 427.33KiB 8.74KiB 0 0.0280749 14.69MiB 737.88KiB 15.0KiB 0 0.0490437 False False

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Soak Test Results

Baseline: f705842
Comparison: 92a76c7
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_blackhole_acks 2.82MiB 4.85 100.00% 58.06MiB 6.01MiB 125.11KiB 0 0.103492 60.88MiB 4.04MiB 84.5KiB 0 0.066373 False False
syslog_log2metric_splunk_hec_metrics 491.37KiB 2.79 100.00% 17.18MiB 983.47KiB 20.05KiB 0 0.055898 17.66MiB 689.29KiB 14.05KiB 0 0.0381125 False False
http_text_to_http_json 675.9KiB 1.73 100.00% 38.19MiB 851.35KiB 17.38KiB 0 0.0217651 38.85MiB 780.2KiB 15.93KiB 0 0.0196073 False False
socket_to_socket_blackhole 149.7KiB 0.62 100.00% 23.51MiB 196.08KiB 4.0KiB 0 0.00814458 23.65MiB 203.37KiB 4.15KiB 0 0.0083953 False False
http_pipelines_blackhole_acks 6.48KiB 0.53 93.21% 1.2MiB 137.77KiB 2.8KiB 0 0.111913 1.21MiB 106.73KiB 2.18KiB 0 0.0862388 False False
splunk_hec_route_s3 29.58KiB 0.16 34.67% 18.59MiB 2.25MiB 46.88KiB 0 0.12114 18.61MiB 2.21MiB 46.24KiB 0 0.118818 False False
splunk_hec_to_splunk_hec_logs_noack 16.38KiB 0.07 83.48% 23.82MiB 472.2KiB 9.63KiB 0 0.0193521 23.84MiB 333.71KiB 6.81KiB 0 0.0136671 False False
splunk_hec_indexer_ack_blackhole 9.3KiB 0.04 29.48% 23.76MiB 868.18KiB 17.67KiB 0 0.0356774 23.77MiB 840.42KiB 17.11KiB 0 0.0345234 False False
splunk_hec_to_splunk_hec_logs_acks 3.38KiB 0.01 11.00% 23.75MiB 856.42KiB 17.42KiB 0 0.0352038 23.76MiB 842.69KiB 17.14KiB 0 0.0346348 False False
enterprise_http_to_http -1.3KiB -0.01 13.86% 23.85MiB 262.3KiB 5.35KiB 0 0.0107393 23.85MiB 253.37KiB 5.18KiB 0 0.0103743 False False
file_to_blackhole -69.55KiB -0.07 46.38% 95.34MiB 3.52MiB 73.02KiB 0 0.0369415 95.27MiB 4.11MiB 85.49KiB 0 0.0431381 False False
syslog_regex_logs2metric_ddmetrics -11.99KiB -0.09 52.71% 12.52MiB 604.18KiB 12.3KiB 0 0.0471166 12.51MiB 554.5KiB 11.3KiB 0 0.0432822 False False
http_to_http_json -39.64KiB -0.16 99.80% 23.85MiB 332.42KiB 6.79KiB 0 0.0136095 23.81MiB 532.75KiB 10.88KiB 0 0.0218463 False False
http_to_http_noack -60.14KiB -0.25 99.88% 23.85MiB 247.04KiB 5.06KiB 0 0.010115 23.79MiB 878.42KiB 17.9KiB 0 0.0360554 False False
syslog_log2metric_humio_metrics -35.54KiB -0.27 99.99% 12.75MiB 186.96KiB 3.82KiB 0 0.0143132 12.72MiB 419.36KiB 8.55KiB 0 0.0321929 False False
http_pipelines_blackhole -5.54KiB -0.31 98.09% 1.72MiB 13.79KiB 288.46B 0 0.00783932 1.71MiB 115.03KiB 2.34KiB 0 0.0656185 False False
datadog_agent_remap_blackhole -262.78KiB -0.43 93.94% 59.66MiB 5.15MiB 107.18KiB 0 0.0862499 59.4MiB 4.32MiB 90.09KiB 0 0.0726759 False False
syslog_humio_logs -84.66KiB -0.51 100.00% 16.34MiB 112.8KiB 2.3KiB 0 0.0067395 16.26MiB 235.22KiB 4.81KiB 0 0.0141249 False False
fluent_elasticsearch -425.3KiB -0.52 100.00% 79.47MiB 54.36KiB 1.1KiB 0 0.000667804 79.06MiB 4.38MiB 89.91KiB 0 0.0553548 False False
http_pipelines_no_grok_blackhole -63.92KiB -0.58 99.58% 10.84MiB 50.55KiB 1.03KiB 0 0.00455138 10.78MiB 1.07MiB 22.31KiB 0 0.0993529 False False
syslog_loki -89.16KiB -0.6 100.00% 14.43MiB 296.5KiB 6.08KiB 0 0.0200551 14.35MiB 736.82KiB 14.98KiB 0 0.0501408 False False
syslog_splunk_hec_logs -138.67KiB -0.86 99.99% 15.72MiB 1.21MiB 25.28KiB 0 0.0772256 15.58MiB 1.16MiB 24.2KiB 0 0.0742749 False False
http_to_http_acks -158.87KiB -0.9 50.18% 17.33MiB 8.19MiB 171.22KiB 0 0.472403 17.18MiB 7.68MiB 160.33KiB 0 0.447184 True True
datadog_agent_remap_datadog_logs -712.28KiB -1.12 100.00% 61.98MiB 235.44KiB 4.82KiB 0 0.00370904 61.28MiB 4.11MiB 85.55KiB 0 0.0670283 False False
datadog_agent_remap_datadog_logs_acks -1.09MiB -1.82 100.00% 59.92MiB 3.47MiB 72.64KiB 0 0.0579597 58.83MiB 4.75MiB 98.85KiB 0 0.0806957 False False

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Soak Test Results

Baseline: f705842
Comparison: 66c8d44
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_text_to_http_json 421.67KiB 1.08 100.00% 37.98MiB 819.58KiB 16.73KiB 0 0.0210684 38.39MiB 865.82KiB 17.68KiB 0 0.0220184 False False
socket_to_socket_blackhole 162.37KiB 0.68 100.00% 23.42MiB 269.2KiB 5.5KiB 0 0.0112233 23.58MiB 186.39KiB 3.81KiB 0 0.00771846 False False
http_pipelines_blackhole_acks 4.66KiB 0.37 87.94% 1.23MiB 118.1KiB 2.4KiB 0 0.0937696 1.23MiB 88.15KiB 1.8KiB 0 0.0697359 False False
syslog_splunk_hec_logs 21.63KiB 0.13 73.06% 16.28MiB 696.78KiB 14.19KiB 0 0.0417811 16.3MiB 661.99KiB 13.49KiB 0 0.0396439 False False
splunk_hec_to_splunk_hec_logs_noack 20.37KiB 0.08 90.05% 23.82MiB 508.02KiB 10.37KiB 0 0.0208261 23.84MiB 330.03KiB 6.74KiB 0 0.013518 False False
splunk_hec_indexer_ack_blackhole 16.86KiB 0.07 49.82% 23.75MiB 910.7KiB 18.52KiB 0 0.037441 23.77MiB 832.47KiB 16.94KiB 0 0.0342011 False False
syslog_humio_logs 5.03KiB 0.03 52.24% 16.42MiB 330.01KiB 6.73KiB 0 0.0196267 16.42MiB 107.87KiB 2.21KiB 0 0.00641333 False False
enterprise_http_to_http 213.01B 0 2.28% 23.85MiB 249.6KiB 5.09KiB 0 0.0102195 23.85MiB 254.4KiB 5.2KiB 0 0.010416 False False
splunk_hec_to_splunk_hec_logs_acks -28.07KiB -0.12 74.94% 23.77MiB 789.7KiB 16.07KiB 0 0.0324403 23.74MiB 905.11KiB 18.4KiB 0 0.037224 False False
splunk_hec_route_s3 -22.25KiB -0.12 26.68% 18.76MiB 2.25MiB 46.76KiB 0 0.119645 18.74MiB 2.18MiB 45.52KiB 0 0.116041 False False
syslog_regex_logs2metric_ddmetrics -16.6KiB -0.13 74.00% 12.37MiB 547.91KiB 11.16KiB 0 0.0432589 12.35MiB 471.73KiB 9.62KiB 0 0.0372926 False False
file_to_blackhole -129.5KiB -0.13 70.81% 95.33MiB 3.76MiB 77.95KiB 0 0.0394503 95.21MiB 4.57MiB 94.96KiB 0 0.0480338 False False
http_to_http_json -37.39KiB -0.15 99.64% 23.85MiB 332.9KiB 6.8KiB 0 0.0136302 23.81MiB 532.85KiB 10.88KiB 0 0.0218502 False False
fluent_elasticsearch -188.95KiB -0.23 100.00% 79.47MiB 54.11KiB 1.09KiB 0 0.000664801 79.29MiB 1.62MiB 33.3KiB 0 0.0204053 False False
http_pipelines_blackhole -4.55KiB -0.27 92.29% 1.64MiB 33.32KiB 696.67B 0 0.0197964 1.64MiB 121.74KiB 2.48KiB 0 0.0725333 False False
datadog_agent_remap_blackhole_acks -237.79KiB -0.37 97.66% 61.96MiB 4.22MiB 87.83KiB 0 0.0680595 61.72MiB 2.74MiB 57.34KiB 0 0.0443841 False False
syslog_log2metric_splunk_hec_metrics -68.73KiB -0.38 99.99% 17.58MiB 597.21KiB 12.17KiB 0 0.033169 17.51MiB 657.48KiB 13.39KiB 0 0.0366565 False False
http_pipelines_no_grok_blackhole -45.8KiB -0.41 97.40% 10.83MiB 72.38KiB 1.48KiB 0 0.00652738 10.78MiB 1007.87KiB 20.5KiB 0 0.0912731 False False
http_to_http_noack -122.06KiB -0.5 100.00% 23.84MiB 406.84KiB 8.32KiB 0 0.0166645 23.72MiB 1.23MiB 25.68KiB 0 0.0519538 False False
datadog_agent_remap_blackhole -332.33KiB -0.53 99.94% 60.75MiB 3.79MiB 78.94KiB 0 0.062295 60.42MiB 2.63MiB 54.89KiB 0 0.043511 False False
syslog_log2metric_humio_metrics -79.77KiB -0.61 100.00% 12.78MiB 269.85KiB 5.51KiB 0 0.0206076 12.71MiB 516.79KiB 10.52KiB 0 0.039708 False False
datadog_agent_remap_datadog_logs_acks -608.16KiB -0.96 100.00% 61.78MiB 2.94MiB 61.45KiB 0 0.0475558 61.18MiB 4.23MiB 88.03KiB 0 0.0690868 False False
datadog_agent_remap_datadog_logs -774.34KiB -1.21 100.00% 62.38MiB 362.58KiB 7.42KiB 0 0.00567491 61.62MiB 4.05MiB 84.27KiB 0 0.0656436 False False
http_to_http_acks -272.14KiB -1.52 74.02% 17.48MiB 8.35MiB 174.59KiB 0 0.477633 17.22MiB 7.99MiB 166.84KiB 0 0.46396 True True
syslog_loki -253.22KiB -1.72 100.00% 14.41MiB 529.37KiB 10.84KiB 0 0.0358754 14.16MiB 914.09KiB 18.58KiB 0 0.0630303 False False

@neuronull neuronull merged commit fd9e733 into master Sep 13, 2022
@neuronull neuronull deleted the neuronull/audit1_sink_influxdb branch September 13, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector domain: sinks Anything related to the Vector's sinks sink: influxdb_logs Anything `influxdb_logs` sink related sink: influxdb_metrics Anything `influxdb_metrics` sink related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify influxdb_metrics sink Verify influxdb_logs sink
2 participants