Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(host_metrics source): correctly emit error events per the component instrumentation spec #14126

Merged
merged 4 commits into from
Aug 29, 2022

Conversation

neuronull
Copy link
Contributor

Converted legacy error! prints to emit internal Error events.

Closes: #14055

Part of: #13995

@neuronull neuronull self-assigned this Aug 26, 2022
@neuronull neuronull added the source: host_metrics Anything `host_metrics` source related label Aug 26, 2022
@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Aug 26, 2022
@netlify
Copy link

netlify bot commented Aug 26, 2022

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 1784844
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63091665b96228000885552d

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good.

@github-actions
Copy link

Soak Test Results

Baseline: f88819b
Comparison: 1784844
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_log2metric_humio_metrics 187.33KiB 1.42 100.00% 12.85MiB 276.92KiB 5.65KiB 0 0.021048 13.03MiB 510.11KiB 10.39KiB 0 0.0382276 False False
splunk_hec_route_s3 95.51KiB 0.53 76.24% 17.68MiB 2.74MiB 57.07KiB 0 0.155023 17.77MiB 2.74MiB 57.27KiB 0 0.154049 False False
http_text_to_http_json 69.93KiB 0.18 99.56% 38.53MiB 814.48KiB 16.63KiB 0 0.0206379 38.6MiB 882.59KiB 18.03KiB 0 0.0223243 False False
http_pipelines_blackhole_acks 1.39KiB 0.11 38.67% 1.21MiB 109.71KiB 2.23KiB 0 0.0884037 1.21MiB 78.69KiB 1.6KiB 0 0.0633381 False False
syslog_splunk_hec_logs 5.54KiB 0.03 22.64% 16.43MiB 776.0KiB 15.78KiB 0 0.0461175 16.43MiB 539.77KiB 11.02KiB 0 0.0320679 False False
splunk_hec_to_splunk_hec_logs_noack -386.43B -0 3.16% 23.84MiB 330.78KiB 6.76KiB 0 0.0135483 23.84MiB 327.79KiB 6.69KiB 0 0.0134259 False False
enterprise_http_to_http -1.39KiB -0.01 15.35% 23.85MiB 246.23KiB 5.03KiB 0 0.0100812 23.85MiB 252.01KiB 5.16KiB 0 0.0103183 False False
http_to_http_acks -1.67KiB -0.01 0.57% 17.13MiB 8.07MiB 168.7KiB 0 0.470843 17.13MiB 7.74MiB 161.65KiB 0 0.452065 True True
splunk_hec_indexer_ack_blackhole -1.69KiB -0.01 5.07% 23.75MiB 913.14KiB 18.57KiB 0 0.0375427 23.75MiB 928.74KiB 18.89KiB 0 0.0381867 False False
splunk_hec_to_splunk_hec_logs_acks -8.02KiB -0.03 26.59% 23.76MiB 803.41KiB 16.35KiB 0 0.0330094 23.76MiB 837.02KiB 17.03KiB 0 0.0344016 False False
file_to_blackhole -60.9KiB -0.06 48.29% 95.34MiB 3.05MiB 63.28KiB 0 0.0320097 95.28MiB 3.34MiB 69.51KiB 0 0.0350836 False False
http_to_http_json -24.03KiB -0.1 96.28% 23.85MiB 330.35KiB 6.74KiB 0 0.0135249 23.82MiB 457.2KiB 9.35KiB 0 0.0187367 False False
datadog_agent_remap_blackhole -148.98KiB -0.24 78.79% 61.81MiB 4.69MiB 97.78KiB 0 0.0759201 61.67MiB 3.28MiB 68.48KiB 0 0.0531836 False False
syslog_loki -38.54KiB -0.26 98.69% 14.64MiB 235.08KiB 4.82KiB 0 0.0156734 14.61MiB 726.03KiB 14.76KiB 0 0.0485318 False False
http_to_http_noack -70.59KiB -0.29 99.97% 23.85MiB 249.78KiB 5.11KiB 0 0.0102272 23.78MiB 931.72KiB 18.99KiB 0 0.0382589 False False
syslog_regex_logs2metric_ddmetrics -64.56KiB -0.5 99.98% 12.69MiB 614.89KiB 12.53KiB 0 0.0473022 12.63MiB 604.39KiB 12.31KiB 0 0.0467271 False False
fluent_elasticsearch -476.26KiB -0.59 100.00% 79.47MiB 52.59KiB 1.06KiB 0 0.000646078 79.01MiB 4.57MiB 93.87KiB 0 0.057871 False False
syslog_log2metric_splunk_hec_metrics -124.08KiB -0.69 100.00% 17.44MiB 1004.5KiB 20.47KiB 0 0.0562279 17.32MiB 1.01MiB 21.07KiB 0 0.0583038 False False
http_pipelines_blackhole -12.86KiB -0.74 100.00% 1.69MiB 33.58KiB 702.57B 0 0.0193651 1.68MiB 131.53KiB 2.68KiB 0 0.0764082 False False
syslog_humio_logs -186.33KiB -1.17 100.00% 15.61MiB 1.34MiB 27.93KiB 0 0.0856233 15.42MiB 1.35MiB 28.39KiB 0 0.0877602 False False
datadog_agent_remap_blackhole_acks -862.33KiB -1.32 100.00% 63.92MiB 4.42MiB 92.07KiB 0 0.0691672 63.08MiB 2.36MiB 49.36KiB 0 0.0373609 False False
http_pipelines_no_grok_blackhole -200.47KiB -1.76 100.00% 11.13MiB 263.23KiB 5.37KiB 0 0.0231002 10.93MiB 1.11MiB 23.18KiB 0 0.10186 False False
datadog_agent_remap_datadog_logs -1.19MiB -1.91 100.00% 62.03MiB 1016.0KiB 20.8KiB 0 0.0159921 60.84MiB 4.18MiB 87.12KiB 0 0.0687456 False False
datadog_agent_remap_datadog_logs_acks -1.32MiB -2.19 100.00% 60.33MiB 4.39MiB 91.77KiB 0 0.0727579 59.01MiB 5.37MiB 111.71KiB 0 0.0909348 False False
socket_to_socket_blackhole -566.11KiB -2.37 100.00% 23.37MiB 280.34KiB 5.72KiB 0 0.0117099 22.82MiB 263.42KiB 5.38KiB 0 0.0112696 False False

@neuronull neuronull merged commit e81d020 into master Aug 29, 2022
@neuronull neuronull deleted the neuronull/audit1_source_host_metrics_emit_error branch August 29, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sources Anything related to the Vector's sources source: host_metrics Anything `host_metrics` source related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify host_metrics source
3 participants