Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify statsd sink #14214

Closed
3 tasks done
Tracked by #13995
prognant opened this issue Aug 31, 2022 · 1 comment · Fixed by #14434
Closed
3 tasks done
Tracked by #13995

Verify statsd sink #14214

prognant opened this issue Aug 31, 2022 · 1 comment · Fixed by #14434
Assignees
Labels
domain: observability Anything related to monitoring/observing Vector sink: statsd Anything `statsd` sink related

Comments

@prognant
Copy link
Contributor

prognant commented Aug 31, 2022

  • Verify internal event processing metrics are tested via assert_X_compliance test helpers
  • Update component_discarded_events_total to match the new instrumentation spec by adding reason to the emitted logs, and intentional to emitted logs and metrics
  • Verify that the component correctly emits the correct error events per the component spec
@neuronull neuronull self-assigned this Sep 14, 2022
@neuronull neuronull added sink: statsd Anything `statsd` sink related domain: observability Anything related to monitoring/observing Vector labels Sep 14, 2022
@neuronull
Copy link
Contributor

Have a couple changes on branch but there is an outstanding question I have about the sink framework and SinkSendError , where should we be reporting EventsDropped in the service based sinks, if not there?

The answer to that may imply more changes for this sink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector sink: statsd Anything `statsd` sink related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants