Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(statsd sink): Adhere to instrumentation spec #14434

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

neuronull
Copy link
Contributor

Closes: #14214

Epic: #13995

This is the sink that made me realize the EventsDropped aren't being handled by the sink retry code.
There is ongoing discussion on how to handle it but this PR bring statsd sink up to the current standards.

@neuronull neuronull added the sink: statsd Anything `statsd` sink related label Sep 15, 2022
@neuronull neuronull self-assigned this Sep 15, 2022
@netlify
Copy link

netlify bot commented Sep 15, 2022

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 6aea8b7
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/632883360a46ae00081b5aa7

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Sep 15, 2022
src/sinks/statsd.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

Soak Test Results

Baseline: 2db1aab
Comparison: 3f65f55
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_log2metric_humio_metrics 146.54KiB 1.15 100.00% 12.42MiB 355.26KiB 7.26KiB 0 0.027924 12.56MiB 714.73KiB 14.55KiB 0 0.0555388 False False
syslog_splunk_hec_logs 183.53KiB 1.09 100.00% 16.37MiB 780.34KiB 15.87KiB 0 0.0465343 16.55MiB 669.81KiB 13.64KiB 0 0.0395107 False False
datadog_agent_remap_blackhole_acks 541.39KiB 0.86 100.00% 61.26MiB 4.23MiB 88.14KiB 0 0.0690921 61.78MiB 3.01MiB 62.96KiB 0 0.0487338 False False
http_pipelines_blackhole_acks 9.08KiB 0.72 99.94% 1.23MiB 104.02KiB 2.12KiB 0 0.082783 1.24MiB 77.74KiB 1.58KiB 0 0.0614267 False False
datadog_agent_remap_blackhole 433.27KiB 0.71 100.00% 59.75MiB 4.09MiB 85.26KiB 0 0.0684832 60.17MiB 2.99MiB 62.48KiB 0 0.0497566 False False
socket_to_socket_blackhole 156.88KiB 0.66 100.00% 23.18MiB 1.09MiB 22.74KiB 0 0.0469163 23.34MiB 904.05KiB 18.46KiB 0 0.0378234 False False
http_pipelines_blackhole 8.12KiB 0.5 98.94% 1.57MiB 89.14KiB 1.82KiB 0 0.0553401 1.58MiB 127.72KiB 2.6KiB 0 0.0788907 False False
syslog_log2metric_splunk_hec_metrics 74.59KiB 0.42 97.42% 17.33MiB 1.1MiB 22.96KiB 0 0.0634815 17.41MiB 1.17MiB 24.32KiB 0 0.0670029 False False
splunk_hec_indexer_ack_blackhole 15.92KiB 0.07 45.86% 23.74MiB 936.48KiB 19.04KiB 0 0.038511 23.76MiB 874.64KiB 17.8KiB 0 0.0359444 False False
splunk_hec_to_splunk_hec_logs_noack 10.39KiB 0.04 64.79% 23.83MiB 427.34KiB 8.72KiB 0 0.0175096 23.84MiB 341.43KiB 6.97KiB 0 0.0139835 False False
syslog_humio_logs -462.97B -0 4.40% 16.21MiB 285.96KiB 5.84KiB 0 0.0172223 16.21MiB 280.37KiB 5.74KiB 0 0.0168858 False False
http_pipelines_no_grok_blackhole -1.36KiB -0.01 4.25% 10.61MiB 439.15KiB 8.97KiB 0 0.0404259 10.6MiB 1.14MiB 23.82KiB 0 0.107888 False False
enterprise_http_to_http -4.3KiB -0.02 42.78% 23.85MiB 267.8KiB 5.47KiB 0 0.0109644 23.84MiB 259.09KiB 5.3KiB 0 0.0106095 False False
splunk_hec_to_splunk_hec_logs_acks -11.94KiB -0.05 38.61% 23.77MiB 794.02KiB 16.16KiB 0 0.0326197 23.75MiB 849.41KiB 17.28KiB 0 0.0349121 False False
file_to_blackhole -119.75KiB -0.12 68.24% 95.33MiB 3.4MiB 70.38KiB 0 0.0356201 95.21MiB 4.67MiB 96.95KiB 0 0.0490189 False False
http_to_http_json -34.18KiB -0.14 99.31% 23.84MiB 336.71KiB 6.88KiB 0 0.0137872 23.81MiB 519.17KiB 10.6KiB 0 0.0212881 False False
fluent_elasticsearch -200.73KiB -0.25 100.00% 79.47MiB 54.8KiB 1.11KiB 0 0.000673219 79.28MiB 1.73MiB 35.54KiB 0 0.0217895 False False
datadog_agent_remap_datadog_logs_acks -230.17KiB -0.36 96.96% 61.98MiB 2.62MiB 54.89KiB 0 0.0423043 61.75MiB 4.37MiB 91.01KiB 0 0.0707853 False False
http_to_http_noack -120.45KiB -0.49 100.00% 23.84MiB 413.25KiB 8.45KiB 0 0.0169271 23.72MiB 1.22MiB 25.43KiB 0 0.0514347 False False
http_to_http_acks -96.11KiB -0.54 31.62% 17.45MiB 8.01MiB 167.41KiB 0 0.458723 17.36MiB 7.96MiB 166.27KiB 0 0.458427 True True
datadog_agent_remap_datadog_logs -397.77KiB -0.63 100.00% 62.14MiB 276.06KiB 5.65KiB 0 0.00433753 61.75MiB 4.03MiB 83.85KiB 0 0.065178 False False
syslog_regex_logs2metric_ddmetrics -83.04KiB -0.67 100.00% 12.14MiB 665.66KiB 13.56KiB 0 0.0535529 12.05MiB 604.07KiB 12.32KiB 0 0.0489249 False False
syslog_loki -109.78KiB -0.76 100.00% 14.17MiB 772.82KiB 15.81KiB 0 0.0532564 14.06MiB 912.05KiB 18.54KiB 0 0.0633305 False False
http_text_to_http_json -624.21KiB -1.6 100.00% 38.15MiB 840.72KiB 17.16KiB 0 0.0215169 37.54MiB 831.29KiB 16.98KiB 0 0.0216211 False False
splunk_hec_route_s3 -820.03KiB -4.42 100.00% 18.13MiB 2.45MiB 51.02KiB 0 0.135145 17.33MiB 2.47MiB 51.76KiB 0 0.14261 False False

@neuronull neuronull enabled auto-merge (squash) September 19, 2022 14:57
@neuronull neuronull merged commit 8f10836 into master Sep 19, 2022
@neuronull neuronull deleted the neuronull/audit1_sink_statsd branch September 19, 2022 16:22
@github-actions
Copy link

Soak Test Results

Baseline: 9db87b2
Comparison: 6aea8b7
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_pipelines_blackhole 77.26KiB 4.77 100.00% 1.58MiB 177.62KiB 3.63KiB 0 0.109644 1.66MiB 134.96KiB 2.75KiB 0 0.0795192 False False
syslog_log2metric_humio_metrics 298.73KiB 2.35 100.00% 12.39MiB 530.41KiB 10.83KiB 0 0.041804 12.68MiB 586.47KiB 11.94KiB 0 0.045159 False False
syslog_splunk_hec_logs 383.57KiB 2.35 100.00% 15.97MiB 1.07MiB 22.24KiB 0 0.0668089 16.34MiB 810.43KiB 16.52KiB 0 0.0484184 False False
http_pipelines_blackhole_acks 20.36KiB 1.64 100.00% 1.22MiB 110.33KiB 2.25KiB 0 0.0886297 1.24MiB 72.66KiB 1.48KiB 0 0.0574314 False False
datadog_agent_remap_blackhole_acks 615.31KiB 0.99 100.00% 60.91MiB 4.73MiB 98.48KiB 0 0.0776413 61.51MiB 2.9MiB 60.71KiB 0 0.0471623 False False
splunk_hec_to_splunk_hec_logs_noack 13.16KiB 0.05 76.12% 23.83MiB 433.17KiB 8.85KiB 0 0.0177508 23.84MiB 333.73KiB 6.81KiB 0 0.0136687 False False
splunk_hec_indexer_ack_blackhole 4.26KiB 0.02 13.44% 23.75MiB 880.34KiB 17.91KiB 0 0.0361912 23.75MiB 868.4KiB 17.67KiB 0 0.0356941 False False
splunk_hec_to_splunk_hec_logs_acks -2.42KiB -0.01 7.76% 23.75MiB 865.34KiB 17.6KiB 0 0.0355737 23.75MiB 865.6KiB 17.61KiB 0 0.035588 False False
enterprise_http_to_http -2.17KiB -0.01 23.33% 23.85MiB 248.93KiB 5.08KiB 0 0.0101921 23.84MiB 257.26KiB 5.27KiB 0 0.0105342 False False
file_to_blackhole -30.89KiB -0.03 20.57% 95.33MiB 3.91MiB 81.09KiB 0 0.041026 95.3MiB 4.15MiB 86.38KiB 0 0.0435633 False False
http_to_http_json -42.65KiB -0.17 99.89% 23.85MiB 331.81KiB 6.77KiB 0 0.0135831 23.81MiB 543.77KiB 11.1KiB 0 0.022299 False False
datadog_agent_remap_blackhole -109.92KiB -0.18 65.86% 60.51MiB 4.4MiB 91.56KiB 0 0.0726356 60.4MiB 3.38MiB 70.43KiB 0 0.0559032 False False
fluent_elasticsearch -159.48KiB -0.2 100.00% 79.47MiB 53.02KiB 1.07KiB 0 0.000651336 79.32MiB 1.41MiB 28.98KiB 0 0.0177491 False False
http_to_http_noack -121.67KiB -0.5 100.00% 23.85MiB 250.69KiB 5.12KiB 0 0.0102646 23.73MiB 1.19MiB 24.7KiB 0 0.0499481 False False
splunk_hec_route_s3 -113.81KiB -0.6 91.10% 18.53MiB 2.29MiB 47.63KiB 0 0.123292 18.42MiB 2.25MiB 46.98KiB 0 0.12191 False False
datadog_agent_remap_datadog_logs -501.29KiB -0.8 100.00% 61.49MiB 861.59KiB 17.65KiB 0 0.0136811 61.0MiB 4.23MiB 88.04KiB 0 0.0693121 False False
datadog_agent_remap_datadog_logs_acks -596.96KiB -0.97 100.00% 59.84MiB 3.68MiB 76.84KiB 0 0.0614174 59.26MiB 4.43MiB 92.12KiB 0 0.0746691 False False
syslog_humio_logs -163.58KiB -0.97 100.00% 16.47MiB 532.98KiB 10.88KiB 0 0.0315968 16.31MiB 464.93KiB 9.52KiB 0 0.0278326 False False
http_to_http_acks -196.79KiB -1.1 60.35% 17.43MiB 7.73MiB 161.6KiB 0 0.443487 17.24MiB 7.98MiB 166.54KiB 0 0.462717 True True
socket_to_socket_blackhole -269.99KiB -1.12 100.00% 23.57MiB 275.89KiB 5.63KiB 0 0.0114294 23.3MiB 210.68KiB 4.3KiB 0 0.00882663 False False
http_text_to_http_json -645.37KiB -1.66 100.00% 37.91MiB 901.48KiB 18.4KiB 0 0.0232176 37.28MiB 881.97KiB 18.01KiB 0 0.023099 False False
syslog_regex_logs2metric_ddmetrics -240.81KiB -1.88 100.00% 12.53MiB 607.59KiB 12.38KiB 0 0.0473401 12.3MiB 595.53KiB 12.14KiB 0 0.0472876 False False
syslog_log2metric_splunk_hec_metrics -348.3KiB -1.9 100.00% 17.87MiB 494.52KiB 10.09KiB 0 0.0270186 17.53MiB 853.58KiB 17.37KiB 0 0.0475404 False False
http_pipelines_no_grok_blackhole -219.03KiB -1.98 100.00% 10.82MiB 159.0KiB 3.25KiB 0 0.0143438 10.61MiB 1.08MiB 22.58KiB 0 0.102239 False False
syslog_loki -315.45KiB -2.16 100.00% 14.24MiB 680.03KiB 13.92KiB 0 0.0466403 13.93MiB 961.91KiB 19.55KiB 0 0.0674326 False False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks sink: statsd Anything `statsd` sink related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify statsd sink
3 participants