Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify aws_kinesis_firehose source #14194

Closed
3 tasks done
Tracked by #13995
spencergilbert opened this issue Aug 31, 2022 · 3 comments
Closed
3 tasks done
Tracked by #13995

Verify aws_kinesis_firehose source #14194

spencergilbert opened this issue Aug 31, 2022 · 3 comments
Assignees
Labels
domain: observability Anything related to monitoring/observing Vector domain: sources Anything related to the Vector's sources source: aws_kinesis_firehose Anything `aws_kinesis_firehose` source related

Comments

@spencergilbert
Copy link
Contributor

spencergilbert commented Aug 31, 2022

  • Verify internal event processing metrics are tested via assert_X_compliance test helpers
  • Update component_discarded_events_total to match the new instrumentation spec by adding reason to the emitted logs, and intentional to emitted logs and metrics
  • Verify that the component correctly emits the correct error events per the component spec
@spencergilbert spencergilbert self-assigned this Aug 31, 2022
@spencergilbert spencergilbert added source: aws_kinesis_firehose Anything `aws_kinesis_firehose` source related domain: observability Anything related to monitoring/observing Vector domain: sources Anything related to the Vector's sources labels Aug 31, 2022
@spencergilbert
Copy link
Contributor Author

Source appears to only drop events when failing a send, otherwise we don't receive events at all.

@jszwedko
Copy link
Member

jszwedko commented Sep 1, 2022

@spencergilbert did you verify the error events too? That is, the ones that emit component_errors_total (or if any are missing).

@spencergilbert
Copy link
Contributor Author

@spencergilbert did you verify the error events too? That is, the ones that emit component_errors_total (or if any are missing).

Yep, the two "custom" internal events that emit errors have all the properties from the spec 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector domain: sources Anything related to the Vector's sources source: aws_kinesis_firehose Anything `aws_kinesis_firehose` source related
Projects
None yet
Development

No branches or pull requests

2 participants