Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify aws_kinesis_firehose sink #14203

Closed
1 of 3 tasks
Tracked by #13995
spencergilbert opened this issue Aug 31, 2022 · 0 comments · Fixed by #14478
Closed
1 of 3 tasks
Tracked by #13995

Verify aws_kinesis_firehose sink #14203

spencergilbert opened this issue Aug 31, 2022 · 0 comments · Fixed by #14478
Assignees
@spencergilbert
Labels
domain: observability Anything related to monitoring/observing Vector domain: sinks Anything related to the Vector's sinks sink: aws_kinesis_firehose Anything `aws_kinesis_firehose` sink related

Comments

@spencergilbert
Copy link
Contributor

spencergilbert commented Aug 31, 2022 •
edited
Loading

  • Verify internal event processing metrics are tested via assert_X_compliance test helpers
  • Update component_discarded_events_total to match the new instrumentation spec by adding reason to the emitted logs, and intentional to emitted logs and metrics
  • Verify that the component correctly emits the correct error events per the component spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spencergilbert spencergilbert

Labels
domain: observability Anything related to monitoring/observing Vector domain: sinks Anything related to the Vector's sinks sink: aws_kinesis_firehose Anything `aws_kinesis_firehose` sink related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(aws_kinesis_firehose sink): File cleanup and use SinkRequestBuildError vectordotdev/vector
1 participant
@spencergilbert