-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constructor Syntax #47
Comments
Removed Type-Defect label. |
This comment was originally written by [email protected] Added Triaged label. |
This comment was originally written by [email protected] I was put off by this realization too. Using the constructor name couples the implementation lexically to the class name, which makes things much harder to change or move around. I think it's fair to say that nobody really wants to be forced to use an IDE to be productive with this language. I've never seen the new keyword used as the constructor name before, but given that it's already reserved and invalid in the given context in the grammar, it might make a neat intuitive name. Of course, that limits the language in the future, so maybe not such a good idea. |
This comment was originally written by [email protected] VB.NET uses "New" as the name of the constructor. It generally works well. Dart already provides a special syntax for referencing the superclass's constructor("super(args)"), and doesn't appear to allow a constructor to call other overloads of the constructor, so I don't see this having any negative effects on the grammar. |
This comment was originally written by [email protected] I forgot to add one thing, which might be obvious, but I think it's worth mentioning. The syntax becomes especially bad if a class has a long name; code will become (unnecessarily) cluttered with copies of that long name. class FairlyDescriptiveClassName { |
This comment was originally written by [email protected] And that is supposed to be readable? |
The goal here is to make the code instantly familiar to the mainstream programmer. Doing roughly what the C++, Java etc. have done for 30 years is a conservative choice, and a deliberate one. If you need to rename the class without an IDE, changing the constructor name is probably the least of your problems. In any case, that's easily handled with regex search/replace. As for coupling - the built-in factory support means that you can change the implementation you are using without changing the call sites. All in all, the constructor scheme in Dart is one of its strengths, solving a very difficult issue in a way that looks familiar but does not suffer from the standard problems constructors have. We could make some adjustments as we see the experience in larger scale use, but don't count on it. Set owner to @gbracha. |
This comment was originally written by [email protected] I am one of those Java Developers who absolutely hate the Java way, initialize() I love Dart, so far, but think the right thing to do is the Ruby way in this case. Why use New which is so confusing with all the other syntax highlighted 'new's in code. Just my 2 cents. |
This comment was originally written by [email protected] Of course, a 'New' can be distinguished from 'new' in color syntax highlighting, Why don't we all use Eclipse to "easily handle refactoring constructors"? |
This comment was originally written by @MarkBennett I am also in favour of adopting a standardized constructor keyword, rather than re-using the class name. When I first began using Java I remember the constructor syntax to be confusing and counterintuitive as you'd first need to find the name of a class, then search for it's constructor. Using a standard constructor name reduces cognitive loading, parser complexity and makes the language more accessible to plain text IDE's. Though there are examples of languages using the constructor syntax Dart has selected, there are as many examples of languages using a standardized constructor name instead so the argument of which is more "familiar" to a "mainstream" programmer is rather dubious. There are many other places where Dart welcomes Java and C++ developers, however this is one case were it may be better to take inspiration from more modern languages like C#, Python and Ruby. The goal of Dart is not to re-implement Java in the browser, but to be familiar and accessible to all developers with Java experience or otherwise. Using a common constructor doesn't present a significant impediment to existing Java developers, and will make the language more welcoming to new developers. |
This comment was originally written by [email protected] As another day-job Java programmer I have to say this really isn't TOO big of a deal with the built in factory support, but I'd also rather have something consistent like init/new/create whatever. Then again, I wish we could just get rid of the new operator all together and just be able to do ClassName.new() or init() etc. I think that would reveal more to the dev that constructors are composable in dart and not really different from any other class method. I'm very wary these features that look 'familiar' even though they're really not. IMO it's far more confusing to have something that looks familiar but in reality is not, than to have something that looks different (and not really very different) which implies (correctly) that it works differently and therefore it's easier to understand the differences. |
This comment was originally written by [email protected] new instead of $className? class Point { becomes class Point { |
This comment was originally written by [email protected] I would keep the discussion open to "New" or "new" or "initialize" instead of $className. The advantage of "new" or "New" is that they are shorter than "initialize". "Init" could be used, but is nice to leave for other programmer uses besides constructors. A disadvantage of "new" is possible confusion (including syntax highlighting, with the normal use of "new" creating new instances. So this class Point { becomes class Point { or class Point { The latter is my favorite as it avoids confusion of constructor and new instances, |
This comment was originally written by [email protected] I think Scala uses "this" and Gosu uses "construct". I would vote for "initialize", but let the Dart team pick, if they are willing, |
This comment was originally written by [email protected]
You still have to do that on every place you actually instantiate that class. Not having to rename constructors looks like a very minor issue to me. If the Dart team decides to actually do this, I'd vote for using 'new', because it automatically eliminates any causes of ambiguity and confusion while not adding another keyword. 'this' would look weird when having a lot of initializing formals and other suggestions ('initialize' etc.) are valid method names. |
This comment was originally written by [email protected]
I would agree this is very minor compared with the issue of public/private access But I would agree that you have mentioned a good "advantage" for the use of "new" or "New", (avoiding adding a keyword), and it would be fine if Dart chooses "new". I would still vote for "initialize", to avoid confusion over new instance variables, and consider adding another "keyword" a very minor loss for the important purpose of getting constructors right (following in the Ruby tradition). Either way is better than classname constructors. |
This comment was originally written by [email protected]
This is totally off topic, but I will say it anyway: I think that Dart is the first mainstream-ish language that gets constructors right -- by adding factories. Syntax isn't that important, really. |
This comment was originally written by [email protected]
If I spend extra time fixing renamed class constructors, isn't that important? |
This comment was originally written by [email protected]
What extra time are we talking about? Like 0.1% of all the time needed to replace the class name on all other places? Oh and BTW: using 'initialize' would mean less duplication, but in some cases (the original poster uses a 'Point' class) longer code. Heh? :-) |
…_launcher, clock, crypto, csslib, dartdoc, html, http, http_multi_server, intl, package_config, pool, protobuf, pub_semver, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, term_glyph, test, test_descriptor, test_process, test_reflective_loader, watcher, web_socket_channel, yaml Revisions updated by `dart tools/rev_sdk_deps.dart`. bazel_worker (https://github.com/dart-lang/bazel_worker/compare/9f21e1d..b35c25e): b35c25e 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#66) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/ee7a253..76881df): 76881df 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#80) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/5082b3d..ba7d86b): ba7d86b 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#41) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/2712dda..f2f01e4): f2f01e4 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#37) clock (https://github.com/dart-lang/clock/compare/8a8231f..6b8b7bf): 6b8b7bf 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#41) crypto (https://github.com/dart-lang/crypto/compare/bf0c33b..f854f2f): f854f2f 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#138) csslib (https://github.com/dart-lang/csslib/compare/34203c0..d776535): d776535 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#156) dartdoc (https://github.com/dart-lang/dartdoc/compare/ce25524..9ed196f): 9ed196f1 2023-01-03 Sam Rawlins Move many test files to test_reflective_loader (#3284) html (https://github.com/dart-lang/html/compare/28fb8b9..3dd00b0): 3dd00b0 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#193) http (https://github.com/dart-lang/http/compare/38d5dd9..d434d42): d434d42 2023-01-03 Brian Quinlan Make it possible to use a custom CronetEngine with runWithClient (#843) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/e31c698..beb40a7): beb40a7 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#47) intl (https://github.com/dart-lang/intl/compare/59e7bff..c61fdd1): c61fdd1 2023-01-04 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#528) 2a5e3a2 2023-01-04 Copybara-Service Merge pull request #527 from mateendev3:patch-2 07a5847 2022-12-31 Mateen Mehmood Update date_format.dart package_config (https://github.com/dart-lang/package_config/compare/abb4aec..2e1a8ec): 2e1a8ec 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#128) pool (https://github.com/dart-lang/pool/compare/1ea5b03..713e631): 713e631 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#59) protobuf (https://github.com/dart-lang/protobuf/compare/1d1c92a..dd04535): dd04535 2023-01-04 Mahdi K. Fard Fix avoid_renaming_method_parameters linter warning. (#783) 4b1fc34 2023-01-04 Mahdi K. Fard Removes a non-existing lint rule. (#784) pub_semver (https://github.com/dart-lang/pub_semver/compare/1723111..3946e33): 3946e33 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#76) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/8d8078f..e5f9564): e5f9564 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#31) source_maps (https://github.com/dart-lang/source_maps/compare/b031e2c..d995912): d995912 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#70) source_span (https://github.com/dart-lang/source_span/compare/d1d47e5..72d5c55): 72d5c55 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#89) sse (https://github.com/dart-lang/sse/compare/2de27fe..3c37edb): 3c37edb 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#73) stack_trace (https://github.com/dart-lang/stack_trace/compare/cf3562e..c08ee90): c08ee90 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#125) stream_channel (https://github.com/dart-lang/stream_channel/compare/9143047..0a7800a): 0a7800a 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#83) term_glyph (https://github.com/dart-lang/term_glyph/compare/822cd5b..2bf4594): 2bf4594 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#30) test (https://github.com/dart-lang/test/compare/8235a25..3415089): 34150897 2023-01-03 dependabot[bot] Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (#1838) 5f01dd97 2023-01-03 dependabot[bot] Bump github/codeql-action from 1.0.26 to 2.1.37 (#1839) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/13dbc20..b73c691): b73c691 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#46) test_process (https://github.com/dart-lang/test_process/compare/1774aa7..62ea2ba): 62ea2ba 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#37) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/52b6753..cf58259): cf58259 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#43) watcher (https://github.com/dart-lang/watcher/compare/3259107..2e0db71): 2e0db71 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#132) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/a90e740..ebd0fe9): ebd0fe9 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#244) yaml (https://github.com/dart-lang/yaml/compare/f699275..02be51e): 02be51e 2023-01-03 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.2.0 (#133) Change-Id: I56af76e89a75b0712b290ea154f606781183bec7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278368 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
…s, markdown, matcher, mockito, path, pool, source_map_stack_trace, sse, stream_channel, string_scanner, test, test_reflective_loader, tools, typed_data, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. cli_util (https://github.com/dart-lang/cli_util/compare/91747f7..6c318c2): 6c318c2 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#81) df83fb5 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#80) collection (https://github.com/dart-lang/collection/compare/0d0e184..30fd0f8): 30fd0f8 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#277) dartdoc (https://github.com/dart-lang/dartdoc/compare/0746cda..9be04e0): 9be04e0c 2023-03-28 Jonas Finnemann Jensen Allow ID attributes on headings when running with --sanitize-html (#3358) 8785dd24 2023-03-27 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#3377) 0944fa32 2023-03-27 dependabot[bot] Bump github/codeql-action from 2.2.6 to 2.2.9 (#3379) e318d34f 2023-03-27 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#3378) ffi (https://github.com/dart-lang/ffi/compare/32f5eef..04fa38a): 04fa38a 2023-04-03 Daco Harkes test zero termination of Utf8 string (#147) eb93bbb 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#188) 2a6b643 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#189) intl (https://github.com/dart-lang/intl/compare/fca552f..a958db0): a958db0 2023-03-29 Googler Internal change json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/0280ac6..aea3bea): aea3bea 2023-03-28 Kevin Moore Fix analysis, bump min SDK to 2.19 (#93) lints (https://github.com/dart-lang/lints/compare/dfded5e..f09399a): f09399a 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#110) 9581bab 2023-03-25 Parker Lougheed Fix 'recommended' spelling in README (#109) c92e1ca 2023-03-23 Michael Thomsen Update README.md (#108) 7134608 2023-02-01 dependabot[bot] Bump actions/checkout from 3.2.0 to 3.3.0 (#98) markdown (https://github.com/dart-lang/markdown/compare/ecbffa9..d437c85): d437c85 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#529) 3550fe6 2023-04-01 dependabot[bot] Bump subosito/flutter-action from 2.8.0 to 2.10.0 (#528) d1b7907 2023-04-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#527) 0daf231 2023-03-31 le.chang Footnote support (#441) b96bc08 2023-03-30 Jonas Finnemann Jensen Prepare a release of 7.0.2 (#526) matcher (https://github.com/dart-lang/matcher/compare/dc310d9..61f4347): 61f4347 2023-03-21 Nate Bosch Prepare to publish (#214) mockito (https://github.com/dart-lang/mockito/compare/ed5bd84..28e8eda): 28e8eda 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 ccb9abf 2023-04-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 65ee0c4 2023-03-23 Nate Bosch Expand pub constraint on test_api (#615) e6ea7ad 2023-03-23 Nate Bosch GitHub Sync (#614) path (https://github.com/dart-lang/path/compare/24b58a2..cd37179): cd37179 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#139) pool (https://github.com/dart-lang/pool/compare/694cfd8..338bfb4): 338bfb4 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#67) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/45ea368..08a81a8): 08a81a8 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#37) 4cbe06e 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#36) sse (https://github.com/dart-lang/sse/compare/8c03b73..8c3efdc): 8c3efdc 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#80) e35336a 2023-04-02 dependabot[bot] Bump nanasess/setup-chromedriver from 1.1.0 to 2.0.0 (#81) stream_channel (https://github.com/dart-lang/stream_channel/compare/a20ccd4..fe0f5e4): fe0f5e4 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#89) string_scanner (https://github.com/dart-lang/string_scanner/compare/29e471e..f7a656f): f7a656f 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#56) fe8c301 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#55) test (https://github.com/dart-lang/test/compare/cc0598b..a01b185): a01b185e 2023-03-30 Nate Bosch More smoothly handle missing compiler info (#1980) b24b4668 2023-03-27 Daco Harkes Support native assets (#1975) c3828267 2023-03-23 Nate Bosch Prepare to publish (#1974) 9035bba8 2023-03-21 Parker Lougheed Use deps.dev for OpenSSF scorecard results link (#1976) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/c4c2d5c..a85a930): a85a930 2023-04-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#46) 27bc418 2023-04-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#47) tools (https://github.com/dart-lang/tools/compare/fb2dada..d40ca93): d40ca93 2023-04-03 dependabot[bot] Bump actions/labeler from 4.0.2 to 4.0.3 (#66) 4185d6d 2023-04-03 dependabot[bot] Bump coverallsapp/github-action from 1.2.4 to 2.0.0 (#65) b14d5be 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#64) typed_data (https://github.com/dart-lang/typed_data/compare/f858046..d85363d): d85363d 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#62) 0f57d9b 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#63) webdev (https://github.com/dart-lang/webdev/compare/c2c8b17..b139649): b139649e 2023-03-31 Elliott Brooks Don't show non-instantiated variables (#2061) 8437f60a 2023-03-31 Elliott Brooks Move project-specific getters to `TestProject` instead of `TestContext` (#2052) 652e040c 2023-03-30 Elliott Brooks Provide an app entrypoint to DWDS (#2047) 0afc9eb4 2023-03-30 Elliott Brooks Add Dart Code Metrics (#2055) 5fcbb803 2023-03-29 Elliott Brooks Apply `trailing-comma` lint (#2054) 5bd21384 2023-03-28 Elliott Brooks Skip failing webdev integration_test cases (#2051) 2d8e9c23 2023-03-24 Elliott Brooks (she/her) Adds a script for the release steps of `dwds` and `webdev` (#2049) afee8c74 2023-03-23 Elliott Brooks (she/her) Reset `webdev`, `dwds`, `test_common` after publishing (#2048) 4122b234 2023-03-22 Devon Carew update to the latest mono_repo generated CI (#2044) 2b6e9182 2023-03-22 Elliott Brooks (she/her) Prepare Webdev for `3.0.3` release (#2046) c3cbd89b 2023-03-22 Elliott Brooks (she/her) Prepare DWDS for 18.0.2 release (#2045) bb22b3a0 2023-03-22 Anna Gringauze Make debugger skip same locations in dart during stepping. (#2043) b9499819 2023-03-20 Anna Gringauze Prepare for variable names changes due to patterns support in DDC (#2042) Change-Id: I5b8d591d1b906338564cf008f935b17f85ed2813 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292922 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
… dartdoc, html, term_glyph, test, webdev, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. boolean_selector (https://github.com/dart-lang/boolean_selector/compare/28dc03d..9fd3bae): 9fd3bae 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#44) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/ba4e028..ed11524): ed11524 2023-04-04 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#40) clock (https://github.com/dart-lang/clock/compare/93d9f56..6b2004c): 6b2004c 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#47) crypto (https://github.com/dart-lang/crypto/compare/8a03816..1cb1528): 1cb1528 2023-04-04 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#142) csslib (https://github.com/dart-lang/csslib/compare/5836863..44bfbe3): 44bfbe3 2023-04-04 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#176) dartdoc (https://github.com/dart-lang/dartdoc/compare/1a7952b..a0755f5): a0755f5f 2023-04-04 Janice Collins Fix example modifiers (#3383) html (https://github.com/dart-lang/html/compare/57b747d..0438b26): 0438b26 2023-04-05 Oleh Prypin Dart 3 compatibility: turn classes into mixins (#208) term_glyph (https://github.com/dart-lang/term_glyph/compare/f6856e2..b110501): b110501 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#35) test (https://github.com/dart-lang/test/compare/8ea4298..7832931): 78329319 2023-04-04 Devon Carew regenerate mono_repo (#1988) webdev (https://github.com/dart-lang/webdev/compare/e887316..0a2804b): 0a2804bd 2023-04-04 Elliott Brooks Fix DevTools test (#2071) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/386fd33..5f392a1): 5f392a1 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#48) Change-Id: Ib9ee434634d3116db7ada89a4c31a566a28b5600 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293744 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]> Auto-Submit: Devon Carew <[email protected]>
…ctor, browser_launcher, file, mockito, tools, dartdoc Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc to 0cf21c15d7346a81838bd1c56677d88d690887f5 args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2): f0f6cd2 2023-05-12 Devon Carew blast_repo fixes (#243) async (https://github.com/dart-lang/async/compare/0f368d3..d744058): d744058 2023-05-12 Devon Carew blast_repo fixes (#242) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f): d9b389f 2023-05-12 Devon Carew blast_repo fixes (#73) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4): e717ad4 2023-05-12 Devon Carew blast_repo fixes (#90) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..23e08e0): 23e08e0 2023-05-12 Devon Carew blast_repo fixes (#47) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315): 40e4315 2023-05-12 Devon Carew blast_repo fixes (#45) file (https://github.com/google/file.dart/compare/e90e5ed..f05f5db): f05f5db 2023-05-15 James D. Lin Make MemoryFile.openRead and _ChrootFile.openRead return Stream<List<int>> again (#217) f2f3076 2023-05-12 Ross Wang MemoryFileSystem addStream onError (#220) 5e76f74 2023-05-12 James D. Lin Fix MemoryFileSystem to treat an empty path as non-existent (#213) 7941466 2023-05-12 James D. Lin Make `FileSystem.isLink` actually work (#214) mockito (https://github.com/dart-lang/mockito/compare/51a7728..b14d571): b14d571 2023-05-15 Googler Fix for InvalidType tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca): 49da4ca 2023-05-12 Polina Cherkasova Add memory events. (#92) Change-Id: I582320bb68ff5f48e9969cef906073e25ad6b875 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303380 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
…ean_selector, browser_launcher, file, mockito, tools, dartdoc" This reverts commit e3ba855. Reason for revert: b/282823291, breaks Flutter tests at least on Android. Original change's description: > [deps] rev args, async, bazel_worker, benchmark_harness, boolean_selector, browser_launcher, file, mockito, tools, dartdoc > > Revisions updated by `dart tools/rev_sdk_deps.dart`. > > dartdoc to 0cf21c15d7346a81838bd1c56677d88d690887f5 > > args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2): > f0f6cd2 2023-05-12 Devon Carew blast_repo fixes (#243) > > async (https://github.com/dart-lang/async/compare/0f368d3..d744058): > d744058 2023-05-12 Devon Carew blast_repo fixes (#242) > > bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f): > d9b389f 2023-05-12 Devon Carew blast_repo fixes (#73) > > benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4): > e717ad4 2023-05-12 Devon Carew blast_repo fixes (#90) > > boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..23e08e0): > 23e08e0 2023-05-12 Devon Carew blast_repo fixes (#47) > > browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315): > 40e4315 2023-05-12 Devon Carew blast_repo fixes (#45) > > file (https://github.com/google/file.dart/compare/e90e5ed..f05f5db): > f05f5db 2023-05-15 James D. Lin Make MemoryFile.openRead and _ChrootFile.openRead return Stream<List<int>> again (#217) > f2f3076 2023-05-12 Ross Wang MemoryFileSystem addStream onError (#220) > 5e76f74 2023-05-12 James D. Lin Fix MemoryFileSystem to treat an empty path as non-existent (#213) > 7941466 2023-05-12 James D. Lin Make `FileSystem.isLink` actually work (#214) > > mockito (https://github.com/dart-lang/mockito/compare/51a7728..b14d571): > b14d571 2023-05-15 Googler Fix for InvalidType > > tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca): > 49da4ca 2023-05-12 Polina Cherkasova Add memory events. (#92) > > Change-Id: I582320bb68ff5f48e9969cef906073e25ad6b875 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303380 > Reviewed-by: Konstantin Shcheglov <[email protected]> > Commit-Queue: Devon Carew <[email protected]> Change-Id: Ifc2aa278a47a4060f2be28c1950084eb0c2de812 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303720 Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Ilya Yanok <[email protected]>
…ctor, browser_launcher, characters, cli_util, clock, collection, crypto, dartdoc, leak_tracker, lints Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2): f0f6cd2 2023-05-12 Devon Carew blast_repo fixes (#243) async (https://github.com/dart-lang/async/compare/0f368d3..d744058): d744058 2023-05-12 Devon Carew blast_repo fixes (#242) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f): d9b389f 2023-05-12 Devon Carew blast_repo fixes (#73) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4): e717ad4 2023-05-12 Devon Carew blast_repo fixes (#90) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..3a1c982): 3a1c982 2023-05-15 Devon Carew Update README.md (#48) 23e08e0 2023-05-12 Devon Carew blast_repo fixes (#47) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315): 40e4315 2023-05-12 Devon Carew blast_repo fixes (#45) characters (https://github.com/dart-lang/characters/compare/2af6783..3ef8883): 3ef8883 2023-05-15 Devon Carew blast_repo fixes (#82) cli_util (https://github.com/dart-lang/cli_util/compare/7234f17..5a49947): 5a49947 2023-05-15 Devon Carew blast_repo fixes (#83) clock (https://github.com/dart-lang/clock/compare/6b9df3e..fe85908): fe85908 2023-05-15 Devon Carew blast_repo fixes (#51) collection (https://github.com/dart-lang/collection/compare/6abff47..db2da48): db2da48 2023-05-15 Devon Carew blast_repo fixes (#288) crypto (https://github.com/dart-lang/crypto/compare/4e9dde1..216931a): 216931a 2023-05-15 Devon Carew blast_repo fixes (#149) dartdoc (https://github.com/dart-lang/dartdoc/compare/d01ddc5..2952f6b): 2952f6bf 2023-05-16 Sam Rawlins Simplify ToolConfiguration and other options code (#3414) 0cf21c15 2023-05-12 Janice Collins Extract fileName / fileType from ModelElement, LibraryContainer into FileStructure (#3413) 2ae78bcc 2023-05-12 Sam Rawlins Split sidebars out into separate HTML files (#3384) f00d0443 2023-05-11 Janice Collins Housekeeping: language version 3.0, analyzer deprecations, pubspec update (#3412) 370477d2 2023-05-10 dependabot[bot] Bump github/codeql-action from 2.3.2 to 2.3.3 (#3410) e8c5de44 2023-05-08 Janice Collins Begin extracting file structure information from ModelElement (#3408) 24af8a11 2023-05-04 Janice Collins Add a hideConstantImplementations dartdoc directive (#3398) 078d42fd 2023-05-03 Janice Collins Change language feature wording based on review in #3401 (#3405) 31088c1b 2023-05-03 dependabot[bot] Bump github/codeql-action from 2.2.12 to 2.3.2 (#3403) 60055b4e 2023-05-03 Sam Rawlins Update validate-sdk-docs task to allow 20 libs (#3404) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/bc7f604..8ae200a): 8ae200a 2023-05-15 Polina Cherkasova - (#62) lints (https://github.com/dart-lang/lints/compare/17276ec..72f107a): 72f107a 2023-05-15 Devon Carew blast_repo fixes (#120) 6732fbc 2023-05-15 Devon Carew blast_repo fixes (#119) Change-Id: Ibbb1fcc530da01653fe325bdcf77f1c764887a81 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303783 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
…wn, mockito, native, pool, pub_semver, shelf, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_reflective_loader, tools Revisions updated by `dart tools/rev_sdk_deps.dart`. clock (https://github.com/dart-lang/clock/compare/fe85908..21caac1): 21caac1 2023-05-21 Kevin Moore Update formatting (#52) collection (https://github.com/dart-lang/collection/compare/db2da48..f949b09): f949b09 2023-05-18 Graciliano Monteiro Passos `CanonicalizedMap`: new `copy`, `toMap` and `toMapOfCanonicalKeys` methods (#261) file (https://github.com/google/file.dart/compare/f05f5db..5d9a602): 5d9a602 2023-05-19 Jacob MacDonald remove no longer necessary override (#223) e4eebba 2023-05-19 Jacob MacDonald release version 7.0.0 (#222) glob (https://github.com/dart-lang/glob/compare/30f6aba..109121d): 109121d 2023-05-19 Jacob MacDonald allow latest file, update to latest dart_flutter_team_lints (#78) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/800843e..b2ed6bd): b2ed6bd 2023-05-22 Devon Carew blast_repo fixes (#97) logging (https://github.com/dart-lang/logging/compare/fa2486d..7ba155a): 7ba155a 2023-05-22 Devon Carew blast_repo fixes (#141) markdown (https://github.com/dart-lang/markdown/compare/b951454..bd6ae8d): bd6ae8d 2023-05-22 Zhiguang Chen Table should be able to interrupt other blocks (#545) 0bc9d0e 2023-05-21 Devon Carew blast_repo fixes (#544) mockito (https://github.com/dart-lang/mockito/compare/28f174f..7c6d309): 7c6d309 2023-05-18 Devon Carew blast_repo fixes 2c1b429 2023-05-19 Ilya Yanok Extend using run-time dummy values to Futures native (https://github.com/dart-lang/native/compare/3d89166..00832c9): 00832c9 2023-05-22 Daco Harkes [c_compiler] Increase test timeout on Windows (#47) 06408e7 2023-05-22 Daco Harkes [native_assets_cli] Fix example repostory url (#42) c614277 2023-05-19 dependabot[bot] Bump nttld/setup-ndk (#45) 67a2d20 2023-05-19 dependabot[bot] Bump actions/labeler from 4.0.2 to 4.0.3 (#44) 270700e 2023-05-18 Devon Carew blast_repo fixes (#43) pool (https://github.com/dart-lang/pool/compare/86b4f43..a10a0f9): a10a0f9 2023-05-22 Devon Carew blast_repo fixes (#69) pub_semver (https://github.com/dart-lang/pub_semver/compare/6dd1908..c034352): c034352 2023-05-22 Devon Carew blast_repo fixes (#87) shelf (https://github.com/dart-lang/shelf/compare/8793687..e7bab95): e7bab95 2023-05-19 Devon Carew blast_repo fixes (#356) sse (https://github.com/dart-lang/sse/compare/11ba89e..bfcbcd7): bfcbcd7 2023-05-19 Devon Carew blast_repo fixes (#84) stack_trace (https://github.com/dart-lang/stack_trace/compare/36fa0e1..86f7e30): 86f7e30 2023-05-19 Devon Carew blast_repo fixes (#132) stream_channel (https://github.com/dart-lang/stream_channel/compare/a862e41..b1d3384): b1d3384 2023-05-19 Devon Carew blast_repo fixes (#91) string_scanner (https://github.com/dart-lang/string_scanner/compare/3bc6e54..6bb314f): 6bb314f 2023-05-19 Devon Carew blast_repo fixes (#58) term_glyph (https://github.com/dart-lang/term_glyph/compare/3de5f1b..9d8956f): 9d8956f 2023-05-19 Devon Carew blast_repo fixes (#38) test (https://github.com/dart-lang/test/compare/cdedf40..309596e): 309596e4 2023-05-22 Devon Carew blast_repo fixes (#2019) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/d1b763f..40d61b1): 40d61b1 2023-05-19 Devon Carew blast_repo fixes (#49) tools (https://github.com/dart-lang/tools/compare/49da4ca..0eb4141): 0eb4141 2023-05-18 Elias Yishak Update usage guide for onboarding users (#90) Change-Id: Id462318b1ea33bb1a6dea3c426d5306048a2cceb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304765 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>
…ctor, browser_launcher, characters, cli_util, clock, collection, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, leak_tracker, lints, logging, markdown, matcher, mime, mockito, native, package_config, path, pool, protobuf, pub_semver, shelf, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, typed_data, usage, watcher, web_socket_channel, webdev, yaml Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/a9543c0..da56b18): da56b18 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#249) async (https://github.com/dart-lang/async/compare/a506993..b65622a): b65622a 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#247) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/f7b714e..c29d162): c29d162 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#77) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/e717ad4..fde73cb): fde73cb 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#91) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/3a1c982..303635d): 303635d 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#49) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/40e4315..27ec600): 27ec600 2023-07-05 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#46) dd8df9c 2023-07-05 Devon Carew update formatting for recent lints (#47) characters (https://github.com/dart-lang/characters/compare/3ef8883..ec844db): ec844db 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#84) cli_util (https://github.com/dart-lang/cli_util/compare/5a49947..9b7ce78): 9b7ce78 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#84) clock (https://github.com/dart-lang/clock/compare/21caac1..263e508): 263e508 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#54) collection (https://github.com/dart-lang/collection/compare/a37bd51..db343da): db343da 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#295) convert (https://github.com/dart-lang/convert/compare/9a387f0..79ee174): 79ee174 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#84) crypto (https://github.com/dart-lang/crypto/compare/216931a..8b704c6): 8b704c6 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#150) csslib (https://github.com/dart-lang/csslib/compare/be2e11e..7e91228): 7e91228 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#187) dartdoc (https://github.com/dart-lang/dartdoc/compare/c2ed703..2522559): 25225596 2023-06-29 Sam Rawlins Migrate some simple tasks to a simple package:args command (#3456) ecosystem (https://github.com/dart-lang/ecosystem/compare/19fa443..b34db4f): b34db4f 2023-07-10 Moritz Allow empty coverage (#128) 5944328 2023-07-04 Moritz Prepare for publish (#127) c0701c9 2023-07-04 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#122) 9bf3a10 2023-07-03 Moritz Fix bug by switching `reduce` to `fold` (#126) fdfa528 2023-07-01 dependabot[bot] Bump actions/cache from 3.2.6 to 3.3.1 (#121) 238444c 2023-07-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.3 (#123) ca1e1ae 2023-06-30 Moritz Add coverage workflow (#119) cf02b4a 2023-06-30 Lasse R.H. Nielsen Make Changelog class eagerly load and parse file. (#120) ffi (https://github.com/dart-lang/ffi/compare/f582ca0..f01dfca): f01dfca 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#199) fixnum (https://github.com/dart-lang/fixnum/compare/d9b9a2a..00fa120): 00fa120 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#113) glob (https://github.com/dart-lang/glob/compare/109121d..5b24393): 5b24393 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#79) html (https://github.com/dart-lang/html/compare/b3b820b..4060496): 4060496 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#218) 8cb99e4 2023-07-01 Devon Carew address new analysis issues (#219) http (https://github.com/dart-lang/http/compare/d68081f..c148a3a): c148a3a 2023-07-07 Alex James Java http BaseClient implementation (#980) 474999f 2023-07-05 Brian Quinlan Document that the network entitlement is required when running in the macOS sandbox (#979) 98e4112 2023-07-05 Brian Quinlan Fix a bug where ...WebSocketClosed had two different initializer signatures (#981) 9833a20 2023-07-05 Brian Quinlan Support Steam<List<int>> as a provider of request data (#975) d3e78a0 2023-07-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#976) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/a209cd5..aa128cf): aa128cf 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#56) http_parser (https://github.com/dart-lang/http_parser/compare/19466c0..c14fbf6): c14fbf6 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#75) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/73467f3..509f71e): 509f71e 2023-07-05 Nate Bosch Fix the example to act as a server (#100) d80cbd0 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#99) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/c75b0a7..85bd7fb): 85bd7fb 2023-07-05 Polina Cherkasova - (#87) lints (https://github.com/dart-lang/lints/compare/89f9519..e03dc04): e03dc04 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#138) logging (https://github.com/dart-lang/logging/compare/f2fe2ac..5214987): 5214987 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#144) markdown (https://github.com/dart-lang/markdown/compare/4674d09..b4bdde2): b4bdde2 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#549) matcher (https://github.com/dart-lang/matcher/compare/7e10117..ce8f409): ce8f409 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#225) mime (https://github.com/dart-lang/mime/compare/2444840..bdb66bd): bdb66bd 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#99) mockito (https://github.com/dart-lang/mockito/compare/974226e..451f756): 451f756 2023-07-10 Nate Bosch Add example of mocking callbacks c13496c 2023-07-05 Googler Rollback of "Use `FunctionTypedElement.type` while generating method overrides" 60e619a 2023-07-05 Ilya Yanok Use `FunctionTypedElement.type` while generating method overrides 93b69ef 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#669) a926a63 2023-06-30 Ilya Yanok Add a note on only running codegen on files under `test/` by default 9f40189 2023-06-30 Ilya Yanok Require analyzer 5.12.0 native (https://github.com/dart-lang/native/compare/e12d3e6..de1b0cc): de1b0cc 2023-07-10 Daco Harkes [c_compiler] Pass the correct SDK for iOS simulator builds (#77) 21d7270 2023-07-01 dependabot[bot] Bump coverallsapp/github-action from 2.1.2 to 2.2.0 (#72) 23a9b62 2023-07-01 dependabot[bot] Bump nttld/setup-ndk (#74) 44073a8 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#75) 6f01604 2023-07-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#73) package_config (https://github.com/dart-lang/package_config/compare/203de20..be0c441): be0c441 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#138) path (https://github.com/dart-lang/path/compare/592505f..282dd18): 282dd18 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#147) pool (https://github.com/dart-lang/pool/compare/c6b1b2c..7700102): 7700102 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#72) protobuf (https://github.com/dart-lang/protobuf/compare/7bebbc6..a912f76): a912f76 2023-07-04 Ömer Sinan Ağacan Add more message set tests, fix a bug (#859) pub_semver (https://github.com/dart-lang/pub_semver/compare/3930557..028b435): 028b435 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#90) shelf (https://github.com/dart-lang/shelf/compare/ce379aa..bd59ead): bd59ead 2023-07-06 Kevin Moore router_generator: allow latest pkg:analyzer, request Dart 3 (#368) bebc801 2023-07-06 Jonas Finnemann Jensen Fix 244 (#268) 1617efa 2023-07-02 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#366) c037bb6 2023-07-02 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#365) 1ae4d4e 2023-07-01 Devon Carew address a new lint (#367) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/b83af01..16e54fd): 16e54fd 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#40) source_maps (https://github.com/dart-lang/source_maps/compare/58eef30..97c4833): 97c4833 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#80) source_span (https://github.com/dart-lang/source_span/compare/4dc78fb..37735ae): 37735ae 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#99) sse (https://github.com/dart-lang/sse/compare/bfcbcd7..e241085): e241085 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#85) stack_trace (https://github.com/dart-lang/stack_trace/compare/8b2046e..4ddd86d): 4ddd86d 2023-07-05 Slava Egorov Prepare 1.11.1 release (#137) d3e4c4d 2023-07-04 Slava Egorov Use awaiter-link pragma to guide VM's builtin awaiter stack unwinding (#135) 44aafa3 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#136) stream_channel (https://github.com/dart-lang/stream_channel/compare/34804a1..e54234f): e54234f 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#93) string_scanner (https://github.com/dart-lang/string_scanner/compare/6bb314f..35657e2): 35657e2 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#59) term_glyph (https://github.com/dart-lang/term_glyph/compare/4daa34e..423700a): 423700a 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#40) test (https://github.com/dart-lang/test/compare/021667a..3429712): 3429712b 2023-07-06 Nate Bosch Drop usage of window.testRunner (#2059) dc6b8236 2023-06-29 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.5.3 (#2051) b6dc3f8d 2023-06-29 dependabot[bot] Bump dart-lang/setup-dart from 1.3.0 to 1.5.0 (#2052) 5fa2572f 2023-06-29 Jacob MacDonald regenerate mono_repo with the latest (#2055) 56584627 2023-06-29 dependabot[bot] Bump github/codeql-action from 2.3.5 to 2.20.1 (#2053) 050fe2d6 2023-06-29 dependabot[bot] Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (#2054) ba6ccfc2 2023-06-29 Devon Carew config dependabot to send daily PRs for major version bumps (#2050) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/be7ce07..54a4c59): 54a4c59 2023-07-03 Devon Carew update formatting for recent lints (#54) test_process (https://github.com/dart-lang/test_process/compare/5ff2122..b360784): b360784 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#46) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/40d61b1..0bfaad9): 0bfaad9 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#50) tools (https://github.com/dart-lang/tools/compare/8db0aa1..af38b2b): af38b2b 2023-07-02 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#119) 8b8ccab 2023-07-01 Devon Carew update formatting based on the recent lints (#121) 30b50ff 2023-07-01 dependabot[bot] Bump coverallsapp/github-action from 2.1.2 to 2.2.0 (#118) 74979c1 2023-07-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#120) typed_data (https://github.com/dart-lang/typed_data/compare/8d29573..a20be90): a20be90 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#69) usage (https://github.com/dart-lang/usage/compare/6ee0908..09bb847): 09bb847 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#196) watcher (https://github.com/dart-lang/watcher/compare/3f17faa..7457413): 7457413 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#148) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/7fb82f2..7ae4d0f): 7ae4d0f 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#274) webdev (https://github.com/dart-lang/webdev/compare/8360d50..f0ba743): f0ba7438 2023-07-07 Elliott Brooks Reset webdev to version 3.0.7-wip (#2170) 2fcc1ba9 2023-07-06 Anna Gringauze Add option of running frontend server tests in canary mode (#2169) 632763a5 2023-07-06 Elliott Brooks Prepare webdev for release to 3.0.6 (#2167) fa7b6d44 2023-07-05 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.3 (#2163) 2a6a457b 2023-07-05 Devon Carew regenerate from the latest mono_repo (#2165) cbb0d76a 2023-07-05 Anna Gringauze Run instance tests with frontend server (#2160) b672e98a 2023-07-05 Elliott Brooks Reset DWDS after release (#2168) 8ef92d71 2023-07-05 Elliott Brooks Prepare DWDS for release to version 19.0.2 (#2166) 77e5b373 2023-07-05 Elliott Brooks Handle potential `null` value in `setUpChromeConsoleListeners` (#2162) 5081dff0 2023-07-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#2164) yaml (https://github.com/dart-lang/yaml/compare/0b9041d..7930148): 7930148 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#148) Change-Id: I095a2479946e13d8499f1b3a58dc5a82688063f6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313020 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
…li_util, clock, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, http, lints, logging, markdown, matcher, mime, native, path, pool, shelf, source_map_stack_trace, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, tools, typed_data, watcher, yaml, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/b65622a..75efa6c): 75efa6c 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#250) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/c29d162..f950bbf): f950bbf 2023-08-31 Parker Lougheed Regenerate worker protocol protos to add constructors and comments (#78) 9b4c6a0 2023-08-30 Parker Lougheed Update e2e_test dependencies (#79) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/303635d..f255921): f255921 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#50) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/27ec600..1f69393): 1f69393 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#48) cli_util (https://github.com/dart-lang/cli_util/compare/9b7ce78..44118e3): 44118e3 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#88) clock (https://github.com/dart-lang/clock/compare/263e508..1e75f08): 1e75f08 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#55) convert (https://github.com/dart-lang/convert/compare/79ee174..c058c8f): c058c8f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#86) crypto (https://github.com/dart-lang/crypto/compare/8b704c6..1e26879): 1e26879 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#151) csslib (https://github.com/dart-lang/csslib/compare/7e91228..bd30a1a): bd30a1a 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#188) dartdoc (https://github.com/dart-lang/dartdoc/compare/5fda5eb..695b218): 695b218c 2023-08-30 Sam Rawlins Tidy Category: (#3488) b26af96f 2023-08-30 Sam Rawlins Tidy up library exports (#3487) be35cb00 2023-08-29 Devon Carew Update dependabot.yaml (#3486) 649bb8d2 2023-08-29 Sam Rawlins Migrate to create_api_docs.dart (#3482) ecosystem (https://github.com/dart-lang/ecosystem/compare/f777da7..89e58de): 89e58de 2023-09-01 Hossein Yousefi also install flutter on validate (#160) f95d0f2 2023-09-01 Hossein Yousefi Add use-flutter arg to validate (#159) 8743a9d 2023-09-01 Moritz Pass a parameter for Flutter `firehose` support (#158) 54d1628 2023-08-31 Moritz Setup Flutter in publish workflow (#157) 8fa89c6 2023-08-31 Moritz Add flutter support (#155) 65817bf 2023-08-29 Moritz Switch to Pub API (#152) ffi (https://github.com/dart-lang/ffi/compare/e2c01a9..d36e05a): d36e05a 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#208) fixnum (https://github.com/dart-lang/fixnum/compare/00fa120..87ed065): 87ed065 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#114) http (https://github.com/dart-lang/http/compare/cad7d60..7fb6fd6): 7fb6fd6 2023-08-31 Brian Quinlan Clarify how to set the body without a content type header (#1014) lints (https://github.com/dart-lang/lints/compare/54cd7a0..da44af3): da44af3 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#144) logging (https://github.com/dart-lang/logging/compare/5214987..bcaad0f): bcaad0f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#147) markdown (https://github.com/dart-lang/markdown/compare/56e75df..6cfd6f1): 6cfd6f1 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#554) 52be591 2023-08-30 Parker Lougheed Fix a few more lints, no longer ignore line length (#552) matcher (https://github.com/dart-lang/matcher/compare/ce8f409..80910d6): 80910d6 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#227) mime (https://github.com/dart-lang/mime/compare/799b398..37ef637): 37ef637 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#104) native (https://github.com/dart-lang/native/compare/5a1361b..a2dfedc): a2dfedc 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#117) 8dfb0d2 2023-09-01 dependabot[bot] Bump nttld/setup-ndk from 1.2.0 to 1.3.1 (#118) path (https://github.com/dart-lang/path/compare/7c2324b..96d9183): 96d9183 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#150) pool (https://github.com/dart-lang/pool/compare/7700102..a5bee35): a5bee35 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#73) shelf (https://github.com/dart-lang/shelf/compare/73edd2b..2926f76): 2926f76 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#376) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/16e54fd..196d7bf): 196d7bf 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#41) sse (https://github.com/dart-lang/sse/compare/8cc5b11..eeb2588): eeb2588 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#87) 2bb1a6e 2023-09-01 dependabot[bot] Bump nanasess/setup-chromedriver from 2.1.1 to 2.2.0 (#88) stack_trace (https://github.com/dart-lang/stack_trace/compare/4ddd86d..bcf2a0b): bcf2a0b 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#140) stream_channel (https://github.com/dart-lang/stream_channel/compare/e54234f..0ce7ab6): 0ce7ab6 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#94) string_scanner (https://github.com/dart-lang/string_scanner/compare/413b57a..da9142c): da9142c 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#62) term_glyph (https://github.com/dart-lang/term_glyph/compare/423700a..1b28285): 1b28285 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#41) test (https://github.com/dart-lang/test/compare/d0fc4bd..27dcae1): 27dcae11 2023-09-01 dependabot[bot] Bump github/codeql-action from 2.21.2 to 2.21.5 (#2086) cf0a0a73 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#2085) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/36d8617..030193d): 030193d 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#55) test_process (https://github.com/dart-lang/test_process/compare/b360784..2a6ee23): 2a6ee23 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#47) tools (https://github.com/dart-lang/tools/compare/b72fae8..2c8cbd6): 2c8cbd6 2023-09-01 Jonas Finnemann Jensen Extension discovery 2.0.0 (#156) 3e12c2e 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#157) 0f28f80 2023-08-28 Kenzie Davisson Prepare extension_discovery for 1.0.1 release (#154) typed_data (https://github.com/dart-lang/typed_data/compare/a20be90..80e8943): 80e8943 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#72) watcher (https://github.com/dart-lang/watcher/compare/7457413..1aed03e): 1aed03e 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#149) yaml (https://github.com/dart-lang/yaml/compare/7930148..ae00187): ae00187 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#150) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/87dcf31..4a9734d): 4a9734d 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#56) 83f9033 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#54) Change-Id: Ie6b9d9ef138730b98e9df8cbb31c6cc330ada9f8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323703 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
This issue was originally filed by [email protected]
I have an issue with the following:
The problem is that the constructor (in this case there's only one, but there may be many) includes the name of the class. This is (as far as I can tell) unnecessary duplication. Every time you rename a class, you need to change the name in multiple places.
I understand this could be solved by an IDE (which would do the work for you). However, simpler text editors have their place, too.
Please implement a different syntax, perhaps a 'new' keyword. I don't care what the exact syntax is, as long as there isn't unnecessary duplication.
The text was updated successfully, but these errors were encountered: