Error messages from dartc cannot be parsed by Emacs

[peter-ahe-google]

Here is a patch that changes out put from:

fisk.dart/foo.dart:10:42: I'm an error message

to:

foo.dart:10:42: I'm an error message

diff --git a/dart/compiler/java/com/google/dart/compiler/DefaultErrorFormatter.java b/dart/compiler/java/com/google/dart/compiler/DefaultErrorFormatter.java
index df0cfe5..6844ffe 100644

--- a/dart/compiler/java/com/google/dart/compiler/DefaultErrorFormatter.java
+++ b/dart/compiler/java/com/google/dart/compiler/DefaultErrorFormatter.java
@@ -21,7 +21,7 @­@ public class DefaultErrorFormatter implements ErrorFormatter {
   public void format(DartCompilationError event) {
     outputStream.printf("%s:%d:%d: %s\n",
         (event.getSource() != null)

•        ? event.getSource().getName() : "<unknown-source-file>",
  

•        ? event.getSource().getUri() : "<unknown-source-file>",
  

           event.getLineNumber(),
           event.getColumnNumber(),
           event.getMessage());
  diff --git a/dart/compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java b/dart/compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java
  index 2ca3984..cecff64 100644

--- a/dart/compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java
+++ b/dart/compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java
@@ -73,7 +73,7 @­@ public class PrettyErrorFormatter extends DefaultErrorFormatter {
       StringBuilder buf = new StringBuilder();
       buf.append(String.format("%s%s:%d: %s%s\n",
             useColor ? RED_BOLD_COLOR : "",

•        sourceFile.getName(),
  

•        sourceFile.getUri(),
  

               event.getLineNumber(),
               event.getMessage(),
               useColor ? NO_COLOR : ""));

[DartBot]

This comment was originally written by [email protected]

---

Set owner to @jtmcdole.
Added Accepted label.

[jtmcdole]

Change: low,enhancement

We feel the library name is important. Would "lib:file:line:col:<msg>" work?

---

Removed Type-Defect, Priority-Medium labels.
Added Type-Enhancement, Priority-Low labels.

[peter-ahe-google]

That won't work, see:
http://www.gnu.org/prep/standards/html_node/Errors.html

[peter-ahe-google]

Any progress on this? Currently, dartc is unusable from the command line because is produces bogus error messages.

[jtmcdole]

I'll update it today and send something to you.

[peter-ahe-google]

Never mind, I withdraw this bug report.

---

Added Invalid label.

[jtmcdole]

http://codereview.chromium.org/8949055/
http://code.google.com/p/dart/source/detail?r=2763

---

Added Fixed label.