native_BoolImplementation_EQ treats Boolean objects in a wrong way

[DartBot]

This issue was originally filed by [email protected]

---

http://code.google.com/p/dart/source/browse/trunk/dart/compiler/lib/implementation/bool.js#­19

Boolean(new Boolean(true)) === Boolean(new Boolean(false)) === true.

It is not clear whether this code is really needed.

Pointed out by Andrea Giammarchi.

[DartBot]

This comment was originally written by [email protected]

---

function EQ(other) {
  return typeof other == "boolean" || other instanceof Boolean ?
    this == other.valueOf() :
    false
  ;
}

[DartBot]

This comment was originally written by [email protected]

---

... and that should be called native_BoolImplementation_EQ I guess ...

[DartBot]

This comment was originally written by [email protected]

---

Set owner to [email protected].
Added Area-Compiler, Triaged labels.

[floitschG]

We should not need to look at "Boolean". The whole runtime only works with the primitive type.

Furhermore, we might want to shortcut the equality test in EQ$Operator.(http://code.google.com/p/dart/source/browse/trunk/dart/compiler/lib/implementation/core.js)
Currently we only test for numbers, but testing for booleans would avoid creating the wrapper object.

[DartBot]

This comment was originally written by [email protected]

---

Set owner to [email protected].

[DartBot]

This comment was originally written by [email protected]

---

r456, I had been meaning clean this up for quite a while.

---

Added Fixed label.