Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the precedence of bitwise operators #114

Closed
DartBot opened this issue Oct 14, 2011 · 18 comments
Closed

Change the precedence of bitwise operators #114

DartBot opened this issue Oct 14, 2011 · 18 comments
Assignees
@gbracha
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). type-enhancement A request for a change that isn't a bug
Milestone
M7

Comments

@DartBot
Copy link

DartBot commented Oct 14, 2011

This issue was originally filed by [email protected]

Like JavaScript, Java, and C, Dart places the precedence of the bitwise operators (|, &, and ^) below the equality and relational operators. I'd like to see the bitwise operators bind tighter.

The existing precedence is mostly a historical accident from C. Even Dennis Ritchie (RIP) admitted that it was a mistake in retrospect: https://groups.google.com/d/msg/net.lang.c/tw-N5MiDtZI/wH2TmPLdUTYJ

This change requires fewer parentheses and causes no harm to people expecting the current precedence since these operators don't work on booleans anyway.
@floitschG
Copy link
Contributor

This sounds like a good idea.

Added Area-Language, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Oct 17, 2011

This comment was originally written by [email protected]

Has this change be finalized? If so, what test case covers it?

@iposva-google
Copy link
Contributor

Set owner to @gbracha.
Removed Type-Defect label.
Added Type-Enhancement, Accepted labels.

@floitschG
Copy link
Contributor

No test cases yet. If you need test-cases I can write some, but I expected the first implementor (Vm or dartc) to write one.

@iposva-google
Copy link
Contributor

Marked this as blocking #116.

@gbracha
Copy link
Contributor

gbracha commented Oct 18, 2011

This change has NOT been finalized. It is a feature request that we are quite sympathetic to, but no change has happened yet. We may want to wait and let things stabilize slightly before making such changes.

@DartBot
Copy link
Author

DartBot commented Oct 19, 2011

This comment was originally written by [email protected]

Marked this as blocking #117.

@iposva-google
Copy link
Contributor

Unmarked this as blocking #-116.

@anders-sandholm
Copy link
Contributor

Added apr30-triage label.

@anders-sandholm
Copy link
Contributor

Removed apr30-triage label.

@anders-sandholm
Copy link
Contributor

Added triage1 label.

@anders-sandholm
Copy link
Contributor

Makes sense. Pushed to a later milestone.

Added this to the Later milestone.
Removed triage1 label.

@kasperl
Copy link

kasperl commented Aug 29, 2012

Removed this from the Later milestone.
Added this to the M3 milestone.

@lrhn
Copy link
Member

lrhn commented Jan 16, 2013

This change makes less sense if booleans have & and | operators as well. In that case, you would want "foo() == 42 & baz() == 37" to work on the booleans.

@gbracha
Copy link
Contributor

gbracha commented Feb 14, 2013

Removed this from the M3 milestone.
Added this to the M4 milestone.

@gbracha
Copy link
Contributor

gbracha commented Apr 12, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@lrhn
Copy link
Member

lrhn commented Sep 11, 2013

Removed this from the M5 milestone.
Added this to the M7 milestone.

@gbracha
Copy link
Contributor

gbracha commented Sep 11, 2013

The draft 0.61 spec fixes this.

Added Done label.

@DartBot DartBot added Type-Enhancement area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). labels Sep 11, 2013
@DartBot DartBot added this to the M7 milestone Sep 11, 2013
This was referenced Jun 3, 2015
Closed
Closed
This was referenced Jun 3, 2015
Closed
Closed
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
nex3 pushed a commit that referenced this issue Aug 31, 2016
Merge pull request #114 from chalin/chalin-0327-test-script-refactor
33aab9c 
Reuse test.sh under Travis and fixe failing test
@matanlurey matanlurey mentioned this issue Jun 8, 2017
Closed
@a-siva a-siva mentioned this issue Mar 10, 2018
Closed
@pneves001 pneves001 mentioned this issue Jul 14, 2018
Closed
@MananKakadiya MananKakadiya mentioned this issue Sep 25, 2018
Closed
@martinory martinory mentioned this issue Jun 27, 2019
Closed
@filiph filiph mentioned this issue Oct 15, 2019
Closed
@filiph filiph mentioned this issue Nov 5, 2019
Closed
@datayeah datayeah mentioned this issue Jul 7, 2020
Closed
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
@pinkfish pinkfish mentioned this issue Jan 25, 2021
Closed
@KTOLE18 KTOLE18 mentioned this issue Aug 10, 2021
Closed
@chgibb chgibb mentioned this issue Nov 29, 2021
Closed
copybara-service bot pushed a commit that referenced this issue Jun 2, 2022
@devoncarew
[deps] update bazel_worker, collection, mockito, pub_semver, test_des…
8f9e40b 
…criptor, stack_trace, usage, watcher

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/ceeba09..9710de6):
  9710de6  2022-04-19  Devon Carew  Update pubspec.yaml (#62)
  ec5905a  2022-03-20  Kevin Moore  Fix CI (#61)

collection (https://github.com/dart-lang/collection/compare/e1407da..69766da):
  69766da  2022-05-25  Nate Bosch  Add complexity bound on binary search methods (#239)
  5b43ad7  2022-04-08  Kevin Moore  Fix analysis issue with latest dev release (#236)
  e83c373  2022-04-08  Enrico Zamagni  fixed maxBy compare param signature (#224)
  c1a07e4  2022-04-08  Sandro Lovnički  Add a comment about NaN in min/max extensions (#234)
  2bbb27b  2022-03-07  Nate Bosch  Prepare to publish (#233)

mockito (https://github.com/dart-lang/mockito/compare/1e977a7..fcd6b28):
  fcd6b28  2022-05-16  srawlins  Release mockito 5.2.0
  2faf8f1  2022-05-16  srawlins  Import dart-lang/mockito#533
  0f8ed0c  2022-04-19  Devon Carew  Populate the pubspec 'repository' field.
  d399ca8  2022-05-13  fzyzcjy  Fix compile errors in Flutter 3.0
  948973e  2022-04-06  Samuel Rawlins  clarify docs for unsupportedMembers.
  b86c24d  2022-03-14  srawlins  Support `@GenerateMocks` annotations on `import` and `export` directives.
  c6971dd  2022-03-05  srawlins  Fix generation of methods with return type of `FutureOr<T>`.

pub_semver (https://github.com/dart-lang/pub_semver/compare/ea6c540..5c0b4bf):
  5c0b4bf  2022-03-07  Devon Carew  Update README.md (#65)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/ead23c1..5ed5d7f):
  5ed5d7f  2022-05-24  Nate Bosch  Move TestOn annotation to library level (#41)
  ecb2447  2022-05-03  Devon Carew  populate the repository field (#40)
  776a4c4  2022-03-02  dependabot[bot]  Bump actions/checkout from 2 to 3 (#39)
  d8eb6bd  2021-10-04  Kevin Moore  Migrate to pkg:lints, enable two disable lints (#38)

stack_trace (https://github.com/dart-lang/stack_trace/compare/5220580..17f09c2):
  17f09c2  2022-05-03  Devon Carew  Merge pull request #117 from dart-lang/repository_field
  a6403d0  2022-05-03  Devon Carew  switch to package:lints
  ae8b883  2022-05-03  Devon Carew  add markdown badges
  eed6081  2022-05-03  Devon Carew  populate the pubspec repository field
  46f6ee1  2022-02-01  Nate Bosch  Change a TODO to a permanent comment (#114)

usage (https://github.com/dart-lang/usage/compare/e85d575..79eef48):
  79eef48  2022-05-25  Devon Carew  refactor the github action (#177)
  f296352  2022-05-02  dependabot[bot]  Bump actions/checkout from 2 to 3 (#176)
  8852f1a  2022-05-02  Devon Carew  Update dependabot to watch github actions (#175)
  2d5b693  2022-04-26  Devon Carew  Update README.md (#174)
  2b2f3f8  2022-04-20  Devon Carew  Switch from homepage to repository in pubspec (#173)
  9b90d7c  2022-04-14  Devon Carew  Update dependabot.yaml (#172)

watcher (https://github.com/dart-lang/watcher/compare/f76997a..e00c0ea):
  e00c0ea  2022-01-19  Danny Tuppeny  Add/enable Windows tests (#124)


Change-Id: I0d48d3a7831040a18c996120cd51898e24215512
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246725
Reviewed-by: Nate Bosch <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
@Mufaddal1125 Mufaddal1125 mentioned this issue May 13, 2023
Closed
@FarhanAli-98 FarhanAli-98 mentioned this issue Jun 8, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Jun 20, 2023
@devoncarew
[deps] rev bazel_worker, dartdoc, http, protobuf, source_maps, tools,…
053e7b2 
… webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/c14a268..f7b714e):
  f7b714e  2023-06-16  Jacob MacDonald  add firehose publishing workflow (#76)
  0743f11  2023-06-16  Parker Lougheed  Require protobuf 3.0.0 and prepare for 1.0.3 release (#75)

dartdoc (https://github.com/dart-lang/dartdoc/compare/5799424..793d575):
  793d575d  2023-06-14  Sam Rawlins  Remove unused coverage feature (#3444)
  19ad21a4  2023-06-14  Parker Lougheed  Replace `@sealed` meta usage with keyword (#3445)
  8e9d89e3  2023-06-12  Sam Rawlins  Remove all `@deprecated` elements. (#3250)
  2019791c  2023-06-12  dependabot[bot]  Bump actions/checkout from 3.5.2 to 3.5.3 (#3442)
  d34c7067  2023-06-12  dependabot[bot]  Bump github/codeql-action from 2.3.6 to 2.13.4 (#3443)

http (https://github.com/dart-lang/http/compare/ba7eb60..8c25057):
  8c25057  2023-06-16  Nate Bosch  Unskip a skipped test (#966)

protobuf (https://github.com/dart-lang/protobuf/compare/a9bf79f..e76bd74):
  e76bd74  2023-06-19  Ömer Sinan Ağacan  Remove protoc_plugin exe from repo, update .gitignore (#851)
  4b71e60  2023-06-16  Ömer Sinan Ağacan  Fix a change in protoc_plugin changelog (#846)
  f4ffa1d  2023-06-16  Ömer Sinan Ağacan  Fix missing protobuf import in grpc files (#845)

source_maps (https://github.com/dart-lang/source_maps/compare/dd5b5cd..58eef30):
  58eef30  2023-06-12  Kevin Moore  Require Dart 3, update lints (#79)

tools (https://github.com/dart-lang/tools/compare/8d6e8b8..02b5cc5):
  02b5cc5  2023-06-16  Brian Wilkerson  Add documentation for server events (#115)
  698bfe8  2023-06-15  Elias Yishak  Introducing new `Event` class that can be send via `analytics.send(Event event)` (#114)

webdev (https://github.com/dart-lang/webdev/compare/81ae77a..b58edb7):
  b58edb7d  2023-06-16  Elliott Brooks  Fix the DCM workflow (#2147)
  1551fe6c  2023-06-16  Elliott Brooks  Wrap VM service API methods in an error handler to convert any exceptions into type `RPCError`
(#2144)
  06abe901  2023-06-14  Elliott Brooks  Add more tests to daily testing cron job (#2138)
  5cb2dcf6  2023-06-13  Elliott Brooks  Use new error codes from package:vm_service (#2141)

Change-Id: I6779c6d20fbc69e83848f469df3e0b4d21420a9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310322
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
copybara-service bot pushed a commit that referenced this issue Sep 1, 2023
@devoncarew
[deps] rev async, bazel_worker, boolean_selector, browser_launcher, c…
e268258 
…li_util, clock, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, http, lints, logging, markdown, matcher, mime, native, path, pool, shelf, source_map_stack_trace, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, tools, typed_data, watcher, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/b65622a..75efa6c):
  75efa6c  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#250)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/c29d162..f950bbf):
  f950bbf  2023-08-31  Parker Lougheed  Regenerate worker protocol protos to add constructors and comments (#78)
  9b4c6a0  2023-08-30  Parker Lougheed  Update e2e_test dependencies (#79)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/303635d..f255921):
  f255921  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#50)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/27ec600..1f69393):
  1f69393  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#48)

cli_util (https://github.com/dart-lang/cli_util/compare/9b7ce78..44118e3):
  44118e3  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#88)

clock (https://github.com/dart-lang/clock/compare/263e508..1e75f08):
  1e75f08  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#55)

convert (https://github.com/dart-lang/convert/compare/79ee174..c058c8f):
  c058c8f  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#86)

crypto (https://github.com/dart-lang/crypto/compare/8b704c6..1e26879):
  1e26879  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#151)

csslib (https://github.com/dart-lang/csslib/compare/7e91228..bd30a1a):
  bd30a1a  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#188)

dartdoc (https://github.com/dart-lang/dartdoc/compare/5fda5eb..695b218):
  695b218c  2023-08-30  Sam Rawlins  Tidy Category: (#3488)
  b26af96f  2023-08-30  Sam Rawlins  Tidy up library exports (#3487)
  be35cb00  2023-08-29  Devon Carew  Update dependabot.yaml (#3486)
  649bb8d2  2023-08-29  Sam Rawlins  Migrate to create_api_docs.dart (#3482)

ecosystem (https://github.com/dart-lang/ecosystem/compare/f777da7..89e58de):
  89e58de  2023-09-01  Hossein Yousefi  also install flutter on validate (#160)
  f95d0f2  2023-09-01  Hossein Yousefi  Add use-flutter arg to validate (#159)
  8743a9d  2023-09-01  Moritz  Pass a parameter for Flutter `firehose` support (#158)
  54d1628  2023-08-31  Moritz  Setup Flutter in publish workflow (#157)
  8fa89c6  2023-08-31  Moritz  Add flutter support (#155)
  65817bf  2023-08-29  Moritz  Switch to Pub API (#152)

ffi (https://github.com/dart-lang/ffi/compare/e2c01a9..d36e05a):
  d36e05a  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#208)

fixnum (https://github.com/dart-lang/fixnum/compare/00fa120..87ed065):
  87ed065  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#114)

http (https://github.com/dart-lang/http/compare/cad7d60..7fb6fd6):
  7fb6fd6  2023-08-31  Brian Quinlan  Clarify how to set the body without a content type header (#1014)

lints (https://github.com/dart-lang/lints/compare/54cd7a0..da44af3):
  da44af3  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#144)

logging (https://github.com/dart-lang/logging/compare/5214987..bcaad0f):
  bcaad0f  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#147)

markdown (https://github.com/dart-lang/markdown/compare/56e75df..6cfd6f1):
  6cfd6f1  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#554)
  52be591  2023-08-30  Parker Lougheed  Fix a few more lints, no longer ignore line length (#552)

matcher (https://github.com/dart-lang/matcher/compare/ce8f409..80910d6):
  80910d6  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#227)

mime (https://github.com/dart-lang/mime/compare/799b398..37ef637):
  37ef637  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#104)

native (https://github.com/dart-lang/native/compare/5a1361b..a2dfedc):
  a2dfedc  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#117)
  8dfb0d2  2023-09-01  dependabot[bot]  Bump nttld/setup-ndk from 1.2.0 to 1.3.1 (#118)

path (https://github.com/dart-lang/path/compare/7c2324b..96d9183):
  96d9183  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#150)

pool (https://github.com/dart-lang/pool/compare/7700102..a5bee35):
  a5bee35  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#73)

shelf (https://github.com/dart-lang/shelf/compare/73edd2b..2926f76):
  2926f76  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#376)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/16e54fd..196d7bf):
  196d7bf  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#41)

sse (https://github.com/dart-lang/sse/compare/8cc5b11..eeb2588):
  eeb2588  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#87)
  2bb1a6e  2023-09-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 2.1.1 to 2.2.0 (#88)

stack_trace (https://github.com/dart-lang/stack_trace/compare/4ddd86d..bcf2a0b):
  bcf2a0b  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#140)

stream_channel (https://github.com/dart-lang/stream_channel/compare/e54234f..0ce7ab6):
  0ce7ab6  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#94)

string_scanner (https://github.com/dart-lang/string_scanner/compare/413b57a..da9142c):
  da9142c  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#62)

term_glyph (https://github.com/dart-lang/term_glyph/compare/423700a..1b28285):
  1b28285  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#41)

test (https://github.com/dart-lang/test/compare/d0fc4bd..27dcae1):
  27dcae11  2023-09-01  dependabot[bot]  Bump github/codeql-action from 2.21.2 to 2.21.5 (#2086)
  cf0a0a73  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#2085)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/36d8617..030193d):
  030193d  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#55)

test_process (https://github.com/dart-lang/test_process/compare/b360784..2a6ee23):
  2a6ee23  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#47)

tools (https://github.com/dart-lang/tools/compare/b72fae8..2c8cbd6):
  2c8cbd6  2023-09-01  Jonas Finnemann Jensen  Extension discovery 2.0.0 (#156)
  3e12c2e  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#157)
  0f28f80  2023-08-28  Kenzie Davisson  Prepare extension_discovery for 1.0.1 release (#154)

typed_data (https://github.com/dart-lang/typed_data/compare/a20be90..80e8943):
  80e8943  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#72)

watcher (https://github.com/dart-lang/watcher/compare/7457413..1aed03e):
  1aed03e  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#149)

yaml (https://github.com/dart-lang/yaml/compare/7930148..ae00187):
  ae00187  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#150)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/87dcf31..4a9734d):
  4a9734d  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#56)
  83f9033  2023-07-01  dependabot[bot]  Bump actions/checkout from 3.5.2 to 3.5.3 (#54)

Change-Id: Ie6b9d9ef138730b98e9df8cbb31c6cc330ada9f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323703
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
copybara-service bot pushed a commit that referenced this issue Sep 8, 2023
@devoncarew
[deps] rev dartdoc, leak_tracker, lints, native, webdev
d6200f8 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/a32ba3a..adc76e6):
  adc76e6d  2023-09-06  Parker Lougheed  Take advantage of a few Dart 3 features (#3491)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/098bafc..4616c8b):
  4616c8b  2023-09-05  Polina Cherkasova  Note about OverlayEntry. (#142)
  fd7d70f  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#141)
  c6c1004  2023-09-01  Polina Cherkasova  - (#139)
  0298e20  2023-08-31  Polina Cherkasova  Add a test specific rule. (#138)
  ea17fa4  2023-08-29  Polina Cherkasova  Increase version of leak_tracker_flutter_testing (#136)
  8f830d6  2023-08-29  Polina Cherkasova  Update pubspec.yaml (#135)
  8a54575  2023-08-29  Polina Cherkasova  Enable connection to vm service for flutter testing and define matcher for reporting for memory
allocations. (#128)
  88a19a7  2023-08-28  Polina Cherkasova  - (#133)
  2070856  2023-08-24  Polina Cherkasova  Add instruction to start tracking instances of ChangeNotifier earlier. (#130)
  eb6113a  2023-08-23  Polina Cherkasova  Measure how memory is consumed by a test. (#114)
  72264f7  2023-08-22  Polina Cherkasova  Fix misspelling. (#131)
  87c9e9e  2023-08-16  Polina Cherkasova  Add debugging construcstors to LeakTrackingTestConfig, per leak type. (#129)
  b29547a  2023-08-15  Polina Cherkasova  Create visibility for roadmap for leak_tracker. (#124)
  23b15b6  2023-08-15  Polina Cherkasova  Fix issue of using wrong settings for a phase. (#122)
  713f646  2023-08-11  Polina Cherkasova  Enable global configuration for leak tracking. (#121)
  19b01cf  2023-08-10  Polina Cherkasova  Create package leak_tracker_flutter_testing. (#119)
  02d0b2f  2023-08-07  Polina Cherkasova  Stop failing if object is disposed twice. (#117)
  2026379  2023-08-04  Polina Cherkasova  Remove not-published versions and increase leak_tracker version. (#116)
  9bb71c6  2023-08-04  Polina Cherkasova  Stop requiring registration of disposed objects. (#113)
  8939456  2023-08-04  Polina Cherkasova  Refactor dispatcher. (#115)
  6f54f5a  2023-08-01  Polina Cherkasova  Start vm service when needed. (#112)
  b045c5e  2023-08-01  Polina Cherkasova  Reorganize leak tracker for better performance. (#106)
  127b83c  2023-07-31  Polina Cherkasova  Update TROUBLESHOOT.md (#108)
  6dabd33  2023-07-31  Polina Cherkasova  Simplify and clarify instructions to fix leaks. (#107)
  c53db68  2023-07-25  Polina Cherkasova  Improve code structure. (#103)
  10cce1a  2023-07-24  Polina Cherkasova  Rename `gcCountBuffer` to `numberOfGcCycles`. (#101)
  3a061a4  2023-07-21  Polina Cherkasova  Improve doc comments. (#100)
  6e3f57c  2023-07-21  Polina Cherkasova  Fix and test cover case of customized `gcCountBuffer` (#99)
  2152aab  2023-07-21  Polina Cherkasova  Add details about hidden leaks. (#97)

lints (https://github.com/dart-lang/lints/compare/da44af3..8d5f750):
  8d5f750  2023-09-06  Devon Carew  move the list of lint rules from the readme to a separate rules.md file (#145)

native (https://github.com/dart-lang/native/compare/a2dfedc..387f894):
  387f894  2023-09-06  Gabriel Terwesten  [native_toolchain_c] Default handling for PIC/PIE compiler flags (#121)
  0a4e5f8  2023-09-06  Gabriel Terwesten  Add support for defines to `CBuilder` (#120)

webdev (https://github.com/dart-lang/webdev/compare/fc876cb..9487a45):
  9487a459  2023-09-05  Jacob Bang  Update README.md to use `dart pub` instead of `pub` (#2195)
  07367779  2023-08-31  Elliott Brooks  Pass the package config directly to the load strategy instead of depending on an app entrypoint
(#2203)
  0044d753  2023-08-24  Jonas Termansen  Fix conflicting webdev smoke package names. (#2202)
  6183f270  2023-08-23  Elliott Brooks  Allow client to specify a way to convert an absolute path into a g3-relative path (#2200)
  b244b899  2023-08-22  Elliott Brooks  Allow client to specify how to find the package config  (#2199)

Change-Id: Ic00adc68ec01cd0cc6e27be665436de5095d8d07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324801
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@devoncarew
[deps] rev async, boolean_selector, browser_launcher, cli_util, clock…
e29ae69 
…, convert, crypto, csslib, ecosystem, ffi, file, fixnum, html, http, lints, logging, markdown, matcher, mime, native, path, pool, protobuf, pub_semver, shelf, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, test_descriptor, test_process, test_reflective_loader, tools, typed_data, watcher, web_socket_channel, webdriver, webkit_inspection_protocol, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/def4482..9924570):
  9924570  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#255)
  61cdb0f  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#254)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/479e1c1..7f523c3):
  7f523c3  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#53)
  1ed2941  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#54)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/c2871b2..4f9e784):
  4f9e784  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#51)
  706c031  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#52)

cli_util (https://github.com/dart-lang/cli_util/compare/56c1235..500dffa):
  500dffa  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#91)
  c66e201  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#92)

clock (https://github.com/dart-lang/clock/compare/200a020..f975668):
  f975668  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#59)
  eb5d2f5  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#58)

convert (https://github.com/dart-lang/convert/compare/03242b2..f24afa7):
  f24afa7  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#89)
  a3e9bc5  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#90)

crypto (https://github.com/dart-lang/crypto/compare/36ead7c..f3e64d2):
  f3e64d2  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#155)
  7a7b517  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#156)

csslib (https://github.com/dart-lang/csslib/compare/f6b68dd..17346e5):
  17346e5  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#191)
  4bdc553  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#192)

ecosystem (https://github.com/dart-lang/ecosystem/compare/4acfcaf..dda7886):
  dda7886  2023-11-01  dependabot[bot]  Bump peter-evans/create-or-update-comment (#192)
  b681c56  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#193)
  0d768d4  2023-11-01  dependabot[bot]  Bump subosito/flutter-action from 2.10.0 to 2.12.0 (#190)
  178d244  2023-11-01  dependabot[bot]  Bump actions/github-script (#194)
  4b3e572  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#191)

ffi (https://github.com/dart-lang/ffi/compare/2faec28..c926657):
  c926657  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#219)
  3181ec0  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#220)

file (https://github.com/google/file.dart/compare/7418131..e7c03aa):
  e7c03aa  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.6.0 (#233)

fixnum (https://github.com/dart-lang/fixnum/compare/ef45eb5..3279f5d):
  3279f5d  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#120)
  4913894  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#121)

html (https://github.com/dart-lang/html/compare/49e2c8e..06bc148):
  06bc148  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#232)
  2630607  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#233)

http (https://github.com/dart-lang/http/compare/7240d0a..b9389fe):
  b9389fe  2023-11-01  dependabot[bot]  Bump futureware-tech/simulator-action from 2 to 3 (#1037)
  d7c36ae  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#1038)

lints (https://github.com/dart-lang/lints/compare/5c60f48..f58fd77):
  f58fd77  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#168)

logging (https://github.com/dart-lang/logging/compare/642ed21..324a0b5):
  324a0b5  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#150)
  e9b13b7  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#151)

markdown (https://github.com/dart-lang/markdown/compare/4e2e970..efb73b3):
  efb73b3  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#561)
  2e4a3bc  2023-11-01  dependabot[bot]  Bump subosito/flutter-action from 2.10.0 to 2.11.0 (#559)
  22e378b  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#560)

matcher (https://github.com/dart-lang/matcher/compare/7512f80..3d03fa1):
  3d03fa1  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#231)
  b7d24c8  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#232)

mime (https://github.com/dart-lang/mime/compare/af3e5fe..8ebf946):
  8ebf946  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#108)
  4328d32  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#107)

native (https://github.com/dart-lang/native/compare/279094d..de9d59e):
  de9d59e  2023-11-01  Daco Harkes  [infra] Fix PR publisher comments (#177)
  22b6b24  2023-11-01  Daco Harkes  [infra] Rename `dart.yaml` to `native.yaml` (#176)
  cc42fb1  2023-11-01  Daco Harkes  [native_toolchain_c] Use sysroot on Android (#180)
  01d92b0  2023-11-01  Daco Harkes  [native_toolchain_c] Bump highest tested NDK version to 34 (#182)
  53facde  2023-11-01  Daco Harkes  [native_toolchain_c] Fix NDK discovery (#179)
  285ee6c  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#174)
  46a05e4  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#172)
  23187fe  2023-11-01  dependabot[bot]  Bump nttld/setup-ndk from 1.3.1 to 1.4.1 (#173)

path (https://github.com/dart-lang/path/compare/4ca27d4..18ec71f):
  18ec71f  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#153)
  f26c20c  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#154)

pool (https://github.com/dart-lang/pool/compare/5ccef15..c78cef4):
  c78cef4  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#76)

protobuf (https://github.com/dart-lang/protobuf/compare/3f567b2..dcec2ed):
  dcec2ed  2023-10-31  Ömer Sinan Ağacan  Annotate deepCopy with @useResult (#897)

pub_semver (https://github.com/dart-lang/pub_semver/compare/8e5a58f..f9e94ee):
  f9e94ee  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#95)
  81fdbcf  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#94)

shelf (https://github.com/dart-lang/shelf/compare/c15fc6f..b3adc7c):
  b3adc7c  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#391)
  baea52d  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#392)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/73d449c..2209626):
  2209626  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#45)
  bfa3949  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#44)

source_maps (https://github.com/dart-lang/source_maps/compare/fc6aa16..87dc587):
  87dc587  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#84)
  33ba11d  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#85)

source_span (https://github.com/dart-lang/source_span/compare/92e50bf..ed16e0d):
  ed16e0d  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#105)
  aacd748  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#104)

sse (https://github.com/dart-lang/sse/compare/37df57d..8ddb95f):
  8ddb95f  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#95)
  8830125  2023-11-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 2.2.0 to 2.2.1 (#94)
  86dd8f9  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#93)

stack_trace (https://github.com/dart-lang/stack_trace/compare/634589f..6496ff8):
  6496ff8  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#145)
  3d60304  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#144)

stream_channel (https://github.com/dart-lang/stream_channel/compare/ffdb208..178104d):
  178104d  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#98)
  1193387  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#97)

string_scanner (https://github.com/dart-lang/string_scanner/compare/9c525f7..a7105ef):
  a7105ef  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#65)
  f33ca6f  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#66)

term_glyph (https://github.com/dart-lang/term_glyph/compare/cff80de..7c1eb9d):
  7c1eb9d  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#45)
  39073ca  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#44)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/55b5eac..c417cbb):
  c417cbb  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#59)
  dcfde39  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#58)

test_process (https://github.com/dart-lang/test_process/compare/d610333..c21e40d):
  c21e40d  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#51)
  bfd0576  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#50)

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/8593eb1..17d40bb):
  17d40bb  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#54)
  e664092  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#55)

tools (https://github.com/dart-lang/tools/compare/01c0b52..dd91cb6):
  dd91cb6  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#192)
  603b012  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#191)

typed_data (https://github.com/dart-lang/typed_data/compare/d1c15ed..0b16bd2):
  0b16bd2  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#76)
  f869102  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#77)

watcher (https://github.com/dart-lang/watcher/compare/6ad58dc..b2b278a):
  b2b278a  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#154)
  97e9637  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#155)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/f3ac1bf..82ac73f):
  82ac73f  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#289)
  3615850  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#290)

webdriver (https://github.com/google/webdriver.dart/compare/eaf9c58..43ed1db):
  43ed1db  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#289)
  02fd658  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#288)
  8828360  2023-11-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 2.2.0 to 2.2.1 (#287)

webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/82f0c1c..2c6f8b6):
  2c6f8b6  2023-11-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.1 (#114)
  d4e4d55  2023-11-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 2.2.0 to 2.2.1 (#115)

yaml (https://github.com/dart-lang/yaml/compare/9f0d649..98a3aab):
  98a3aab  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#154)
  b63372b  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#155)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/a7e7fba..9b9d33c):
  9b9d33c  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#61)
  b71c2e8  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#60)

Change-Id: I8b663f536d4e80728c6570372d886edfef227cf1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333059
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbracha gbracha

Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
M7
Development

No branches or pull requests
8 participants
@kevmoo @kasperl @anders-sandholm @gbracha @lrhn @iposva-google @floitschG @DartBot